-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deauth queue when user logs out (#397), restart threads if they fail (#380) #404
Conversation
I still need to review the code, but I followed the test plan and everything worked as described. I think this PR should also include removing the "Downloading file" message. It's pretty misleading since that's exactly what it is not doing. I read your comment about catching For now it might make sense to check whether or not the application is running in offline mode and returning a custom message for when they click on the Download link. Otherwise they will see this: |
3523131
to
4b37596
Compare
added a commit to implement the behavior from the user's perspective described in #379 which looks like the following: this means that currently we both:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with one nit
dismissing until i implement that nit / add more tests
4b37596
to
8edc797
Compare
* security bugfix: deauth queue when user logs out (#397) * make sure queues are started when we enqueue a new job (#380) * also ensure that we can, in one run of the client: 1. Log in, be authed to make network calls 2. Log out, not be authed to make network calls 3. Log _back_ in, once again be authed to make network calls * show "user must login" message when download clicked if offline
8edc797
to
447a166
Compare
taking another look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, my comments were addressed. just needs to be that follow-up issue and kushal was planning on reviewing this as well.
cool thanks, followup added in #419, @kushaldas feel free to take this for a spin tomorrow |
we all decided that this looks good to merge w/o a second review, merging... rip deauth queue |
Description
Fixes #397
Fixes #380
Test Plan
In a single run of the client:
Checklist
If these changes modify code paths involving cryptography, the opening of files in VMs, network (via the RPC service) traffic, or fine tuning of the graphical user interface, Qubes testing is required. Please check as applicable: