Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable configurable number of retries for each API job #384

Closed
redshiftzero opened this issue May 22, 2019 · 2 comments · Fixed by #421
Closed

Enable configurable number of retries for each API job #384

redshiftzero opened this issue May 22, 2019 · 2 comments · Fixed by #421
Assignees
Labels
enhancement New feature or request

Comments

@redshiftzero
Copy link
Contributor

We should have the queue retry each API job N times for robustness (e.g. when Tor is particularly flaky). See my comment here: #374 (comment)

@eloquence
Copy link
Member

Recap of rationale based on chat (please jump in if I'm misunderstanding): While we may want to effectively retry operations indefinitely even without explicit user action, there are at least two reasons why it makes sense to limit retries:

  1. We do want to keep track of retries so we can indicate that there are network problems to the user after a certain number of failures.

  2. If a queue item fails repeatedly, we'll want to use another, independent operation to check network conditions (e.g., refresh), in case it's just this particular queue operation that is being flaky in unexpected ways.

@redshiftzero
Copy link
Contributor Author

status of this ticket: I have a wip diff in retry-jobs-if-failed that needs tests adding and a rebase after #404 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants