Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for restarting threads #380

Closed
sssoleileraaa opened this issue May 22, 2019 · 0 comments · Fixed by #404
Closed

Add support for restarting threads #380

sssoleileraaa opened this issue May 22, 2019 · 0 comments · Fixed by #404
Assignees
@redshiftzero

Comments

@sssoleileraaa
Copy link
Contributor

If a thread aborts because it has no auth or timeout, there needs to be a way to restart it. Likely this would mean calling ApiJobQueue.start_queues() again, but as it's written now, this wouldn't restart the current threads but it would create new ones (or do some other badness).

~heartsucker

see #374 for more info
@sssoleileraaa sssoleileraaa mentioned this issue May 22, 2019
Merged
@eloquence eloquence changed the title Restarting threads Add support for restarting threads May 30, 2019
@redshiftzero redshiftzero self-assigned this Jun 7, 2019
redshiftzero added a commit that referenced this issue Jun 11, 2019
@redshiftzero
queue: rework login/logout
9b9c511 
* security bugfix: deauth queue when user logs out (#397)

* make sure queues are started when we enqueue a new job (#380)

* also ensure that we can, in one run of the client:

1. Log in, be authed to make network calls
2. Log out, not be authed to make network calls
3. Log _back_ in, once again be authed to make network calls

* show "user must login" message when download clicked if offline
@redshiftzero redshiftzero mentioned this issue Jun 11, 2019
Merged
2 tasks
redshiftzero added a commit that referenced this issue Jun 11, 2019
@redshiftzero
queue: rework login/logout
4116f81 
* security bugfix: deauth queue when user logs out (#397)

* make sure queues are started when we enqueue a new job (#380)

* also ensure that we can, in one run of the client:

1. Log in, be authed to make network calls
2. Log out, not be authed to make network calls
3. Log _back_ in, once again be authed to make network calls

* show "user must login" message when download clicked if offline
sssoleileraaa pushed a commit that referenced this issue Jun 13, 2019
@redshiftzero @sssoleileraaa
queue: rework login/logout
a0c1fd0 
* security bugfix: deauth queue when user logs out (#397)

* make sure queues are started when we enqueue a new job (#380)

* also ensure that we can, in one run of the client:

1. Log in, be authed to make network calls
2. Log out, not be authed to make network calls
3. Log _back_ in, once again be authed to make network calls

* show "user must login" message when download clicked if offline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@redshiftzero redshiftzero

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sssoleileraaa @redshiftzero