-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Queue stays authenticated after log out #397
Comments
so in #400 @creviera has a good idea which is to have one single place in the client ( I suggest we:
|
redshiftzero
added a commit
that referenced
this issue
Jun 5, 2019
also ensure that we can, in one run of the client: 1. Log in, be authed to make network calls 2. Log out, not be authed to make network calls 3. Log _back_ in, once again be authed to make network calls
2 tasks
redshiftzero
added a commit
that referenced
this issue
Jun 6, 2019
also ensure that we can, in one run of the client: 1. Log in, be authed to make network calls 2. Log out, not be authed to make network calls 3. Log _back_ in, once again be authed to make network calls
redshiftzero
added a commit
that referenced
this issue
Jun 11, 2019
* security bugfix: deauth queue when user logs out (#397) * make sure queues are started when we enqueue a new job (#380) * also ensure that we can, in one run of the client: 1. Log in, be authed to make network calls 2. Log out, not be authed to make network calls 3. Log _back_ in, once again be authed to make network calls * show "user must login" message when download clicked if offline
redshiftzero
added a commit
that referenced
this issue
Jun 11, 2019
* security bugfix: deauth queue when user logs out (#397) * make sure queues are started when we enqueue a new job (#380) * also ensure that we can, in one run of the client: 1. Log in, be authed to make network calls 2. Log out, not be authed to make network calls 3. Log _back_ in, once again be authed to make network calls * show "user must login" message when download clicked if offline
6 tasks
sssoleileraaa
pushed a commit
that referenced
this issue
Jun 13, 2019
* security bugfix: deauth queue when user logs out (#397) * make sure queues are started when we enqueue a new job (#380) * also ensure that we can, in one run of the client: 1. Log in, be authed to make network calls 2. Log out, not be authed to make network calls 3. Log _back_ in, once again be authed to make network calls * show "user must login" message when download clicked if offline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The queue stays authenticated after the user logs out. One can repro this via trying to download a file after you've logged out. This is a similar issue to #178, now re-occurring in the queue.
While this won't be possible after freedomofpress/securedrop#3933 is used in the client, regardless the queue should not attempt to send API requests to the server when the user is offline / not logged in.
One resolution would be to add a
logout()
method to theApiJobQueue
to update theapi_client
attribute after logout. This method would then get called by thelogout
method on the controller.The text was updated successfully, but these errors were encountered: