Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add item when mapped task #761

Merged
merged 4 commits into from
May 18, 2023
Merged

chore: add item when mapped task #761

merged 4 commits into from
May 18, 2023

Conversation

jsonporter
Copy link
Contributor

Note: This PR is WIP

Adds a more correct context to the attempts UI when dealing with mapped tasks.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

NA

Tracking Issue

NA

Follow-up issue

NA

@jsonporter jsonporter marked this pull request as draft May 17, 2023 20:14
@jsonporter jsonporter marked this pull request as ready for review May 18, 2023 18:01
Signed-off-by: Carina Ursu <[email protected]>
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #761 (74d7868) into master (e316bef) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #761   +/-   ##
=======================================
  Coverage   65.90%   65.91%           
=======================================
  Files         489      489           
  Lines       11918    11919    +1     
  Branches     2198     2198           
=======================================
+ Hits         7855     7856    +1     
  Misses       4063     4063           
Impacted Files Coverage Δ
...ons/TaskExecutionsList/MapTaskExecutionDetails.tsx 100.00% <ø> (ø)
...tions/TaskExecutionsList/TaskExecutionLogsCard.tsx 93.54% <ø> (ø)
...ages/console/src/components/Executions/contexts.ts 42.85% <ø> (ø)
packages/console/src/models/Task/index.ts 100.00% <100.00%> (ø)

@ursucarina ursucarina changed the title WIP: add item when mapped task chore: add item when mapped task May 18, 2023
@ursucarina ursucarina merged commit 333940f into master May 18, 2023
@ursucarina ursucarina deleted the json/mapped-task-item branch May 18, 2023 18:54
wild-endeavor added a commit to flyteorg/flyte that referenced this pull request May 22, 2023
Signed-off-by: Yee Hing Tong <[email protected]>

### Admin - v1.1.100
* Inject user identifier to ExecutionSpec by @ByronHsu in flyteorg/flyteadmin#549
* Fix flaky test by @eapolinario in flyteorg/flyteadmin#563
* Add oauth http proxy for external server & Extract email from azure claim by @ByronHsu in flyteorg/flyteadmin#553
* Remove single task execution default timeout by @hamersaw in flyteorg/flyteadmin#564
* Revert conditional setting of SecurityContext when launching security context by @wild-endeavor in flyteorg/flyteadmin#566

### Console - v1.8.2
* Export Flytedecks support for TLRO by @james-union in flyteorg/flyteconsole#757
* fix: filter executions by version and name by @ursucarina in flyteorg/flyteconsole#758
* fix: task recent runs should filter by version by @ursucarina in flyteorg/flyteconsole#759
* Bug: Execution Page's back button returns Workflows route from Launch Plan route #patch by @FrankFlitton in flyteorg/flyteconsole#760
* chore: add item when mapped task by @jsonporter in flyteorg/flyteconsole#761
* Feature: Fullview Flyte Deck modal by @FrankFlitton in flyteorg/flyteconsole#764

### Propeller - v1.1.90
* Add grpc plugin to loader.go by @pingsutw in flyteorg/flytepropeller#562
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.8.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants