Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter executions by version and name #758

Merged
merged 2 commits into from
May 15, 2023
Merged

fix: filter executions by version and name #758

merged 2 commits into from
May 15, 2023

Conversation

ursucarina
Copy link
Contributor

TL;DR

Workflow executions queries should filter by version + name

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Workflow executions queries should filter by version + name

Tracking Issue

NA

@ursucarina ursucarina requested review from a team, jsonporter, 4nalog and james-union and removed request for a team May 15, 2023 22:48
Signed-off-by: Carina Ursu <[email protected]>
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #758 (bef42a7) into master (22ed97f) will not change coverage.
The diff coverage is n/a.

❗ Current head bef42a7 differs from pull request most recent head 5fd3120. Consider uploading reports for the commit 5fd3120 to get more accurate results

@@           Coverage Diff           @@
##           master     #758   +/-   ##
=======================================
  Coverage   65.90%   65.90%           
=======================================
  Files         489      489           
  Lines       11915    11915           
  Branches     2196     2196           
=======================================
  Hits         7853     7853           
  Misses       4062     4062           
Impacted Files Coverage Δ
...ages/console/src/components/Entities/generators.ts 65.11% <ø> (ø)

@jsonporter jsonporter merged commit a4802e0 into master May 15, 2023
@jsonporter jsonporter deleted the carina/pfix branch May 15, 2023 23:01
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.8.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

wild-endeavor added a commit to flyteorg/flyte that referenced this pull request May 22, 2023
Signed-off-by: Yee Hing Tong <[email protected]>

### Admin - v1.1.100
* Inject user identifier to ExecutionSpec by @ByronHsu in flyteorg/flyteadmin#549
* Fix flaky test by @eapolinario in flyteorg/flyteadmin#563
* Add oauth http proxy for external server & Extract email from azure claim by @ByronHsu in flyteorg/flyteadmin#553
* Remove single task execution default timeout by @hamersaw in flyteorg/flyteadmin#564
* Revert conditional setting of SecurityContext when launching security context by @wild-endeavor in flyteorg/flyteadmin#566

### Console - v1.8.2
* Export Flytedecks support for TLRO by @james-union in flyteorg/flyteconsole#757
* fix: filter executions by version and name by @ursucarina in flyteorg/flyteconsole#758
* fix: task recent runs should filter by version by @ursucarina in flyteorg/flyteconsole#759
* Bug: Execution Page's back button returns Workflows route from Launch Plan route #patch by @FrankFlitton in flyteorg/flyteconsole#760
* chore: add item when mapped task by @jsonporter in flyteorg/flyteconsole#761
* Feature: Fullview Flyte Deck modal by @FrankFlitton in flyteorg/flyteconsole#764

### Propeller - v1.1.90
* Add grpc plugin to loader.go by @pingsutw in flyteorg/flytepropeller#562
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants