This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Inject user identifier to ExecutionSpec #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByronHsu
requested review from
katrogan,
wild-endeavor,
EngHabu,
kumare3,
pmahindrakar-oss,
hamersaw and
eapolinario
as code owners
ByronHsu
changed the title
ByronHsu
changed the title
8 tasks
ByronHsu
changed the title
ByronHsu
force-pushed
the
github/add-userid
branch
from
d04c400 to
ea42686
Compare
ByronHsu
changed the title
ByronHsu
changed the title
auth/identity_context.go
Outdated
| } | ||
|
|
||
| // SetUserIdentifier allows you to explicitly set user identifier | ||
| func (c *IdentityContext) SetUserIdentifier(id string) IdentityContext { |
There was a problem hiding this comment.
does this need to return something? can it just not return anything?
| // We skip getUserIdentityFromContext but can still get ExecUserId because flytepropeller passes it in the execution request. | ||
| // https://github.com/flyteorg/flytepropeller/blob/03a6672960ed04e7687ba4f790fee9a02a4057fb/pkg/controller/nodes/subworkflow/launchplan/admin.go#L114 | ||
| if workflowExecConfig.GetSecurityContext().GetRunAs().GetUserIdentifier() == "" { | ||
| workflowExecConfig.SecurityContext.RunAs.UserIdentifier = auth.IdentityContextFromContext(ctx).UserIdentifier() |
There was a problem hiding this comment.
when admin is running without auth, this still won't fail right?
There was a problem hiding this comment.
yeah UserIdentifier would just be an empty string
ByronHsu
force-pushed
the
github/add-userid
branch
from
7b52783 to
b080fac
Compare
Signed-off-by: byhsu <[email protected]>
Signed-off-by: byhsu <[email protected]>
Signed-off-by: byhsu <[email protected]>
Signed-off-by: byhsu <[email protected]>
Signed-off-by: byhsu <[email protected]>
Signed-off-by: byhsu <[email protected]>
Signed-off-by: byhsu <[email protected]>
Signed-off-by: byhsu <[email protected]>
ByronHsu
force-pushed
the
github/add-userid
branch
from
b080fac to
3e2b93d
Compare
wild-endeavor
previously approved these changes
May 9, 2023
Signed-off-by: byhsu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #549 +/- ##
==========================================
+ Coverage 58.37% 59.95% +1.58%
==========================================
Files 168 168
Lines 16104 13195 -2909
==========================================
- Hits 9400 7911 -1489
+ Misses 5866 4445 -1421
- Partials 838 839 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: byhsu <[email protected]>
wild-endeavor
previously approved these changes
May 9, 2023
EngHabu
reviewed
May 9, 2023
Signed-off-by: byhsu <[email protected]>
Signed-off-by: byhsu <[email protected]>
Signed-off-by: byhsu <[email protected]>
Signed-off-by: byhsu <[email protected]>
Signed-off-by: byhsu <[email protected]>
Signed-off-by: byhsu <[email protected]>
wild-endeavor
previously approved these changes
May 12, 2023
pingsutw
previously approved these changes
May 12, 2023
Signed-off-by: Yee Hing Tong <[email protected]>
wild-endeavor
approved these changes
May 12, 2023
pingsutw
approved these changes
May 13, 2023
LaPetiteSouris
pushed a commit
to LaPetiteSouris/flyteadmin
that referenced
this pull request
May 16, 2023
Signed-off-by: byhsu <[email protected]> This pr provides a middleware to inject user identifier to ExecutionSpec. By default, the value of the user identifier is userid from access/id token. Users can customize their own middleware and inject different values. Signed-off-by: TungHoang <[email protected]>
wild-endeavor
added a commit
to flyteorg/flyte
that referenced
this pull request
May 22, 2023
Signed-off-by: Yee Hing Tong <[email protected]> ### Admin - v1.1.100 * Inject user identifier to ExecutionSpec by @ByronHsu in flyteorg/flyteadmin#549 * Fix flaky test by @eapolinario in flyteorg/flyteadmin#563 * Add oauth http proxy for external server & Extract email from azure claim by @ByronHsu in flyteorg/flyteadmin#553 * Remove single task execution default timeout by @hamersaw in flyteorg/flyteadmin#564 * Revert conditional setting of SecurityContext when launching security context by @wild-endeavor in flyteorg/flyteadmin#566 ### Console - v1.8.2 * Export Flytedecks support for TLRO by @james-union in flyteorg/flyteconsole#757 * fix: filter executions by version and name by @ursucarina in flyteorg/flyteconsole#758 * fix: task recent runs should filter by version by @ursucarina in flyteorg/flyteconsole#759 * Bug: Execution Page's back button returns Workflows route from Launch Plan route #patch by @FrankFlitton in flyteorg/flyteconsole#760 * chore: add item when mapped task by @jsonporter in flyteorg/flyteconsole#761 * Feature: Fullview Flyte Deck modal by @FrankFlitton in flyteorg/flyteconsole#764 ### Propeller - v1.1.90 * Add grpc plugin to loader.go by @pingsutw in flyteorg/flytepropeller#562
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Signed-off-by: byhsu <[email protected]> This pr provides a middleware to inject user identifier to ExecutionSpec. By default, the value of the user identifier is userid from access/id token. Users can customize their own middleware and inject different values.
3 tasks
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This pr provides a middleware to inject user identifier to ExecutionSpec.
By default, the value of the user identifier is userid from access/id token.
Users can customize their own middleware and inject different values.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#3566