Export Flytedecks support for TLRO (#757)

* fix: export ExecutionNodeDeck with few css changes Signed-off-by: James <[email protected]> * fix: upgrade version Signed-off-by: James <[email protected]> * chore: yarn.lock Signed-off-by: Carina Ursu <[email protected]> --------- Signed-off-by: James <[email protected]> Signed-off-by: Carina Ursu <[email protected]> Co-authored-by: Carina Ursu <[email protected]>
flyteorg · May 15, 2023 · 22ed97f · 22ed97f
1 parent b7c4b80
commit 22ed97f
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 8 deletions.
diff --git a/packages/console/package.json b/packages/console/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@flyteorg/console",
-  "version": "0.0.31",
+  "version": "0.0.32",
   "description": "Flyteconsole main app module",
   "main": "./dist/index.js",
   "module": "./lib/index.js",

diff --git a/packages/console/src/components/Executions/ExecutionDetails/ExecutionDetailsActions.tsx b/packages/console/src/components/Executions/ExecutionDetails/ExecutionDetailsActions.tsx
@@ -38,9 +38,6 @@ const useStyles = makeStyles((theme: Theme) => {
       maxHeight: `calc(100% - ${theme.spacing(12)}px)`,
       height: theme.spacing(90),
       width: theme.spacing(110),
-      '& iframe': {
-        border: 'none',
-      },
     },
     dialogTitle: {
       display: 'flex',

diff --git a/packages/console/src/components/Executions/ExecutionDetails/ExecutionNodeDeck.tsx b/packages/console/src/components/Executions/ExecutionDetails/ExecutionNodeDeck.tsx
@@ -6,15 +6,19 @@ import { Core } from '@flyteorg/flyteidl-types';
 /** Fetches and renders the deck data for a given `nodeExecutionId` */
 export const ExecutionNodeDeck: React.FC<{
   nodeExecutionId: Core.NodeExecutionIdentifier;
-}> = ({ nodeExecutionId }) => {
+  className?: string;
+}> = ({ nodeExecutionId, className = '' }) => {
   const downloadLink = useDownloadLink(nodeExecutionId);
 
   return (
     <WaitForData {...downloadLink}>
       <iframe
         title="deck"
+        width="100%"
         height="100%"
         src={downloadLink?.value?.signedUrl?.[0]}
+        className={className}
+        style={{ border: 'none' }}
       />
     </WaitForData>
   );

diff --git a/packages/console/src/components/Executions/ExecutionDetails/index.ts b/packages/console/src/components/Executions/ExecutionDetails/index.ts
@@ -1,3 +1,4 @@
 export * from './ExecutionDetails';
 export * from './ExecutionDetailsActions';
 export * from './useExecutionNodeViewsState';
+export * from './ExecutionNodeDeck';
diff --git a/website/package.json b/website/package.json
@@ -37,7 +37,7 @@
   },
   "dependencies": {
     "@flyteorg/common": "^0.0.4",
-    "@flyteorg/console": "^0.0.31",
+    "@flyteorg/console": "^0.0.32",
     "long": "^4.0.0",
     "protobufjs": "~6.11.3",
     "react-ga4": "^1.4.1",

diff --git a/yarn.lock b/yarn.lock
@@ -2020,7 +2020,7 @@ __metadata:
   resolution: "@flyteconsole/client-app@workspace:website"
   dependencies:
     "@flyteorg/common": ^0.0.4
-    "@flyteorg/console": ^0.0.31
+    "@flyteorg/console": ^0.0.32
     "@types/long": ^3.0.32
     long: ^4.0.0
     protobufjs: ~6.11.3
@@ -2059,7 +2059,7 @@ __metadata:
   languageName: unknown
   linkType: soft
 
-"@flyteorg/console@^0.0.31, @flyteorg/console@workspace:packages/console":
+"@flyteorg/console@^0.0.32, @flyteorg/console@workspace:packages/console":
   version: 0.0.0-use.local
   resolution: "@flyteorg/console@workspace:packages/console"
   dependencies: