Skip to content

Commit

Permalink
feat: added support for mapped task parent retryAttempt (#756)
Browse files Browse the repository at this point in the history
* feat: added support for mapped task parent retryAttempt

Signed-off-by: Jason Porter <[email protected]>

* chore: upgrade pkg

Signed-off-by: Carina Ursu <[email protected]>

* chore: yarn.lock

Signed-off-by: Carina Ursu <[email protected]>

---------

Signed-off-by: Jason Porter <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Co-authored-by: Carina Ursu <[email protected]>
  • Loading branch information
jsonporter and ursucarina authored May 11, 2023
1 parent d985dfd commit b7c4b80
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion packages/console/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@flyteorg/console",
"version": "0.0.30",
"version": "0.0.31",
"description": "Flyteconsole main app module",
"main": "./dist/index.js",
"module": "./lib/index.js",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ export const MapTaskExecutionsListItem: React.FC<
<TaskExecutionError error={error} />
</section>
) : null}

{/* If main map task has log attached - show it here */}
{logs && logs.length > 0 ? (
<section className={styles.section}>
Expand All @@ -99,7 +98,6 @@ export const MapTaskExecutionsListItem: React.FC<
/>
);
})}

{/* If map task is actively started - show 'started' and 'run time' details */}
{taskHasStarted && (
<section className={styles.section}>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import Typography from '@material-ui/core/Typography';
import classnames from 'classnames';
import { useCommonStyles } from 'components/common/styles';
import { TaskExecutionPhase } from 'models/Execution/enums';
import { TaskExecution } from 'models/Execution/types';
import { MapTaskExecution, TaskExecution } from 'models/Execution/types';
import { Core } from '@flyteorg/flyteidl-types';
import { ExternalConfigHoc } from 'basics/ExternalConfigHoc';
import { useExternalConfigurationContext } from 'basics/ExternalConfigurationProvider';
Expand Down Expand Up @@ -36,7 +36,7 @@ const useStyles = makeStyles((theme: Theme) => ({
}));

interface TaskExecutionLogsCardProps {
taskExecution: TaskExecution;
taskExecution: TaskExecution | MapTaskExecution;
headerText: string;
phase: TaskExecutionPhase;
logs: Core.ITaskLog[];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ export const TaskNameList = ({
onTaskSelected({
...taskExecution,
taskIndex: (log as any).index,
parentRetryAttempt: taskExecution.id.retryAttempt,
});
};

Expand Down
1 change: 1 addition & 0 deletions packages/console/src/models/Execution/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ export interface TaskExecutionIdentifier extends Core.ITaskExecutionIdentifier {
}
export interface MapTaskExecution extends TaskExecution {
taskIndex: number | null;
parentRetryAttempt?: number;
}

export interface TaskExecution extends Admin.ITaskExecution {
Expand Down
2 changes: 1 addition & 1 deletion website/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
},
"dependencies": {
"@flyteorg/common": "^0.0.4",
"@flyteorg/console": "^0.0.30",
"@flyteorg/console": "^0.0.31",
"long": "^4.0.0",
"protobufjs": "~6.11.3",
"react-ga4": "^1.4.1",
Expand Down
4 changes: 2 additions & 2 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2020,7 +2020,7 @@ __metadata:
resolution: "@flyteconsole/client-app@workspace:website"
dependencies:
"@flyteorg/common": ^0.0.4
"@flyteorg/console": ^0.0.30
"@flyteorg/console": ^0.0.31
"@types/long": ^3.0.32
long: ^4.0.0
protobufjs: ~6.11.3
Expand Down Expand Up @@ -2059,7 +2059,7 @@ __metadata:
languageName: unknown
linkType: soft

"@flyteorg/console@^0.0.30, @flyteorg/console@workspace:packages/console":
"@flyteorg/console@^0.0.31, @flyteorg/console@workspace:packages/console":
version: 0.0.0-use.local
resolution: "@flyteorg/console@workspace:packages/console"
dependencies:
Expand Down

0 comments on commit b7c4b80

Please sign in to comment.