Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for mapped task parent retryAttempt #756

Merged
merged 4 commits into from
May 11, 2023

Conversation

jsonporter
Copy link
Contributor

Read then delete this section

This PR adds support for a mapped task's parentRetry group provided to the attempts UI.

TL;DR

Adds more correct context to the attempt UI when working with mapped tasks as the current component assumes only the retryAttempt of the mapped execution, not its parent execution.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

NA

Tracking Issue

NA

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #756 (350e5f8) into master (29babaa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #756   +/-   ##
=======================================
  Coverage   65.90%   65.90%           
=======================================
  Files         489      489           
  Lines       11914    11914           
  Branches     2195     2195           
=======================================
  Hits         7852     7852           
  Misses       4062     4062           
Impacted Files Coverage Δ
...ns/TaskExecutionsList/MapTaskExecutionListItem.tsx 41.02% <ø> (ø)
...tions/TaskExecutionsList/TaskExecutionLogsCard.tsx 93.54% <ø> (ø)
...ents/common/MapTaskExecutionsList/TaskNameList.tsx 89.28% <ø> (ø)

@jsonporter jsonporter merged commit b7c4b80 into master May 11, 2023
@jsonporter jsonporter deleted the json/mapped-tasks-attemps-2 branch May 11, 2023 23:45
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants