Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add item when mapped task #761

Merged
merged 4 commits into from
May 18, 2023
Merged

chore: add item when mapped task #761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f5252e1
feat: (wip) add item when mapped task
jsonporter May 17, 2023
7063f6f
chore: progress
ursucarina May 17, 2023
38f2d24
Merge branch 'master' into json/mapped-task-item
jsonporter May 18, 2023
74d7868
chore: pass mapped item
ursucarina May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/console/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@flyteorg/console",
"version": "0.0.34",
"version": "0.0.35",
"description": "Flyteconsole main app module",
"main": "./dist/index.js",
"module": "./lib/index.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/console/src/components/Executions/TaskExecutionsList/MapTaskExecutionDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,14 @@ export const MapTaskExecutionDetails: React.FC<
{filteredResources.map(item => {
const attempt = item.retryAttempt ?? 0;
const headerText = formatRetryAttempt(attempt);

return (
<div key={`card-${attempt}`}>
<TaskExecutionLogsCard
taskExecution={taskExecution}
headerText={headerText}
phase={item.phase ?? TaskExecutionPhase.UNDEFINED}
logs={item.logs ?? []}
mappedItem={item}
/>
</div>
);
Expand Down
1 change: 1 addition & 0 deletions packages/console/src/components/Executions/TaskExecutionsList/TaskExecutionLogsCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ interface TaskExecutionLogsCardProps {
headerText: string;
phase: TaskExecutionPhase;
logs: Core.ITaskLog[];
mappedItem?: any;
}

export const TaskExecutionLogsCard: React.FC<
Expand Down
4 changes: 2 additions & 2 deletions packages/console/src/components/Executions/contexts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import {
Execution,
ExecutionData,
LogsByPhase,
MapTaskExecution,
NodeExecution,
TaskExecution,
} from 'models/Execution/types';
import { dNode } from 'models/Graph/types';
import { createContext } from 'react';
Expand All @@ -13,7 +13,7 @@ export interface ExecutionContextData {
execution: Execution;
}

export type WorkflowTaskExecution = TaskExecution & {
export type WorkflowTaskExecution = MapTaskExecution & {
task?: Task;
taskData?: ExecutionData;
};
Expand Down
1 change: 1 addition & 0 deletions packages/console/src/models/Task/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
export * from './constants';
export * from './types';
export * from './api';
export * from './utils';
2 changes: 1 addition & 1 deletion website/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
},
"dependencies": {
"@flyteorg/common": "^0.0.4",
"@flyteorg/console": "^0.0.34",
"@flyteorg/console": "^0.0.35",
"long": "^4.0.0",
"protobufjs": "~6.11.3",
"react-ga4": "^1.4.1",
Expand Down
4 changes: 2 additions & 2 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2020,7 +2020,7 @@ __metadata:
resolution: "@flyteconsole/client-app@workspace:website"
dependencies:
"@flyteorg/common": ^0.0.4
"@flyteorg/console": ^0.0.34
"@flyteorg/console": ^0.0.35
"@types/long": ^3.0.32
long: ^4.0.0
protobufjs: ~6.11.3
Expand Down Expand Up @@ -2059,7 +2059,7 @@ __metadata:
languageName: unknown
linkType: soft

"@flyteorg/console@^0.0.34, @flyteorg/console@workspace:packages/console":
"@flyteorg/console@^0.0.35, @flyteorg/console@workspace:packages/console":
version: 0.0.0-use.local
resolution: "@flyteorg/console@workspace:packages/console"
dependencies:
Expand Down