Code Quality: Replace Vanara with CsWin32

[gumbarros]

Description

Related to https://learn.microsoft.com/en-us/dotnet/fundamentals/syslib-diagnostics/syslib1050-1069.

Concerned code

Example:

[DllImport("api-ms-win-core-timezone-l1-1-0.dll", SetLastError = true)]
public static extern bool FileTimeToSystemTime(
	ref FILETIME lpFileTime,
	out SYSTEMTIME lpSymTime);stemTime);

to

[LibraryImport("api-ms-win-core-timezone-l1-1-0.dll", SetLastError = true)]
public static extern bool FileTimeToSystemTime(
	ref FILETIME lpFileTime,
	out SYSTEMTIME lpSystemTime);

Gains

• Better performance using source generators instead of reflection

Requirements

• Running R# to generate the report of variables and fields that can be converted
• Applying the change file by file

Comments

No response

[gumbarros]

https://learn.microsoft.com/en-us/dotnet/standard/native-interop/pinvoke-source-generation

Another reference explaining the benefits. I think this is an important issue.

[0x5bfa]

I like this idea. Feel free to work on it with @yaira2’s approval.

[yaira2]

Sounds good, it might be worth splitting this into multiple PRs to make it easier to test and review.

[gumbarros]

Just checked about CsWin32, looks promising because of source generator usage like LibraryImportAttribute. Will make a try tonight at NativeFindStorageItemHelper.cs

[gumbarros]

Don't know if this is expected behavior when migrating:
microsoft/CsWin32#1167

[0x5bfa]

Important

• Please Use CsWin32 instead of replacing with LibraryImport. This Win32PInvoke class should be going to contain undocumented native functions defined through LibraryImport or DllImport when possible.
• Don't use "*FromApp" functions. They are intended to be used on UWP. Instead, use native ones.
• E is easy, M is medium, D is difficult. If anyone else can take a look, it'd be good to start from ones marked as E.

Documented native methods (targets to convert to CsWin32)

• M: RmRegisterResources
• M: RmStartSession
• E: RmEndSession
• D: RmGetList
• E: SetPropW
• E: CreateEvent
• E: SetEvent
• E: GetDpiForWindow
• M: CoWaitForMultipleObjects
• E: SetWindowLongPtr32
• E: SetWindowLongPtr64
• E: SHBrowseForFolder
• E: SHGetPathFromIDList
• E: CloseHandle
• M: GetOverlappedResult
• E: CancelIo
• E: CancelIoEx
• M: WaitForMultipleObjectsEx
• E: ResetEvent
• E: WaitForSingleObjectEx
• M: ReadDirectoryChangesW
• E: CreateFileFromAppW
• M: DeviceIoControl
• M: ToUnicode
• M: ToUnicodeEx
• E: GetKeyboardState
• E: GetKeyboardLayout
• E: MapVirtualKey
• M: TranslateMessage
• E: CreateFileFromApp
• E: GetFileAttributesExFromApp
• E: SetFileAttributesFromApp
• E: SetFilePointer
• M: ReadFile
• M: WriteFile
• M: WriteFileEx
• M: GetFileTime
• M: SetFileTime
• E: GetFileInformationByHandleEx
• E: GetFileInformationByHandleEx
• E: FindFirstStreamW
• E: FindNextStreamW
• E: GetDpiForMonitor
• E: OpenProcessToken
• E: GetCurrentProcess
• E: GetTokenInformation
• E: GetLengthSid
• M: CryptUnprotectData
• E: IsWow64Process2
• E: FindNextFile
• E: FindClose
• M: FileTimeToSystemTime
• E: FindFirstFileExFromApp
• E: CompareStringEx
• E: SHCreateStreamOnFileEx
• M: SHCreateItemFromParsingName
• M: CoCreateInstance
• E: RegisterApplicationRestart
• M: SHGetKnownFolderPath

Undocumented native functions

• IsElevationRequired
• SHUpdateRecycleBinIcon