Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality: Removed Vanara from SeerProProvider class #15912

Merged
merged 1 commit into from
Aug 4, 2024
Merged

Code Quality: Removed Vanara from SeerProProvider class #15912

merged 1 commit into from
Aug 4, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Jul 31, 2024 •
edited
Loading

Resolved / Related Issues

Steps used to test these changes

  1. Install SeerPro
  2. Launch it from Start and check if it's now in system tray
  3. Launch Files
  4. Select an image file
  5. Enter Space
  6. See SeerPro preview launches and the image is shown

Messaging is doing well:
image

@yaira2
Copy link
Member

yaira2 commented Jul 31, 2024

@0x5bfa are the preview working properly for you?

image

@0x5bfa
Copy link
Member Author

0x5bfa commented Aug 3, 2024

Now ready for review.

yaira2
yaira2 approved these changes Aug 4, 2024
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Aug 4, 2024
@yaira2 yaira2 merged commit ed18589 into files-community:main Aug 4, 2024
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/CQ-VanaraRemovalMisc branch August 4, 2024 04:59
@0x5bfa 0x5bfa mentioned this pull request Aug 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x5bfa @yaira2