Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Use LibraryImportAttribute at undocumented EntryPoint #15298

Merged
merged 1 commit into from
May 6, 2024

Conversation

gumbarros
Copy link
Contributor

@gumbarros gumbarros commented May 4, 2024

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Part of Code Quality: Replace Vanara with CsWin32 #15000

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Additional Context
#865 is undocumented, so it's impossible to use CsWin32.

@yaira2 yaira2 added the needs - testing Pull request requires testing before being merged label May 5, 2024
@yaira2 yaira2 added changes requested Changes are needed for this pull request ready to merge Pull requests that are approved and ready to merge and removed needs - code review needs - testing Pull request requires testing before being merged changes requested Changes are needed for this pull request labels May 5, 2024
@yaira2 yaira2 changed the title Code Quality: Use LibraryImportAttribute at undocumented EntryPoint #865 Code Quality: Use LibraryImportAttribute at undocumented EntryPoint May 6, 2024
@yaira2 yaira2 merged commit 164096e into files-community:main May 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants