Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality: Introduced ComHeapPtr #16237

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Code Quality: Introduced ComHeapPtr #16237

merged 4 commits into from
Sep 30, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Sep 21, 2024 •
edited
Loading

@0x5bfa
Copy link
Member Author

0x5bfa commented Sep 21, 2024 •
edited
Loading

As far as we enable friendlyOverloads and useSafeHandles we don't have to worry about handles and we should use SafeHandle derivatives.

@hez2010 fyi.

@yaira2 yaira2 requested a review from hez2010 September 22, 2024 00:57
hez2010
hez2010 approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@hez2010 hez2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

src/Files.App.CsWin32/Windows.Win32.ComHeapPtr.cs Show resolved Hide resolved
@yaira2 yaira2 merged commit 0debeee into files-community:main Sep 30, 2024
6 checks passed
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Sep 30, 2024
@0x5bfa 0x5bfa deleted the 5bfa/CQ-ComHeapPtr branch September 30, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hez2010 hez2010 hez2010 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0x5bfa @hez2010 @yaira2