Code Quality: Introduced IWindowsRecentItemsService

[0x5bfa]

Resolved / Related Issues

Note

There's been a known issue with enumerating recent items, where the service enumerates pinned files as well as recent items. Because of this, if there's any, Clear All doesn't work properly. While this PR didn't introduce this issue we probably want to look into later.

• Related Code Quality: Replace Vanara with CsWin32 #15000
• Related Code Quality: Reduce duplicated functionality classes #14572

Steps used to test these changes

1. Enumerate recent items
2. Delete one recent item
3. Clear all recent items

[yaira2]

Can we use the context menu verb for that?

[yaira2]

It looks like folders are showing in the recent files widget

[yaira2]

Pinned files should be included

[yaira2]

There is one issue I discovered where the order of the recent items doesn't match the behavior in main.

[0x5bfa]

Sorry to have forgot to mention this, I meant to.

[yaira2]

The behavior in main matches File Explorer. We shouldn't be doing our own sorting here.

[jiejasonliu]

There was a comment that mentioned the order is already sorted so don't sort here, but tbh I don't understand why @jiejasonliu wrote so.

I only slightly remember this but I figured it would be reasonable to include why we didn't sort since we did so for the folder flow. The initial implementation read directly from Quick Access so there was no need to sort again.
It looks like we still read from Quick Access (looking at the GUID) so we can still rely on enumeration order probably.

[0x5bfa]

It looks like we still read from Quick Access (looking at the GUID) so we can still rely on enumeration order probably.

Do you know IApplicationDocumentLists? This is specifically enumeration interface for frequent and recent items. Also IApplicationDestinations is provided for deleting an item and clearing all. I have to try.

[jiejasonliu]

It looks like we still read from Quick Access (looking at the GUID) so we can still rely on enumeration order probably.

Do you know IApplicationDocumentLists? This is specifically enumeration interface for frequent and recent items. Also IApplicationDestinations is provided for deleting an item and clearing all. I have to try.

I don't, but the API seems promising. From an glance, it looks like a bunch of SHAddToRecentDocs coupled with some other (undocumented?) internals -- the ability to unpin a specific destination is interesting. I'll say that when this was first implemented, I settled on whatever worked first.

[0x5bfa]

@jiejasonliu Thank you for the review.
While whether we're going to get rid of recent folders support depends on @yaira2, I took care of all.

Speaking of IApplicationDocumentLists, I confirmed this was a completely different stuff; File Explorer only adds recent 'folders'. Presumably, we still gotta to use a dedicated shell folder, as we have.

[0x5bfa]

This is ready for review again, tested everything on my end.

One thing I leave as the future work is to use IStorable for recent items, determining if it's IFolder or IFile and invoke one appropriate verb or two. This is also the case for any other UI item classes that represent a storage object.

[yaira2]

Can you rebase with the latest from main?

[yaira2]

It looks like everything is working properly. @jiejasonliu do you have anything else to go over before I merge the PR?

[jiejasonliu]

lgtm! thanks for taking the time to not only refactor but to explore alternative ways to achieve similar behaviors.