-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3071 Org chart styles #3130
3071 Org chart styles #3130
Conversation
@rfultz In your instructions, we also need to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, including the rollover state. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JonellaCulmer asked me to look at it from content team perspective. It seems OK but be aware that depending on what we find in our focus groups #3103 , we may end up coming back to the organization chart design. Also, picky picky, will need to take the "Acting" out of Neven's title when we get to the real chart. Finally, are the footnotes incorporated into this?
Oops. Sorry. I've updated it. |
I assumed we'd retain the current process we use for footnotes. There would just need to be another text block after the org chart, which is something @johnnyporkchops will be able to contend with on the org chart template. When we create a template for footnotes, I'd like them to be the same across the whole site. |
@rfultz . To answer your question, I think it makes sense to |
Also fixed a typo and lint warning
Codecov Report
@@ Coverage Diff @@
## develop #3130 +/- ##
==========================================
Coverage ? 74.76%
==========================================
Files ? 119
Lines ? 7158
Branches ? 633
==========================================
Hits ? 5352
Misses ? 1806
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks /works great. Nice clean html structure and concise SCSS!
All reviewers have approved, merging... |
Summary
Outlines the structure for a responsive org chart and styles it according to comps
Impacted areas of the application
Right now, the only change is a new scss file that will apply to an upcoming org chart.
That file is included in fec/fec/static/scss/base.scss for now (see the TODOs at the bottom).
Screenshots
Related PRs
None
How to test
npm run build
just in case (if you get an error, you may need to runnpm rebuild node-sass
then build again)TODO: