Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create org chart in HTML Block in Wagtail #3185

Closed
6 tasks done
Tracked by #138
johnnyporkchops opened this issue Sep 19, 2019 · 3 comments
Closed
6 tasks done
Tracked by #138

Create org chart in HTML Block in Wagtail #3185

johnnyporkchops opened this issue Sep 19, 2019 · 3 comments
Assignees
Milestone

Comments

@johnnyporkchops
Copy link
Contributor

johnnyporkchops commented Sep 19, 2019

Summary

What we're after:
Until there is a Wagtail template to create/edit the org chart in Wagtail, we can use the html in this issue 3130 to publish this in the mean time.

Related issues

#3130
#3072

Completion criteria

List action items that need to be done to complete this task. List in checklist formatting.

Future work

#3072

@dorothyyeager
Copy link
Contributor

dorothyyeager commented Oct 9, 2019

Questions for @johnnyporkchops @rfultz @patphongs - Edited to add the answers from the amazing @patphongs

  1. I found the template but it's not available to us in the "About the FEC section" (which is where we'd want it. Do we need a ticket for that work? Answer: No. It's available in the leadership and structure part of About the FEC, so I'll create the page there.

  2. The template doesn't seem to be available at all in prod, just feature. Do we need to have that happen first before I can work on this ticket? Answer: Yes. Will be part of 10.2 and available when that's deployed to prod.

  3. The footnotes in the org chart aren't in the HTML. When I tested out coding them in feature, I cannot get a space to appear between the chart and the footnotes. I tried putting them into separate HTML block and the same block. No luck. Answer: Will need to add a bit more code regarding the padding. We're going to put in a ticket for this work and other items like the buttons.

  4. The link for the IG office in the HTML code provided was out of date. I updated it in my text file; should I do the same in the hard-coded file Pat linked me to? Answer: No need, that was just a prototype file to give us the chart structure

@dorothyyeager
Copy link
Contributor

This is ready for review by a second pair of eyes; maybe @AmyKort if available? Also wondering if about the slug I've made. I have it as fec-offices so that whatever is developed to replace it in #3072 can use the slug of fec-organizational-chart. Does that work?

@dorothyyeager
Copy link
Contributor

I've published the new chart at https://www.fec.gov/about/leadership-and-structure/fec-offices/ and updated the link on the "Leadership and structure" page. I've also added the new page to our redirect spreadsheet and we'll tackle it in the redirects at #3209 . We're ready to close this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants