Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org Chart, reporting examples and internal/external buttons need a little bit of spacing #3259

Closed
1 task
Tracked by #140
dorothyyeager opened this issue Oct 9, 2019 · 2 comments · Fixed by #3382
Closed
1 task
Tracked by #140
Assignees
Milestone

Comments

@dorothyyeager
Copy link
Contributor

Summary

What we're after:
We'd like to include a bit of padding into elements like the Org Chart, reporting examples, the internal button and the external button, since those elements are often followed by other things like texts or images. Right now we can do workarounds using in-line styles in the html, or adding carriage returns in a paragraph block, but it would be good to build this padding into the elements.

Related issues

Screenshots

Internal button (external button and reporting examples do the same thing)
image

As rendered:
image

Our current workaround: Hit carriage return in the first line of the text block to add the space.

Current html for org chart (in html block, followed by second html block with footnotes):
image

Current workaround: Inserting this styling into the HTML for the chart: ul id="fec-orgchart" style="padding-bottom: 2rem;">

Completion criteria

  • Verify that there will be space between a button, an example or a chart and any text blocks inserted below it.

Future work

After the new styling is deployed to prod, we may need to take out a bunch of extra carriage returns, etc.

@dorothyyeager dorothyyeager added this to the Sprint 10.4 milestone Oct 9, 2019
@PaulClark2 PaulClark2 modified the milestones: Sprint 10.4, Sprint 10.5 Oct 22, 2019
@JonellaCulmer JonellaCulmer modified the milestones: Sprint 10.5, Sprint 10.6 Nov 1, 2019
@JonellaCulmer JonellaCulmer changed the title Org Chart, reporting examples and internal/external buttons need a little bit of padding Org Chart, reporting examples and internal/external buttons need a little bit of spacing Nov 19, 2019
@johnnyporkchops
Copy link
Contributor

@dorothyyeager, Can you include a link to Reporting examples (or other )pages where this issue exists. I had trouble navigating (or searching )my way back to reporting example pages

@dorothyyeager
Copy link
Contributor Author

@johnnyporkchops You may have fixed it in the reporting examples when you worked on the example template issue. When I tested that example, the issue seemed to be fixed on that template. Reporting example pages are usually in the filing reports part of each H4CC bucket. for example: https://www.fec.gov/help-candidates-and-committees/other-filers/#reporting-examples

For other types of pages, here's an example: https://www.fec.gov/help-candidates-and-committees/candidate-taking-receipts/partnership-llc-contributions/
This page was screenshot above and has a lot of buttons. It uses the resource template. We did a lot of workarounds (like <br> or hitting carriage returns) to make the buttons not hit the text below them.

The org chart is another example, where Pat gave me some html to use as a workaround. That page is at https://www.fec.gov/about/leadership-and-structure/fec-offices/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants