Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terms.json with glossary changes 11-24 #1519

Closed
wants to merge 1 commit into from

Conversation

dorothyyeager
Copy link
Contributor

Updating this file with the changes to the glossary made in this sprint 4.4. This should be part of the next release. Thanks @xtine for pointing me to correct file.

Original code at https://docs.google.com/spreadsheets/d/14CtWh60-AuIEKHqKwlkdRURFZtrLnKFcI1vejXEY0ho/edit#gid=1963072597

Summary (required)

Impacted areas of the application

The H4CC pages primarily


IF ANY OF THE ABOVE FIELDS DO NOT APPLY, PLEASE DELETE THEM BEFORE SUBMITTING

Updating this file with the changes to the glossary made in this sprint 4.4. This should be part of the next release. Thanks @xtine for pointing me to correct file.

Original code at https://docs.google.com/spreadsheets/d/14CtWh60-AuIEKHqKwlkdRURFZtrLnKFcI1vejXEY0ho/edit#gid=1963072597
@xtine
Copy link
Contributor

xtine commented Nov 28, 2017

The formatting for this doesn't seem right, as it should remain as

{
  "term": "New Term",
  "definition": "New definition here"
}

Like your original PR changes: https://github.com/18F/fec-style/pull/768/files.

Can you correct this?

dorothyyeager referenced this pull request Nov 28, 2017
Making the correction requested by @xtine in https://github.com/18F/fec-cms/pull/1519. This is part of issue #1394.
@dorothyyeager
Copy link
Contributor Author

Closed in favor of #1525 (This PR targeted a forked repo. A new one properly targets the correct branch.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants