Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting terms.json #1520

Closed
wants to merge 1 commit into from
Closed

Correcting terms.json #1520

wants to merge 1 commit into from

Conversation

dorothyyeager
Copy link
Contributor

This is part of issue #1394.

Summary (required)

  • Addresses # [1394]
    Taking out some fields that shouldn't be in there.

Related PRs

Making the correction requested by @xtine in https://github.com/18F/fec-cms/pull/1519.

branch PR
fix/other_pr [https://github.com/18F/fec-cms/pull/1519]

Making the correction requested by @xtine in https://github.com/18F/fec-cms/pull/1519. This is part of issue #1394.
@codecov-io
Copy link

Codecov Report

Merging #1520 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #1520   +/-   ##
=======================================
  Coverage     79.4%   79.4%           
=======================================
  Files           46      46           
  Lines         3297    3297           
  Branches       497     497           
=======================================
  Hits          2618    2618           
  Misses         679     679

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e9a4e1...e7dd709. Read the comment docs.

@xtine
Copy link
Contributor

xtine commented Nov 28, 2017

This PR just removes the "Act" term. Were you intending to make other changes besides that term removal? Also, instead of making a new PR for every change, do you know how to make additional commits to your branch?

@dorothyyeager
Copy link
Contributor Author

Hmmm, actually I didn't want to remove the Act term. I thought I was just taking out a few blank lines at the top? And no, I've got no idea how the branch thing works--help!?

@dorothyyeager
Copy link
Contributor Author

Closing due to typo and will begin again with a new request. PR opened in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants