Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEC Glossary updates for the next release (Glossary round 3, beginning after 10-26-17) #1394

Closed
3 tasks done
Tracked by #126
dorothyyeager opened this issue Oct 26, 2017 · 8 comments
Closed
3 tasks done
Tracked by #126
Assignees
Milestone

Comments

@dorothyyeager
Copy link
Contributor

dorothyyeager commented Oct 26, 2017

The glossary updates, corrections and additions are something that is part of a release, so the purpose of this issue is to organize for upcoming glossary work for the next round. Background information on the process for updating the glossary is at https://github.com/18F/FEC/issues/4498#issuecomment-329518919.

Past issues to be closed and addressed/consolidated in this issue:
18F/fec-style#436
https://github.com/18F/FEC/issues/4498
https://github.com/18F/FEC/issues/3976 (the Commission approved a revised definition of the word suggested by a feedback-giver today so we'll work that in.)

My google doc of things to revise for this round:
https://docs.google.com/document/d/1G7fwx3wmcmTB2cOHzKXtVvmVgtqvL0hJeSUf-i2hWGM/edit?usp=sharing

To do list:

  • Update the html code on the website for the various terms added in round 2 (the 10/26/2017 release). (See Update glossary with additional terms #1199 )
  • Find official language or get OGC review/approval for the terms to be added
  • Add the new "round 3" terms and other tweaks to the glossary JSON code.
@dorothyyeager dorothyyeager changed the title FEC Glossary updates for the next release (Glossary round 3, beginning after 10-19-17) FEC Glossary updates for the next release (Glossary round 3, beginning after 10-29-17) Oct 26, 2017
@dorothyyeager dorothyyeager changed the title FEC Glossary updates for the next release (Glossary round 3, beginning after 10-29-17) FEC Glossary updates for the next release (Glossary round 3, beginning after 10-26-17) Oct 26, 2017
@dorothyyeager
Copy link
Contributor Author

This issue needs the bug in https://github.com/18F/fec-cms/issues/1415 to be resolved in order to do the first task.

@dorothyyeager
Copy link
Contributor Author

Have pulled together the definitions for the next round of terms. Some will need OGC review. This document contains them. https://docs.google.com/document/d/1_-dD5xgUw8X9M_ajpW9vcizfa04-2-8H_IQuRLEHq4o/edit?usp=sharing

@AmyKort AmyKort modified the milestones: Sprint 4.3, Sprint 4.4 Nov 7, 2017
@dorothyyeager
Copy link
Contributor Author

OGC has approved the terms that needed review with some minor edits we'll incorporate.

@dorothyyeager
Copy link
Contributor Author

dorothyyeager commented Nov 24, 2017

New terms and corrections have been updated in the JSON code; pull request filed and review requested before the next release.

Documents showing changes for next release:
https://docs.google.com/spreadsheets/d/14CtWh60-AuIEKHqKwlkdRURFZtrLnKFcI1vejXEY0ho/edit?usp=sharing (Spreadsheet with all glossary terms/definitions - new highlighted with yellow background)
https://docs.google.com/document/d/1_-dD5xgUw8X9M_ajpW9vcizfa04-2-8H_IQuRLEHq4o/edit?usp=sharing (Word doc showing new terms and revisions)

@dorothyyeager
Copy link
Contributor Author

All of the terms from round 2 (included in the 10/26 release) have been coded on the html pages. We are able to close this topic as the new terms will be part of the next release. Will pick up with a new issue to code the new terms from this round after they are part of a release.

@dorothyyeager
Copy link
Contributor Author

Had to update the pull request so have re-opened the issue.

@AmyKort
Copy link

AmyKort commented Nov 27, 2017

@xtine Can you review this? Thanks!

dorothyyeager added a commit that referenced this issue Nov 28, 2017
Making the correction requested by @xtine in https://github.com/18F/fec-cms/pull/1519. This is part of issue #1394.
@dorothyyeager
Copy link
Contributor Author

@lbeaufort is my new hero and this issue can be closed, as the revisions will be in the next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants