Re-creating additional glossary terms PR #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making the correction requested by @xtine in https://github.com/18F/fec-cms/pull/1519. This is part of issue #1394.
Adding back "Act" and "term/definition" for each term
lbeaufort
approved these changes
Nov 28, 2017
There was a problem hiding this comment.
Looks great! @dorothyyeager and I paired on testing on my local. Confirmed new terms appear.
|
@xtine I merged this PR after pairing with @dorothyyeager to test on my local and it looks good. She also updated her notes for making changes to an existing PR using commits. |
|
Thanks so much @lbeaufort! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (required)
Adds new terms and updates Hybrid PAC
Impacted areas of the application
Edit glossary