Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(ci): use cncf provided runners for arm64 #2064

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Sep 13, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Depends upon #2073 and #2049 that were partially split from this one.
Will eventually rebase once they get merged.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@poiana
Copy link
Contributor

poiana commented Sep 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

github-actions bot commented Sep 13, 2024

Perf diff from master - unit tests

     6.81%     -1.44%  [.] sinsp_evt::get_type
     0.45%     +0.67%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::find
     0.17%     +0.52%  [.] sinsp_container_info::sinsp_container_info
     1.79%     +0.47%  [.] scap_event_decode_params
     1.17%     -0.46%  [.] sinsp_evt::get_param
     2.35%     -0.46%  [.] sinsp::fetch_next_event
     6.98%     +0.41%  [.] sinsp::next
     2.10%     -0.40%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     1.73%     +0.38%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     0.50%     +0.37%  [.] sinsp_split[abi:cxx11]

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0096         -0.0096           153           152           153           152
BM_sinsp_split_median                                          -0.0049         -0.0049           153           152           153           152
BM_sinsp_split_stddev                                          -0.1819         -0.1816             2             1             2             1
BM_sinsp_split_cv                                              -0.1740         -0.1736             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0875         -0.0875            62            56            62            56
BM_sinsp_concatenate_paths_relative_path_median                -0.0823         -0.0823            61            56            61            56
BM_sinsp_concatenate_paths_relative_path_stddev                -0.7640         -0.7637             1             0             1             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.7413         -0.7410             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0472         -0.0472            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0429         -0.0429            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.7733         -0.7733             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.7620         -0.7621             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.1198         -0.1198            64            56            64            56
BM_sinsp_concatenate_paths_absolute_path_median                -0.1203         -0.1203            64            56            64            56
BM_sinsp_concatenate_paths_absolute_path_stddev                +0.3124         +0.3130             1             1             1             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +0.4910         +0.4918             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0007         -0.0007           392           392           392           392
BM_sinsp_split_container_image_median                          +0.0006         +0.0006           393           393           393           393
BM_sinsp_split_container_image_stddev                          -0.2810         -0.2806             3             2             3             2
BM_sinsp_split_container_image_cv                              -0.2805         -0.2801             0             0             0             0

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.46%. Comparing base (3216d09) to head (73e6f0c).
Report is 18 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2064   +/-   ##
=======================================
  Coverage   74.45%   74.46%           
=======================================
  Files         253      253           
  Lines       33052    33052           
  Branches     5655     5670   +15     
=======================================
+ Hits        24610    24611    +1     
- Misses       8411     8415    +4     
+ Partials       31       26    -5     
Flag Coverage Δ
libsinsp 74.46% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 13, 2024

X64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-4.19 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2-5.10 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2023-6.1 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.0 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.7 🟢 🟢 🟢 🟢 🟢 🟢
centos-3.10 🟢 🟢 🟢 🟡 🟡 🟡
centos-4.18 🟢 🟢 🟢 🟢 🟢 🟢
centos-5.14 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.17 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.8 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-3.10 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-4.14 🟢 🟢 🟢 🟢 🟢 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-5.4 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-4.15 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-5.8 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

ARM64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-4.14 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

@FedeDP FedeDP force-pushed the update/use_cncf_nodes branch 2 times, most recently from a006e4f to 6f93e92 Compare September 13, 2024 09:45
@poiana poiana added size/L and removed size/M labels Sep 13, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented Sep 13, 2024

Drivers CI is green: https://github.com/falcosecurity/libs/actions/runs/10848223544/job/30104926169?pr=2064

Going to remove the wip commit that triggered it.

@FedeDP
Copy link
Contributor Author

FedeDP commented Sep 13, 2024

Since this may take a bit longer to wrap up, i extracted #2066 to fix drivers CI in the meantime.

@FedeDP
Copy link
Contributor Author

FedeDP commented Sep 13, 2024

/milestone 0.19.0

@poiana poiana added this to the 0.19.0 milestone Sep 13, 2024
@FedeDP FedeDP force-pushed the update/use_cncf_nodes branch 2 times, most recently from f80a19e to 64974e9 Compare September 17, 2024 07:09
@FedeDP
Copy link
Contributor Author

FedeDP commented Sep 23, 2024

Rebased on top of latest master.

@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 7, 2024

Rebased on top of latest master.

@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 17, 2024

Will rebase this one once #2120 is merged, taking care of porting latest-kernel ci job to use cncf provided arm64 runner.

@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 21, 2024

Rebased.

@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 21, 2024

/hold while i make more tests.

@FedeDP FedeDP changed the title wip: update(ci): use cncf provided runners for arm64 update(ci): use cncf provided runners for arm64 Oct 21, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 29, 2024

/unhold

@poiana poiana merged commit b296470 into master Oct 29, 2024
47 of 49 checks passed
@poiana poiana deleted the update/use_cncf_nodes branch October 29, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants