Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fixed latest-kernel CI usage of steps/jobs outputs. #2120

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Oct 17, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Fixed small issues introduced in #2114: properly use .outputs for steps/jobs outputs in latest-kernel CI.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 17, 2024

/milestone 0.19.0

@poiana poiana added this to the 0.19.0 milestone Oct 17, 2024
@poiana poiana added the size/S label Oct 17, 2024
Copy link

Perf diff from master - unit tests

     8.40%     -0.85%  [.] sinsp::next
     5.62%     -0.61%  [.] sinsp_parser::process_event
     3.86%     -0.57%  [.] gzfile_read
     8.85%     +0.56%  [.] sinsp_parser::reset
     1.02%     +0.55%  [.] sinsp_threadinfo::~sinsp_threadinfo
     3.07%     +0.54%  [.] sinsp_thread_manager::get_thread_ref
     0.17%     +0.50%  [.] sinsp_threadinfo::sinsp_threadinfo
     1.13%     +0.47%  [.] 0x00000000000e93b0
     4.71%     +0.44%  [.] next
     0.62%     +0.40%  [.] sinsp_evt::get_param

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0158         -0.0158           155           152           155           152
BM_sinsp_split_median                                          -0.0093         -0.0093           154           153           154           153
BM_sinsp_split_stddev                                          -0.7482         -0.7484             3             1             3             1
BM_sinsp_split_cv                                              -0.7441         -0.7444             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0748         -0.0748            60            56            60            56
BM_sinsp_concatenate_paths_relative_path_median                -0.0767         -0.0767            60            56            60            56
BM_sinsp_concatenate_paths_relative_path_stddev                -0.5939         -0.5929             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.5611         -0.5600             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0338         -0.0338            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0314         -0.0314            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.7683         -0.7685             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.7602         -0.7604             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.1170         -0.1170            62            55            62            55
BM_sinsp_concatenate_paths_absolute_path_median                -0.1264         -0.1265            63            55            63            55
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.8229         -0.8227             1             0             1             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.7994         -0.7992             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0128         +0.0128           391           396           391           396
BM_sinsp_split_container_image_median                          +0.0120         +0.0120           392           396           392           396
BM_sinsp_split_container_image_stddev                          -0.3031         -0.3026             3             2             3             2
BM_sinsp_split_container_image_cv                              -0.3119         -0.3114             0             0             0             0

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.69%. Comparing base (d8d345a) to head (dbedb17).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2120   +/-   ##
=======================================
  Coverage   73.69%   73.69%           
=======================================
  Files         253      253           
  Lines       31915    31915           
  Branches     5638     5633    -5     
=======================================
  Hits        23521    23521           
  Misses       8394     8394           
Flag Coverage Δ
libsinsp 73.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Oct 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit fedfec3 into master Oct 21, 2024
53 checks passed
@poiana poiana deleted the fix/latest_kernel_ci branch October 21, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants