chore(test/libsinsp_e2e,ci): port libsinsp_e2e tests to use python3. #2073

FedeDP · 2024-09-17T07:15:37Z

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area CI
/area tests

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Extracted from #2064

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Federico Di Pierro <[email protected]>

FedeDP · 2024-09-17T07:15:47Z

/milestone 0.19.0

codecov · 2024-09-17T07:26:38Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.58%. Comparing base (5919fa9) to head (31e5d47).
Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2073   +/-   ##
=======================================
  Coverage   73.58%   73.58%           
=======================================
  Files         253      253           
  Lines       31867    31867           
  Branches     5630     5650   +20     
=======================================
  Hits        23449    23449           
- Misses       8401     8412   +11     
+ Partials       17        6   -11

Flag	Coverage Δ
libsinsp	`73.58% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-09-17T07:27:00Z

Perf diff from master - unit tests

     5.29%     -1.05%  [.] next
     5.56%     +1.01%  [.] sinsp_evt::get_type
     2.70%     +0.79%  [.] sinsp_thread_manager::find_thread
     7.94%     -0.70%  [.] sinsp::next
     1.29%     -0.64%  [.] std::vector<sinsp_evt_param, std::allocator<sinsp_evt_param> >::emplace_back<sinsp_evt*, unsigned int&, char const*, unsigned long&>
     2.00%     -0.62%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     0.59%     +0.59%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::find
     0.66%     +0.59%  [.] sinsp_filter_check::parse_field_name
     1.98%     -0.55%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     0.92%     -0.55%  [.] sinsp_evt::get_direction

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0236         +0.0236           147           150           147           150
BM_sinsp_split_median                                          +0.0302         +0.0302           146           151           146           151
BM_sinsp_split_stddev                                          -0.3043         -0.3045             2             1             2             1
BM_sinsp_split_cv                                              -0.3203         -0.3205             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.1083         +0.1083            42            47            42            47
BM_sinsp_concatenate_paths_relative_path_median                +0.1079         +0.1078            42            47            42            47
BM_sinsp_concatenate_paths_relative_path_stddev                -0.0931         -0.0931             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.1818         -0.1817             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0194         -0.0194            17            17            17            17
BM_sinsp_concatenate_paths_empty_path_median                   -0.0192         -0.0192            17            17            17            17
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.0820         -0.0815             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.0638         -0.0634             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0358         +0.0358            46            48            46            48
BM_sinsp_concatenate_paths_absolute_path_median                +0.0379         +0.0379            46            48            46            48
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.2602         -0.2602             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.2857         -0.2857             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0424         -0.0424           366           351           366           351
BM_sinsp_split_container_image_median                          -0.0420         -0.0420           366           350           366           350
BM_sinsp_split_container_image_stddev                          +0.2483         +0.2485             2             3             2             3
BM_sinsp_split_container_image_cv                              +0.3035         +0.3038             0             0             0             0

Molter73

/lgtm

Molter73 · 2024-09-17T08:30:23Z

test/libsinsp_e2e/resources/unix_client_server.py

  if os.path.exists(NAME):
    client = socket.socket( socket.AF_UNIX, socket.SOCK_STREAM )
    client.connect(NAME)

-    print "STARTED"
+    print(STARTED)


[nitpick] A variable for two print messages is a bit overkill, don't you think?

Suggested change

print(STARTED)

print("STARTED")

I don't think this is worth the amend :) actually i like it better like this; de gustibus eheh

Andreagit97

/approve

poiana · 2024-09-18T12:16:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, Molter73

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Andreagit97,FedeDP,Molter73]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

chore(test/libsinsp_e2e,ci): port libsinsp_e2e tests to use python3.

31e5d47

Signed-off-by: Federico Di Pierro <[email protected]>

poiana added release-note-none dco-signoff: yes kind/cleanup area/CI area/tests labels Sep 17, 2024

poiana requested review from hbrueckner and LucaGuerra September 17, 2024 07:15

poiana added the approved label Sep 17, 2024

poiana added this to the 0.19.0 milestone Sep 17, 2024

poiana added the size/S label Sep 17, 2024

FedeDP mentioned this pull request Sep 17, 2024

update(ci): use cncf provided runners for arm64 #2064

Merged

Molter73 approved these changes Sep 17, 2024

View reviewed changes

poiana assigned Molter73 Sep 17, 2024

poiana added the lgtm label Sep 17, 2024

Andreagit97 approved these changes Sep 18, 2024

View reviewed changes

poiana assigned Andreagit97 Sep 18, 2024

poiana merged commit 933e065 into master Sep 18, 2024
47 checks passed

poiana deleted the chore/e2e_test_python3 branch September 18, 2024 12:16

FedeDP mentioned this pull request Oct 7, 2024

feat(tests): new e2e tests [8/8] #1958

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(test/libsinsp_e2e,ci): port libsinsp_e2e tests to use python3. #2073

chore(test/libsinsp_e2e,ci): port libsinsp_e2e tests to use python3. #2073

FedeDP commented Sep 17, 2024

FedeDP commented Sep 17, 2024

codecov bot commented Sep 17, 2024 •

edited

Loading

github-actions bot commented Sep 17, 2024

Molter73 left a comment

Molter73 Sep 17, 2024

FedeDP Sep 18, 2024

Andreagit97 left a comment

poiana commented Sep 18, 2024

chore(test/libsinsp_e2e,ci): port libsinsp_e2e tests to use python3. #2073

chore(test/libsinsp_e2e,ci): port libsinsp_e2e tests to use python3. #2073

Conversation

FedeDP commented Sep 17, 2024

FedeDP commented Sep 17, 2024

codecov bot commented Sep 17, 2024 • edited Loading

Codecov Report

github-actions bot commented Sep 17, 2024

Perf diff from master - unit tests

Heap diff from master - unit tests

Heap diff from master - scap file

Benchmarks diff from master

Molter73 left a comment

Choose a reason for hiding this comment

Molter73 Sep 17, 2024

Choose a reason for hiding this comment

FedeDP Sep 18, 2024

Choose a reason for hiding this comment

Andreagit97 left a comment

Choose a reason for hiding this comment

poiana commented Sep 18, 2024

codecov bot commented Sep 17, 2024 •

edited

Loading