fix(cmake): added zig workarounds for libelf and grpc cmake modules. #2049
Conversation
|
In a follow-up PR i will also add a zig CI for libs leveraging the Falco composite action to install zig: https://github.com/falcosecurity/falco/pull/3307/files#diff-4272283b257713d488f43b293b0303ea8d82c0aaa72265de68b5eebccde26b29 |
Perf diff from master - unit testsHeap diff from master - unit testsHeap diff from master - scap fileBenchmarks diff from master |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2049 +/- ##
=======================================
Coverage 73.57% 73.58%
=======================================
Files 253 253
Lines 31860 31867 +7
Branches 5640 5655 +15
=======================================
+ Hits 23442 23450 +8
- Misses 8407 8417 +10
+ Partials 11 0 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/hold |
FedeDP
force-pushed
the
cmake/zig_workarounds
branch
from
1f11dba
to
dd16507
Compare
|
/reopen |
|
@FedeDP: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
FedeDP
force-pushed
the
cmake/zig_workarounds
branch
from
7baf943
to
e63d212
Compare
Signed-off-by: Federico Di Pierro <[email protected]>
FedeDP
force-pushed
the
cmake/zig_workarounds
branch
from
e63d212
to
4bc456d
Compare
Signed-off-by: Federico Di Pierro <[email protected]>
| message(STATUS "Found LIBELF: include: ${LIBELF_INCLUDE}, lib: ${LIBELF_LIB}") | ||
| else() | ||
| message(FATAL_ERROR "Couldn't find system libelf") | ||
| endif() | ||
| # We add a custom target, in this way we can always depend on `libelf` without distinguishing | ||
| # between "bundled" and "not-bundled" case | ||
| add_custom_target(libelf) |
There was a problem hiding this comment.
No need for this since it is already present at the end of the file.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Moreover, patch grpc cmake module to patch its abseil-cpp submodule to be compatible with gcc-13.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Last patch for falcosecurity/falco#3307.
Actually, extracted from it.
Does this PR introduce a user-facing change?:
/milestone 0.19.0