EventPerformanceLogger + BoundedConsumableBuffer - switch members to size_t #44564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
marlenecota
changed the title
|
@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @marlenecota in b53aa08. When will my fix make it into a release? | How to file a pick request? |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 6, 2024
Summary: Previous PR (#44564) missed one int -> size_t switch to fix C4018 in react-native-windows.  ## Changelog: [INTERNAL] - Fix signed/unsigned mismatch in BoundedConsumableBuffer.h Pull Request resolved: #44806 Test Plan: Builds on Windows + identical to forked file used in react-native-windows. Reviewed By: cortinico Differential Revision: D58234088 Pulled By: javache fbshipit-source-id: 0453f3509c97854975b90e7a3b8c458ca977ec65
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
…size_t (facebook#44564) Summary: The RNW integration to RN 04/13 (microsoft/react-native-windows#13226) adds EventPerformanceLogger.cpp and PerformanceEntryReporter.cpp. We're getting the following errors:   Switching to size_t fixes it. ## Changelog: [Internal] [FIXED] - EventPerformanceLogger + BoundedConsumableBuffer - switch members to size_t Pull Request resolved: facebook#44564 Test Plan: Builds on Windows Reviewed By: fabriziocucci Differential Revision: D57327696 Pulled By: javache fbshipit-source-id: 21ec3a9597958aa70fbca64710bd615a1022292d
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
…4806) Summary: Previous PR (facebook#44564) missed one int -> size_t switch to fix C4018 in react-native-windows.  ## Changelog: [INTERNAL] - Fix signed/unsigned mismatch in BoundedConsumableBuffer.h Pull Request resolved: facebook#44806 Test Plan: Builds on Windows + identical to forked file used in react-native-windows. Reviewed By: cortinico Differential Revision: D58234088 Pulled By: javache fbshipit-source-id: 0453f3509c97854975b90e7a3b8c458ca977ec65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The RNW integration to RN 04/13 (microsoft/react-native-windows#13226) adds EventPerformanceLogger.cpp and PerformanceEntryReporter.cpp.
We're getting the following errors:
Switching to size_t fixes it.
Changelog:
[Internal] [FIXED] - EventPerformanceLogger + BoundedConsumableBuffer - switch members to size_t
Test Plan:
Builds on Windows