-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration 04/13/24 (1b152f6ec) #13226
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlenecota
force-pushed
the
integration-0413
branch
from
May 13, 2024 18:39
4517f30
to
841819b
Compare
2 tasks
marlenecota
changed the title
Integration 04/06/24 (1b152f6ec)
Integration 04/13/24 (1b152f6ec)
May 13, 2024
This was referenced May 13, 2024
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
May 14, 2024
…size_t (#44564) Summary: The RNW integration to RN 04/13 (microsoft/react-native-windows#13226) adds EventPerformanceLogger.cpp and PerformanceEntryReporter.cpp. We're getting the following errors: ![image](https://github.com/facebook/react-native/assets/1422161/33a4dc42-1d14-4ac4-befd-87ec5cd02640) ![image](https://github.com/facebook/react-native/assets/1422161/6269968d-c0e8-489b-992e-0bb41b6ef7c6) Switching to size_t fixes it. ## Changelog: [Internal] [FIXED] - EventPerformanceLogger + BoundedConsumableBuffer - switch members to size_t Pull Request resolved: #44564 Test Plan: Builds on Windows Reviewed By: fabriziocucci Differential Revision: D57327696 Pulled By: javache fbshipit-source-id: 21ec3a9597958aa70fbca64710bd615a1022292d
TatianaKapos
approved these changes
May 14, 2024
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
…size_t (facebook#44564) Summary: The RNW integration to RN 04/13 (microsoft/react-native-windows#13226) adds EventPerformanceLogger.cpp and PerformanceEntryReporter.cpp. We're getting the following errors: ![image](https://github.com/facebook/react-native/assets/1422161/33a4dc42-1d14-4ac4-befd-87ec5cd02640) ![image](https://github.com/facebook/react-native/assets/1422161/6269968d-c0e8-489b-992e-0bb41b6ef7c6) Switching to size_t fixes it. ## Changelog: [Internal] [FIXED] - EventPerformanceLogger + BoundedConsumableBuffer - switch members to size_t Pull Request resolved: facebook#44564 Test Plan: Builds on Windows Reviewed By: fabriziocucci Differential Revision: D57327696 Pulled By: javache fbshipit-source-id: 21ec3a9597958aa70fbca64710bd615a1022292d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
facebook/react-native@a05466c...1b152f6
Integration follow-ups: #13228 #13231
Notable Changes
facebook/react-native#43951
facebook/react-native#43962
facebook/react-native#43882
facebook/react-native#43068
Type of Change
Integration
Microsoft Reviewers: Open in CodeFlow