Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fabric] Unfork BoundedConsumableBuffer.h #13231

Closed
marlenecota opened this issue May 13, 2024 · 3 comments
Closed

[Fabric] Unfork BoundedConsumableBuffer.h #13231

marlenecota opened this issue May 13, 2024 · 3 comments
Assignees
@marlenecota @Yajur-Grover
Labels
Deforking enhancement Integration Follow-up New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Milestone
Next

Comments

@marlenecota
Copy link
Contributor

marlenecota commented May 13, 2024 •
edited
Loading

Summary

The RNW integration to RN 04/13 (#13226) adds EventPerformanceLogger.cpp and we're getting the following error:
image

Changing uint32_t to size_t fixes it.

There's also issues with BoundedConsumableBuffer.h:
image

Upstream PR: facebook/react-native#44564

Can be unforked after RN integration passes 5/13
@marlenecota marlenecota self-assigned this May 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label May 13, 2024
@marlenecota marlenecota removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label May 13, 2024
@marlenecota marlenecota mentioned this issue May 13, 2024
Merged
@marlenecota marlenecota changed the title [Fabric] Unfork react\renderer\observers\events\EventPerformanceLogger.cpp [Fabric] Unfork EventPerformanceLogger.cpp and BondedConsumableBuffer.h May 14, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label May 14, 2024
@marlenecota marlenecota added this to the Next milestone May 14, 2024
@jonthysell jonthysell added bug New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric and removed Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) labels Jun 3, 2024
@marlenecota marlenecota changed the title [Fabric] Unfork EventPerformanceLogger.cpp and BondedConsumableBuffer.h [Fabric] Unfork BondedConsumableBuffer.h Jun 5, 2024
@marlenecota marlenecota changed the title [Fabric] Unfork BondedConsumableBuffer.h [Fabric] Unfork BoundedConsumableBuffer.h Jun 5, 2024
@marlenecota
Copy link
Contributor Author

Missed one int -> size_t in BoundedConsumableBuffer.h.

Upstream PR: facebook/react-native#44806

@marlenecota
Copy link
Contributor Author

Upstream PR has merged. We can unfork this after the 6/6/24 integration.

@marlenecota marlenecota added Deforking and removed bug labels Jun 7, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Jun 8, 2024
@Yajur-Grover Yajur-Grover self-assigned this Jun 10, 2024
@TatianaKapos TatianaKapos mentioned this issue Jun 11, 2024
Merged
@Yajur-Grover
Copy link
Contributor

Resolved in 6/10 integration: #13325

@chrisglein chrisglein added enhancement and removed Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) labels Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marlenecota marlenecota

@Yajur-Grover Yajur-Grover

Labels
Deforking enhancement Integration Follow-up New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Projects
RNW New Architecture
Status: Done
Milestone
Next
Development

No branches or pull requests
4 participants
@marlenecota @jonthysell @chrisglein @Yajur-Grover