Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix signed/unsigned mismatch in BoundedConsumableBuffer.h #44806

Closed
wants to merge 1 commit into from
Closed

Fix signed/unsigned mismatch in BoundedConsumableBuffer.h #44806

wants to merge 1 commit into from

Conversation

marlenecota
Copy link
Contributor

Summary:

Previous PR (#44564) missed one int -> size_t switch to fix C4018 in react-native-windows.
image

Changelog:

[INTERNAL] - Fix signed/unsigned mismatch in BoundedConsumableBuffer.h

Test Plan:

Builds on Windows + identical to forked file used in react-native-windows.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner labels Jun 5, 2024
@marlenecota marlenecota mentioned this pull request Jun 5, 2024
Closed
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jun 5, 2024
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,675,023 +5
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,044,528 +6
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: a569c82
Branch: main

@facebook-github-bot
Copy link
Contributor

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 6, 2024
@facebook-github-bot
Copy link
Contributor

@javache merged this pull request in 3b60c86.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

This pull request was successfully merged by @marlenecota in 3b60c86.

When will my fix make it into a release? | How to file a pick request?

@marlenecota marlenecota deleted the sign-mismatch branch June 6, 2024 17:33
kosmydel pushed a commit to kosmydel/react-native that referenced this pull request Jun 11, 2024
@marlenecota @kosmydel
Fix signed/unsigned mismatch in BoundedConsumableBuffer.h (facebook#4…
74bee59 
…4806)

Summary:
Previous PR (facebook#44564) missed one int -> size_t switch to fix C4018 in react-native-windows.
![image](https://github.com/facebook/react-native/assets/1422161/373480ed-7f49-4c01-a7ac-ea65a347ab1c)

## Changelog:

[INTERNAL] - Fix signed/unsigned mismatch in BoundedConsumableBuffer.h

Pull Request resolved: facebook#44806

Test Plan: Builds on Windows + identical to forked file used in react-native-windows.

Reviewed By: cortinico

Differential Revision: D58234088

Pulled By: javache

fbshipit-source-id: 0453f3509c97854975b90e7a3b8c458ca977ec65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Microsoft Partner: Microsoft Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marlenecota @analysis-bot @facebook-github-bot