-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IP detection on Mac with loopback #12875
Fix IP detection on Mac with loopback #12875
Commits on Mar 21, 2017
-
Summary: remove `copyProperties` module, and replace the functionality with `Object.assign` Reviewed By: javache Differential Revision: D4745771 fbshipit-source-id: 2440620757e7539dbd7fd39f5920ac0b5b4183c5
Configuration menu - View commit details
-
Copy full SHA for a34956f - Browse repository at this point
Copy the full SHA a34956fView commit details -
Only use
EventValidator
in development modeSummary: Only pulls in `EventValidator` for development mode, as warnings about invalid events are pointless in production builds. Reviewed By: javache Differential Revision: D4745852 fbshipit-source-id: dbab1026df35d54a82e1e620fac08304c58fbeae
Configuration menu - View commit details
-
Copy full SHA for 2b4762f - Browse repository at this point
Copy the full SHA 2b4762fView commit details -
Reviewed By: davidaurelio Differential Revision: D4746429 fbshipit-source-id: 1a49a4b6db75658749346f0fd94dad68ff084203
Configuration menu - View commit details
-
Copy full SHA for 4797701 - Browse repository at this point
Copy the full SHA 4797701View commit details -
Differential Revision: D4713064 fbshipit-source-id: 511b782279b89076228f00290e78ed155e2e723e
Configuration menu - View commit details
-
Copy full SHA for 314ec87 - Browse repository at this point
Copy the full SHA 314ec87View commit details -
Improved implementation of placeholer feature in RCTUITextView
Reviewed By: fkgozali Differential Revision: D4746177 fbshipit-source-id: a8c27ec052b046d4732b14ed081dcaebb44bdaa7
Configuration menu - View commit details
-
Copy full SHA for 1433185 - Browse repository at this point
Copy the full SHA 1433185View commit details -
Fix instrumentation tests for api 22
Summary: Bug in Android https://code.google.com/p/android/issues/detail?id=33868 causes the RN catalyst instrumentation test to fail with ``` java.lang.ArrayIndexOutOfBoundsException: length=253; index=-1 at android.text.StaticLayout.calculateEllipsis(StaticLayout.java:667) at android.text.StaticLayout.out(StaticLayout.java:631) at android.text.StaticLayout.generate(StaticLayout.java:423) ... ``` The fix is to set singleLine to true when there is only one line of text Reviewed By: AaaChiuuu Differential Revision: D4562000 fbshipit-source-id: 84248e3982063b767e8b0465effe2321b54a7fa2
Configuration menu - View commit details
-
Copy full SHA for ee245b9 - Browse repository at this point
Copy the full SHA ee245b9View commit details -
Remove Navigator recommendation
Summary: We recommend using `react-navigation` over `Navigator`. Adds a link to the new `native-navigation` component as well. Did not test website generation, this is a comments only edit that should work fine. Closes facebook#12963 Differential Revision: D4749072 Pulled By: hramos fbshipit-source-id: 4506630306c44b24b95c4f5d5a42c1caa9e2cd4e
4Configuration menu - View commit details
-
Copy full SHA for a030432 - Browse repository at this point
Copy the full SHA a030432View commit details -
Summary: Some quick copy changes. Closes facebook#13061 Differential Revision: D4749511 Pulled By: hramos fbshipit-source-id: 5b6f67be40ed071367507ac3c87f7ac67a0584e7
Configuration menu - View commit details
-
Copy full SHA for 68c655a - Browse repository at this point
Copy the full SHA 68c655aView commit details -
don't call clearFrameCallback() if we don't have a ReactChoreographer…
… to clear the frame callback on Reviewed By: achen1 Differential Revision: D4741906 fbshipit-source-id: 2d5fabab6e04c08252513f77149c04e3b8314d2c
Configuration menu - View commit details
-
Copy full SHA for ba75d99 - Browse repository at this point
Copy the full SHA ba75d99View commit details -
Fixes missleading comment on getInitialURL
Summary: The returned value from Linking.getInitialURL is a promise that returns an url. Can be seen here: https://github.com/facebook/react-native/blob/f126540519bd276c0048aa77b543dc863412de46/Libraries/Linking/Linking.js#L175 Closes facebook#12851 Differential Revision: D4716084 Pulled By: hramos fbshipit-source-id: 309881cfb423a5c9a3f9010ae7ca226b63c91599
Configuration menu - View commit details
-
Copy full SHA for c41b29d - Browse repository at this point
Copy the full SHA c41b29dView commit details
Commits on Mar 22, 2017
-
Make the choice of bridge based on an optional delegate method
Reviewed By: javache Differential Revision: D4679644 fbshipit-source-id: f53e554e283fdb0b59c41623e690fd1a21e03a57
Configuration menu - View commit details
-
Copy full SHA for d9ac007 - Browse repository at this point
Copy the full SHA d9ac007View commit details -
Tease apart React and RCTBatchedBridge targets
Reviewed By: javache Differential Revision: D4679655 fbshipit-source-id: 8123488c2d50dd7cc2329b5131e99998fe1f1e2f
Configuration menu - View commit details
-
Copy full SHA for ba149d7 - Browse repository at this point
Copy the full SHA ba149d7View commit details -
Reviewed By: yungsters Differential Revision: D4726519 fbshipit-source-id: 1ae98743cdb89acb2708d84073527015dbeee906
Configuration menu - View commit details
-
Copy full SHA for 462352e - Browse repository at this point
Copy the full SHA 462352eView commit details -
invariants around scrollToIndex without getItemLayout
Summary: People might be tempted to try and scrollTo an index that hasn't been rendered yet, which is broken, so instead of jank let's throw. Reviewed By: yungsters Differential Revision: D4727402 fbshipit-source-id: b6f9fd5b70b6f076c30141d00b2b9e2a51b14e87
1Configuration menu - View commit details
-
Copy full SHA for edd5624 - Browse repository at this point
Copy the full SHA edd5624View commit details -
Componentize Spindicator and add to SectionListExample
Reviewed By: yungsters Differential Revision: D4688309 fbshipit-source-id: 4e1c70039050170cc0bc2eca0bba0fd077c692d2
Configuration menu - View commit details
-
Copy full SHA for 7861fdd - Browse repository at this point
Copy the full SHA 7861fddView commit details -
Summary: This adds support for both automagical sticky section headers in `SectionList` as well as the more free-form `stickyHeaderIndices` on `FlatList` or `VirtualizedList`. The basic concept is to take the initial `stickySectionHeaders` and remap them to the indices corresponding to the mounted subset in the render window. The main trick here is that the currently stuck header might itself be outside of the render window, so we need to search the gap to see if that's the case and render it (with spacers above and below it instead of one big spacer). In the `SectionList` we simply pre-compute the sticky headers at the same time as when we scan the sections to determine the flattened length and pass those to `VirtualizedList`. This also requires some updates to `ScrollView` to work in the churny environment of `VirtualizedList`. We propogate the keys on the children to the animated wrappers so that as items are removed and the indices of the remaining items change, react can keep proper track of them. We also fix the scroll back case where new headers are rendered from the top down and aren't updated with the `setNextLayoutY` callback because the `onLayout` call for the next header happened before it was mounted. This is done by just tracking all the layout values in a map and providing them to the sticky components at render time. This might also improve perf a little by property configuring the animations syncronously instead of waiting for the `onLayout` callback. We also need to protect against stale onLayout callbacks and other fun stuff. == Test Plan == https://www.facebook.com/groups/react.native.community/permalink/940332509435661/ Scroll a lot with and without debug mode on. Make sure spinner still spins and there are no crashes (lots of crashes during development due to the animated configuration being non-monotonic if anything stale values get through). Also made sure that tapping a row to change it's height would properly update the animation configurations so the collision point would still be correct. Reviewed By: yungsters Differential Revision: D4695065 fbshipit-source-id: 855c4e31c8f8b450d32150dbdb2e07f1a9f9f98e
10Configuration menu - View commit details
-
Copy full SHA for 72670bf - Browse repository at this point
Copy the full SHA 72670bfView commit details -
Summary: It was just adding unnecessary complexity. Users should just use standard React perf best practices, like `PureComponent` and `shouldComponentUpdate`. This should be backwards compatible - existing `shouldItemUpdate` usage will just be ignored and should consider migrating to this pattern: ``` class MyItem extends React.PureComponent { _onPress = () => { this.props.onPressItem(this.props.id); }; render() { return ( <SomeOtherWidget title={this.props.title} onPress={this._onPress} /> ) } } ... _renderItem = ({item}) => ( <MyItem onPressItem={this._onPressItem} title={item.title} id={item.id} /> ); ``` Which will automatically prevent re-renders unless the relavent data changes. Reviewed By: yungsters Differential Revision: D4730599 fbshipit-source-id: 0f61efe96eb4d95bb3b7c4ec889e3e0e34436e56
Configuration menu - View commit details
-
Copy full SHA for 5c85615 - Browse repository at this point
Copy the full SHA 5c85615View commit details -
change section-specific SeparatorComponent -> ItemSeparatorComponent …
…for consistency Summary: Not sure how I missed this in facebook@3ce31c2 Reviewed By: yungsters Differential Revision: D4731083 fbshipit-source-id: 860ed9d2f99312cd02b84ba467ba66afc5cdd5c5
Configuration menu - View commit details
-
Copy full SHA for 1531f5f - Browse repository at this point
Copy the full SHA 1531f5fView commit details -
useful error when switching numColumns on the fly
Reviewed By: blairvanderhoof, bvaughn Differential Revision: D4742842 fbshipit-source-id: a11a088194ead02cc11eb6ccd9ce6d6f75ead3a3
Configuration menu - View commit details
-
Copy full SHA for 46d6766 - Browse repository at this point
Copy the full SHA 46d6766View commit details -
Summary: It's supposed to take a component or a handle, per the arg name, so switch on the type (and handle `null`). `FlatListExample` no longer crashes. Reviewed By: bvaughn, sebmarkbage Differential Revision: D4752619 fbshipit-source-id: 720421f648f7c2049b5cc44f006484eb47d22d86
Configuration menu - View commit details
-
Copy full SHA for 93c438d - Browse repository at this point
Copy the full SHA 93c438dView commit details -
Summary: 1. Mention scrollToIndex support. 2. Fix a format error. 3. Use relative links like https://github.com/facebook/react-native/blob/59257d6976656f4eeaf389ae5527dfaff08e7354/Libraries/Components/Navigation/NavigatorIOS.ios.js#L136 for links in "next version" to work properly. ~~4. BREAKING: `columnWrapperStyle` should be `rowWrapperStyle`?~~ Closes facebook#12714 Differential Revision: D4730476 Pulled By: sahrens fbshipit-source-id: 643aab659064e6f5275ec89fd7f967dd9de866c4
Configuration menu - View commit details
-
Copy full SHA for f39ef36 - Browse repository at this point
Copy the full SHA f39ef36View commit details -
Remove unused websocket-executor-name and websocket-executor-port opt…
…ions Reviewed By: davidaurelio Differential Revision: D4745529 fbshipit-source-id: 2c69aca33c999ccf2af8dbf8d9af2c1d123b59cd
Configuration menu - View commit details
-
Copy full SHA for 0ea1ea5 - Browse repository at this point
Copy the full SHA 0ea1ea5View commit details -
Fix PerformanceLogger clearing unfinished events
Reviewed By: alexeylang Differential Revision: D4749516 fbshipit-source-id: 348f1cf51c01b39a410be8b39598e8e98cd52d55
Configuration menu - View commit details
-
Copy full SHA for 005fbe6 - Browse repository at this point
Copy the full SHA 005fbe6View commit details -
Add flow typing to PerformanceLogger
Reviewed By: AaaChiuuu Differential Revision: D4749896 fbshipit-source-id: 8a3f12e5d7b209c48c95f8564d8e3bcbd19f90c8
Configuration menu - View commit details
-
Copy full SHA for 9506376 - Browse repository at this point
Copy the full SHA 9506376View commit details -
Lock version to 2.7.5 to avoid breakage like facebook#12772
Summary: As per uglify-js maintainer kzc's comment in mishoo/UglifyJS#1573 (comment) we should be locking our version to prevent issues like facebook#12772 from happening again. No test plan needed, people are already using this version of uglify-js (it's the latest). Closes facebook#12802 Differential Revision: D4749853 Pulled By: javache fbshipit-source-id: 866a19cb2c1add31b55e14d0f4dadb7f68fda64c
Configuration menu - View commit details
-
Copy full SHA for 54989d0 - Browse repository at this point
Copy the full SHA 54989d0View commit details -
packager: GlobalTransformCache-test: disable non-deterministic test
Reviewed By: davidaurelio Differential Revision: D4751434 fbshipit-source-id: 1be748387abe9ca0ce030bd2423827dfe5c2a146
Configuration menu - View commit details
-
Copy full SHA for d5288e7 - Browse repository at this point
Copy the full SHA d5288e7View commit details -
packager: Package.js: make read()-based API sync
Reviewed By: davidaurelio Differential Revision: D4745885 fbshipit-source-id: 3d327e5ca91fcbe7ec1d30ff8e6135b415074aa4
Configuration menu - View commit details
-
Copy full SHA for ebd8b2a - Browse repository at this point
Copy the full SHA ebd8b2aView commit details -
Refactor measuring app require time
Reviewed By: javache Differential Revision: D4746020 fbshipit-source-id: cfc9de286feeac49b4b569560dc29c7a1c25eee1
Configuration menu - View commit details
-
Copy full SHA for e22898b - Browse repository at this point
Copy the full SHA e22898bView commit details -
packager: Module.js: make read()-based API sync
Reviewed By: davidaurelio Differential Revision: D4746218 fbshipit-source-id: 1a36bd00a47a6b871cc77433b2325a11e90035b2
Configuration menu - View commit details
-
Copy full SHA for 5eb954f - Browse repository at this point
Copy the full SHA 5eb954fView commit details -
Added deprecation warning for View.* static accessibility traits acce…
…ssors Reviewed By: spicyj Differential Revision: D4749932 fbshipit-source-id: 5f07200e953f589f939196a161a1bc796c553868
Configuration menu - View commit details
-
Copy full SHA for ef3db66 - Browse repository at this point
Copy the full SHA ef3db66View commit details -
Fix ClassCastException in ReactModuleSpecProcessor
Reviewed By: AaaChiuuu Differential Revision: D4752195 fbshipit-source-id: 7c01f9be4d82dbc605f1e6d3b217f0c83f177165
Configuration menu - View commit details
-
Copy full SHA for 379b60d - Browse repository at this point
Copy the full SHA 379b60dView commit details -
packager: Package.js: cover the error cases
Summary: In case the sync function throws, it wouldn't be handled through the promise anymore, that is not what we want. So we revert that in this changeset. Reviewed By: davidaurelio Differential Revision: D4754740 fbshipit-source-id: 4da360f4b629bbdf9cd284389060429cc9259c2c
Configuration menu - View commit details
-
Copy full SHA for 909d2e5 - Browse repository at this point
Copy the full SHA 909d2e5View commit details -
packager: Module.js: cover the error cases
Summary: We want any exception thrown by `_getHasteName` to be captured by the promise instead of breaking the outer stack. Reviewed By: davidaurelio Differential Revision: D4754825 fbshipit-source-id: 173c7c8867da73efb198ed3159704d6fd0e7b87d
Configuration menu - View commit details
-
Copy full SHA for 3054842 - Browse repository at this point
Copy the full SHA 3054842View commit details -
Use checkPropTypes instead of directly calling PropTypes
Reviewed By: sebmarkbage Differential Revision: D4748563 fbshipit-source-id: 137c8bd637549c455bff3be61143e8e438c6a886
Configuration menu - View commit details
-
Copy full SHA for d9910a5 - Browse repository at this point
Copy the full SHA d9910a5View commit details
Commits on Mar 23, 2017
-
Remove React addons from react-native-implementation
Summary: These modules don't exist in React anymore so this causes new apps to redscreen because the packager cannot resolve those modules. **Test plan** Tested that this and removing NavigationExperimental (it also uses removed React exports) causes UIExplorer to work again. Closes facebook#13095 Differential Revision: D4757762 Pulled By: ericvicenti fbshipit-source-id: bb246d4c6b15f5d3c71e31f133a468aea220f308
Configuration menu - View commit details
-
Copy full SHA for 14c31d9 - Browse repository at this point
Copy the full SHA 14c31d9View commit details -
Sync React master (and 16 alpha 4)
Reviewed By: sebmarkbage Differential Revision: D4747529 fbshipit-source-id: 5efea6422a2502f27c1b23506cbae2187c7f7b0d
Configuration menu - View commit details
-
Copy full SHA for 703936d - Browse repository at this point
Copy the full SHA 703936dView commit details -
Summary: Added this as part of a random PR to get flow passing. This collides with a similar fix by bvaughn so let's remove mine. Also I messed up and there is a + at the start of the line :o Closes facebook#13103 Differential Revision: D4761349 fbshipit-source-id: 0abde66a1ac4c185bbd7142ecd800cf5ac8f3c5b
Configuration menu - View commit details
-
Copy full SHA for 971c2be - Browse repository at this point
Copy the full SHA 971c2beView commit details -
Improve dark mode for debugger
Summary: * Added a label so we can click on the text to toggle the dark mode * Added `height: 100%` in the CSS to make the dark background fill the entire view * Improving JS code with `classList.toggle()` instead of redundant `if else` and fragile `document.styleSheets` access * Adjusted the link color in dark mode to be less flashy ![image](https://cloud.githubusercontent.com/assets/5436545/24155304/bb80bb9a-0e53-11e7-9298-ce2c1ec6672c.png) ![image](https://cloud.githubusercontent.com/assets/5436545/24155311/c27e85f8-0e53-11e7-87ae-0245f54870c5.png) Closes facebook#13052 Differential Revision: D4748893 fbshipit-source-id: a81266c52b24f8e5dcedf0b9f37134688342d8d2
Configuration menu - View commit details
-
Copy full SHA for 8a8f34a - Browse repository at this point
Copy the full SHA 8a8f34aView commit details -
Picker (android): Convert children to an array before accessing with …
…a position Summary: When using the following component, `this.props.children` is not a flat array. ``` js class Example extends Component { // ... render() { const values = ['1', '2']; return ( <Picker value={this.state.value} onValueChange={this.onValueChange.bind(this)} > <Picker.Item label="n/a" value={null} /> {values.map(value => { return ( <Picker.Item label={value} value={value} /> ); })} </Picker> ); } } ``` The resulting `this.props.children` is: ``` js [ (child), [ (child), (child), ], ]; ``` Therefor you can't use `this.props.children[2]` to get the last item. The Android version of the [Picker](https://facebook.github.io/react-native/do Closes facebook#8153 Differential Revision: D4753480 Pulled By: javache fbshipit-source-id: deb0264746b39303e66c69c191af0c962db39085
Configuration menu - View commit details
-
Copy full SHA for 720e195 - Browse repository at this point
Copy the full SHA 720e195View commit details -
Fix usages of ReactComponentWithPureRenderMixin
Summary: Closes facebook#13111 Differential Revision: D4761971 Pulled By: davidaurelio fbshipit-source-id: 668dcc58e8e1b075ee760233abc6904beede9218
Configuration menu - View commit details
-
Copy full SHA for a2cfea1 - Browse repository at this point
Copy the full SHA a2cfea1View commit details -
ReactNative moved View.propTypes to ViewPropTypes
Reviewed By: yungsters Differential Revision: D4761354 fbshipit-source-id: b49922d78ee5d8628f945e5dee476ffe5d889b07
Configuration menu - View commit details
-
Copy full SHA for 53905a5 - Browse repository at this point
Copy the full SHA 53905a5View commit details -
Summary: Typing "android avd" into the terminal is not supported anymore. The android command is no longer available. There are workarounds, but it involves replacing files with the older ones. Thanks for submitting a PR! Please read these instructions carefully: - [ ] Explain the **motivation** for making this change. - [ ] Provide a **test plan** demonstrating that the code is solid. - [ ] Match the **code formatting** of the rest of the codebase. - [ ] Target the `master` branch, NOT a "stable" branch. What existing problem does the pull request solve? A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See [What is a Test Plan?][1] to learn more. If you have added code that should be tested, add tests. Sign the [CLA][2], if you haven't already. Small pull requests are much easier to review and more likely to get merged Closes facebook#13096 Reviewed By: AsyncDBConnMarkedDownDBException Differential Revision: D4762937 Pulled By: AsyncDBConnMarkedDownDBException fbshipit-source-id: 5289402d7e6934d3493a902247a991cd1d887ec0
Configuration menu - View commit details
-
Copy full SHA for 123311c - Browse repository at this point
Copy the full SHA 123311cView commit details -
ReactNativeFiber findNodeHandle() bugfix
Reviewed By: sahrens Differential Revision: D4762397 fbshipit-source-id: d047f5c77067dbf8b0331695bb661e04ce00913c
Configuration menu - View commit details
-
Copy full SHA for 333dd59 - Browse repository at this point
Copy the full SHA 333dd59View commit details -
Move NetworkRecordingModuleMock into testing/network
Reviewed By: AaaChiuuu Differential Revision: D4755904 fbshipit-source-id: 8a68530453b1d288da402f17e16fec9c57e5bb2a
Configuration menu - View commit details
-
Copy full SHA for 04ccbdd - Browse repository at this point
Copy the full SHA 04ccbddView commit details -
Fix grammar in the "Running on a device" docs
Summary: The wording had some grammar issues. The instructions were also not as precise as they could be. Verified on Xcode 8.2.1. Closes facebook#13093 Differential Revision: D4763071 Pulled By: hramos fbshipit-source-id: fe9da098f0e457efba4712db704692f6f4857624
Configuration menu - View commit details
-
Copy full SHA for 1091868 - Browse repository at this point
Copy the full SHA 1091868View commit details -
packager: ResolutionRequest.js: _loadAsDir and _loadAsFile sync
Reviewed By: davidaurelio Differential Revision: D4754090 fbshipit-source-id: 84ad1d988bf097d3094d90f3738ce64cc523879c
Configuration menu - View commit details
-
Copy full SHA for f06384b - Browse repository at this point
Copy the full SHA f06384bView commit details -
packager: ResolutionRequest.js: sync _resolveFileOrDir
Reviewed By: davidaurelio Differential Revision: D4754138 fbshipit-source-id: d19792a726220a673dead1c8c6cdf487e34a6808
Configuration menu - View commit details
-
Copy full SHA for 3f0f735 - Browse repository at this point
Copy the full SHA 3f0f735View commit details -
packager: ResolutionRequest.js: sync _resolveHasteDependency()
Summary: Some more synchronicity, one step at a time. Reviewed By: davidaurelio Differential Revision: D4756542 fbshipit-source-id: 0c56dbca61b3da764aa8d28e29c0e20b54de091e
Configuration menu - View commit details
-
Copy full SHA for 337daa3 - Browse repository at this point
Copy the full SHA 337daa3View commit details -
Summary: Thanks for submitting a PR! Please read these instructions carefully: - [ ] Explain the **motivation** for making this change. - [ ] Provide a **test plan** demonstrating that the code is solid. - [ ] Match the **code formatting** of the rest of the codebase. - [ ] Target the `master` branch, NOT a "stable" branch. What existing problem does the pull request solve? A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See [What is a Test Plan?][1] to learn more. If you have added code that should be tested, add tests. Sign the [CLA][2], if you haven't already. Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. Make sure all **tests pass** on both [Travis][3] and [Circle CI][4]. PRs that break tests are unlikely to be merged. Closes facebook#13122 Differential Revision: D4763115 Pulled By: hramos fbshipit-source-id: 5d4852a133d42e3fd6eb084cf491a672cf075c29
Configuration menu - View commit details
-
Copy full SHA for 53f9e6a - Browse repository at this point
Copy the full SHA 53f9e6aView commit details -
Summary: The Play Store started serving WebP files for these icons, which are not rendered well in Safari. Switched to JPEGs from the App Store. Periodical pruning of the showcase: Removed several entries to keep the showcase fresh. Closes facebook#13098 Differential Revision: D4762944 Pulled By: hramos fbshipit-source-id: 5f9c43fd186f20b432c54496b143b4a9dd5851e3
Configuration menu - View commit details
-
Copy full SHA for 1f15c75 - Browse repository at this point
Copy the full SHA 1f15c75View commit details -
Fix warnings in React.xcodeproj
Summary: Various fixes of xcode projects and cleaning up some warnings Closes facebook#13109 Differential Revision: D4762652 Pulled By: lacker fbshipit-source-id: b452976a58962439de4adecc8e703264af40cb38
Configuration menu - View commit details
-
Copy full SHA for 9d377e9 - Browse repository at this point
Copy the full SHA 9d377e9View commit details -
Summary: Implementing removeAllDeliveredNotifications and removeDeliveredNotifications for remove notifications from notification center, and getDeliveredNotifications Thanks for submitting a PR! Please read these instructions carefully: - [x] Explain the **motivation** for making this change. - [x] Provide a **test plan** demonstrating that the code is solid. - [x] Match the **code formatting** of the rest of the codebase. - [x] Target the `master` branch, NOT a "stable" branch. Currently, calling PushNotificationIOS.cancelAllLocalNotifications not remove the notification from the Notification Center In iOS 10, a new UNUserNotification class was introduced, this class has a method which get and remove the notifications from notification center This PR try to solve that. In my case, i'm working with an messaging app, every message is a new notification, when the user tap a notification, the app is opened and the rest of notifications should be gon Closes facebook#13036 Differential Revision: D4761828 Pulled By: javache fbshipit-source-id: 216e44a64f1bf88b5ae3045d1fa6eca8a1278a71
Configuration menu - View commit details
-
Copy full SHA for 3df654e - Browse repository at this point
Copy the full SHA 3df654eView commit details -
Clean up some of the ReactNative Buck rules
Reviewed By: yangchi Differential Revision: D4739284 fbshipit-source-id: 0ee335df0d114631e5fc60d5d6e51547e5312d39
Configuration menu - View commit details
-
Copy full SHA for dcf3cbe - Browse repository at this point
Copy the full SHA dcf3cbeView commit details -
packager: TerminalReporter: stop reporting global cache errors
Summary: At FB we log errors into the error infra, and these errors are not actionnable for end users, so let's reduce the noise generated on the terminal. In the OSS case, people can simply add a handler in a TerminalReporter decorator, the same way we do internally (anyhow, I do not know of anyone using the global cache in OSS for now). Reviewed By: davidaurelio Differential Revision: D4762858 fbshipit-source-id: 880c02e175ae551df11b7ce273acc318222c46bf
Configuration menu - View commit details
-
Copy full SHA for 20ba987 - Browse repository at this point
Copy the full SHA 20ba987View commit details -
Enable -Wimplicit-retain-self en sync warning config for all projects
Summary: This is enforced for all of our internal iOS code and a common cause of import failures. cc janicduplessis Closes facebook#13124 Differential Revision: D4765016 fbshipit-source-id: 7c8248c98bca0fa6bad24d5a52b666243375e0db
Configuration menu - View commit details
-
Copy full SHA for 7c9173b - Browse repository at this point
Copy the full SHA 7c9173bView commit details -
Reviewed By: zertosh Differential Revision: D4732064 fbshipit-source-id: 12fb8f9aff983ff5d1cb01f413bab761259829f9
Configuration menu - View commit details
-
Copy full SHA for d868e86 - Browse repository at this point
Copy the full SHA d868e86View commit details
Commits on Mar 24, 2017
-
Remove Deprecated NavigationExperimental
Summary: Now that there are a number of good navigation solutions provided by the community, we are ready to remove NavigationExperimental from the RN core. The latest navigation doc explains the available options pretty well: http://facebook.github.io/react-native/docs/navigation.html . We should also add a mention to Airbnb's new native-navigation. For anybody who continues to rely on it, it is recommended to migrate to React Navigation, which will be maintained over the long-term. For those who cannot migrate yet, it is possible to copy this code into your app. Closes facebook#13066 Differential Revision: D4757539 Pulled By: ericvicenti fbshipit-source-id: 949d9b33f188584fb095155fa67d3ce24beba29f
Configuration menu - View commit details
-
Copy full SHA for febf3d0 - Browse repository at this point
Copy the full SHA febf3d0View commit details -
Exposed new ViewPropTypes object on ReactNative renderer (stack and f…
…iber) Reviewed By: yungsters Differential Revision: D4765002 fbshipit-source-id: 54be903bf6529df7ab2cff265c1f87b145da8d94
Configuration menu - View commit details
-
Copy full SHA for 9a88c72 - Browse repository at this point
Copy the full SHA 9a88c72View commit details -
Update runAndroid.js to fix startServerInNewWindow() (Windows)
Summary: **Motivation** Resolves issue: facebook#12367. The issue is that the packager does not launch automatically on Windows when running `react-native run-android` like it does on OSX. The proposed change fixes this issue, and causes the packager to be launched automatically on Windows 10. Also note the updated code uses the syntax described in the [Node.js documentation](https://nodejs.org/api/all.html#child_process_spawning_bat_and_cmd_files_on_windows) on spawning .bat files on Windows. **Test plan** Manually tested on Windows 10. Running just `react-native run-android` now results in the packager launching, without needing to run `react-native start` in a new command prompt window. **Screenshot:** ![packager](https://cloud.githubusercontent.com/assets/17132071/23641540/8d82bb7c-02c2-11e7-9c47-d1c9b582bd65.png) Closes facebook#12755 Differential Revision: D4767321 fbshipit-source-id: a14f369ba99939aa44d0ee3403e1d262e2657e6e
Configuration menu - View commit details
-
Copy full SHA for f891985 - Browse repository at this point
Copy the full SHA f891985View commit details -
Ran codemod to replace View.propTypes with ViewPropTypes
Reviewed By: yungsters Differential Revision: D4764838 fbshipit-source-id: 0b47a0fdd6793dab9333bb73bb93053fccc27dae
Configuration menu - View commit details
-
Copy full SHA for de8ce45 - Browse repository at this point
Copy the full SHA de8ce45View commit details -
Allow overrides of NativeModules
Reviewed By: mhorowitz Differential Revision: D4764126 fbshipit-source-id: 036f848f8b3debbb3cc4a34fc99044304615760e
Configuration menu - View commit details
-
Copy full SHA for ff7fb6e - Browse repository at this point
Copy the full SHA ff7fb6eView commit details -
Reviewed By: AaaChiuuu Differential Revision: D4768765 fbshipit-source-id: 91e34faa2fe864b9a9835e6dab07c8396477505f
Configuration menu - View commit details
-
Copy full SHA for 893689c - Browse repository at this point
Copy the full SHA 893689cView commit details -
Fix crash when overriding native modules on RCTJSCExecutor
Reviewed By: alexeylang Differential Revision: D4769955 fbshipit-source-id: 20f4f4c469eafbe2c7a81ad9f5b9a8386195a8ac
Configuration menu - View commit details
-
Copy full SHA for 3f46e59 - Browse repository at this point
Copy the full SHA 3f46e59View commit details -
Instrumentation test for PokesDashboardApp
Reviewed By: AaaChiuuu Differential Revision: D4758149 fbshipit-source-id: 17e448d44af4deccc288738d294146a612d5e9c3
Configuration menu - View commit details
-
Copy full SHA for 820c8e2 - Browse repository at this point
Copy the full SHA 820c8e2View commit details -
Move classic relay into oss packages
Reviewed By: kassens Differential Revision: D4769497 fbshipit-source-id: 0144456a82c3969b399a4a0b37814b5627d191c5
Configuration menu - View commit details
-
Copy full SHA for d2fc08d - Browse repository at this point
Copy the full SHA d2fc08dView commit details -
Remove old examples from RN repo
Summary: React Native originally shipped with these examples, which have gotten super old and unmaintained. Cruft like this in the core repo only slows us down with extra issues and pull requests. Eventually we may create a different repo for samples that will be maintained into the future. We are doing some spring cleaning in the repo, so now is a good time to remove these and let the community share their own examples. Closes facebook#13064 Differential Revision: D4770699 Pulled By: ericvicenti fbshipit-source-id: bbcdec336b28e5a9330afbdb6b166e94e15fa485
Configuration menu - View commit details
-
Copy full SHA for 77d52fe - Browse repository at this point
Copy the full SHA 77d52feView commit details -
Re-License Lists with standard React Native License
Reviewed By: sahrens Differential Revision: D4771084 fbshipit-source-id: 9878a813b7dacb6ec1215fee469b946df0752de9
Configuration menu - View commit details
-
Copy full SHA for ff4468a - Browse repository at this point
Copy the full SHA ff4468aView commit details -
Fix license header on websocket_integration_test_server
Reviewed By: hramos Differential Revision: D4770121 fbshipit-source-id: c05b45e8775cf3d05c8c9a6e87ab35a3bd032087
Configuration menu - View commit details
-
Copy full SHA for 8ff813e - Browse repository at this point
Copy the full SHA 8ff813eView commit details -
Fix license headers on SwipableRow
Reviewed By: hramos Differential Revision: D4770164 fbshipit-source-id: fc1cbbdd2161d4fd307cb14821318466fa6fca57
Configuration menu - View commit details
-
Copy full SHA for 09fe999 - Browse repository at this point
Copy the full SHA 09fe999View commit details
Commits on Mar 25, 2017
-
Fixed previously broken support for negative
scale
(transform
sty……le property) Summary: closes facebook#13081 UIExplorer, TransformExample Closes facebook#13083 Reviewed By: mmmulani Differential Revision: D4758237 Pulled By: shergin fbshipit-source-id: 58385a4cde7a739b6657c293c381644a92918265
Configuration menu - View commit details
-
Copy full SHA for c87c4d0 - Browse repository at this point
Copy the full SHA c87c4d0View commit details -
Summary: This adds a flowified JS module for the FrameRateLogger native module and plugs it into `ScrollResponder` and `AppRegistry`. If there is no `FrameRateLogger` native module, then the function calls will be no-ops. One major limitation is that we can't track animated/programatic scrolls because we don't have reliable end events. Would be generally useful to add those in a followup though. Reviewed By: fkgozali Differential Revision: D4765694 fbshipit-source-id: f3bec771df6ac918200c1afd1a7d8b6da540a4e2
Configuration menu - View commit details
-
Copy full SHA for 27c3e32 - Browse repository at this point
Copy the full SHA 27c3e32View commit details -
PositionError must be an object, not string
Summary: As specifications says, the Position error must be an object with code and message attributes. Right now it is a string. If not, we can't know what kind of error is. Another issue is that the message must be exactly "No available location provider." Specifications: https://developer.mozilla.org/en/docs/Web/API/PositionError Closes facebook#13140 Differential Revision: D4774922 Pulled By: ericvicenti fbshipit-source-id: f956af051461e9f8d6435496283e54b3c4dc8ef5
Configuration menu - View commit details
-
Copy full SHA for 94d93f7 - Browse repository at this point
Copy the full SHA 94d93f7View commit details -
Summary: Taking another pass at this doc after running apps on iOS and Android devices this week. Of note, the Connecting to Dev server section on iOS seemed incomplete. Tested steps on iOS and Android. Tested rendering of the site on all permutations. Closes facebook#13143 Differential Revision: D4775026 Pulled By: hramos fbshipit-source-id: 9b64120922a093ac646d12861d8dee98fb4e5d7d
Configuration menu - View commit details
-
Copy full SHA for 30778b6 - Browse repository at this point
Copy the full SHA 30778b6View commit details -
Moved takeSnapshot method from UIManager to ReactNative
Reviewed By: spicyj Differential Revision: D4767428 fbshipit-source-id: 77c80c0135641ab46f9dce2763f27499a96373a0
7Configuration menu - View commit details
-
Copy full SHA for 848593c - Browse repository at this point
Copy the full SHA 848593cView commit details -
measure delay of calling into UI thread when setting up ReactContext
Reviewed By: yungsters Differential Revision: D4736627 fbshipit-source-id: 6d425ef0ad7bbd54296a619009136c929cb16030
Configuration menu - View commit details
-
Copy full SHA for e2204c5 - Browse repository at this point
Copy the full SHA e2204c5View commit details
Commits on Mar 26, 2017
-
RN: Cleanup Flow / Jest / Metro Configs
Reviewed By: kassens Differential Revision: D4777088 fbshipit-source-id: d07f4d1dd019a814c8bee4caeb57fc1dd3721c27
Configuration menu - View commit details
-
Copy full SHA for 73c85e4 - Browse repository at this point
Copy the full SHA 73c85e4View commit details
Commits on Mar 27, 2017
-
Fix broken references in website, moved lists, remove navigator
Reviewed By: mkonicek Differential Revision: D4775152 fbshipit-source-id: 8af949573ed827ec86a68c1f311c4180f19da742
Configuration menu - View commit details
-
Copy full SHA for 3b28644 - Browse repository at this point
Copy the full SHA 3b28644View commit details -
Fix crash when move on the edge of some phones like HUAWEI P9
Summary: The app crashes because of `TouchEventCoalescingKeyHelper.getCoalescingKey` throwing an exception when move on the edge of some phones like HUAWEI P9. It's caused by that the down time differs from `ACTION_DOWN` to `ACTION_MOVE` which belongs to the same gesture when I touched on the edge of my HUAWEI P9. It seems a native bug of manufacturer. Related issue facebook#11302. ``` java.lang.RuntimeException: Tried to get non-existent cookie at com.facebook.react.uimanager.events.TouchEventCoalescingKeyHelper.getCoalescingKey(TouchEventCoalescingKeyHelper.java:75) at com.facebook.react.uimanager.events.TouchEvent.init(TouchEvent.java:93) at com.facebook.react.uimanager.events.TouchEvent.obtain(TouchEvent.java:46) at com.facebook.react.uimanager.JSTouchDispatcher.handleTouchEvent(JSTouchDispatcher.java:118) at com.facebook.react.ReactRootView.dispatchJSTouchEvent(ReactRootView.java:158) at com.facebook.react.ReactRootView.onInterceptTouchEvent(ReactRootView.java:130) at android.view.Vie Closes facebook#12063 Differential Revision: D4779060 Pulled By: astreet fbshipit-source-id: 5cf20084ff9081f2535ff9cb3b99d1d52c443f03
Configuration menu - View commit details
-
Copy full SHA for d2939ea - Browse repository at this point
Copy the full SHA d2939eaView commit details -
packager: ResolutionRequest.js: sync _resolveNodeDependency()
Summary: Moar synchronicity. Reviewed By: davidaurelio Differential Revision: D4756495 fbshipit-source-id: 4e0758ba8b55bd25a24d79dcc8ac4ace101e2ae8
Configuration menu - View commit details
-
Copy full SHA for b96e210 - Browse repository at this point
Copy the full SHA b96e210View commit details -
packager: ResolutionRequest.js: resolveDependency() now sync
Reviewed By: davidaurelio Differential Revision: D4763593 fbshipit-source-id: b3dc95229d040c776833a88c9a156b9168e0cc4c
Configuration menu - View commit details
-
Copy full SHA for e0ad425 - Browse repository at this point
Copy the full SHA e0ad425View commit details -
Fix license header for TVEventHandler
Reviewed By: yungsters Differential Revision: D4775067 fbshipit-source-id: 3504b0429c14d6a7d79ac4c8464113f4a19ae230
Configuration menu - View commit details
-
Copy full SHA for af34c34 - Browse repository at this point
Copy the full SHA af34c34View commit details -
NavigatorIOS - Remove NavigationContext
Reviewed By: fkgozali Differential Revision: D4774022 fbshipit-source-id: 0184bcbcf6a458eac6377cc6e1cffc0924f0d2d2
5Configuration menu - View commit details
-
Copy full SHA for 7aa2c9a - Browse repository at this point
Copy the full SHA 7aa2c9aView commit details -
Native Animated - Restore, reorganize and add new tests
Summary: Native Animated tests were removed a while back because they were failing, this restores the existing tests and reorganize / cleanup them. It also adds new ones so we have at least one test for each public API. These tests mostly assert that the native animated module is called with the proper args. Closes facebook#12775 Differential Revision: D4684968 Pulled By: ericvicenti fbshipit-source-id: 4783d5edd08101cab7c0ce2eec4f3ccd0fbc1d27
Configuration menu - View commit details
-
Copy full SHA for 87b0378 - Browse repository at this point
Copy the full SHA 87b0378View commit details -
Include ios-cc.sh in the package.
Reviewed By: javache Differential Revision: D4775797 fbshipit-source-id: 632853cc5b809b8e4f5c9bd06386ede385104f7f
Configuration menu - View commit details
-
Copy full SHA for 8706b66 - Browse repository at this point
Copy the full SHA 8706b66View commit details -
Reviewed By: fkgozali Differential Revision: D4770514 fbshipit-source-id: ea3ea7fc5515ff42394bacb4a63a9a6411185e2a
Configuration menu - View commit details
-
Copy full SHA for 92d985f - Browse repository at this point
Copy the full SHA 92d985fView commit details
Commits on Mar 28, 2017
-
React sync (16 beta 6 plus addons)
Reviewed By: sebmarkbage Differential Revision: D4775005 fbshipit-source-id: c50d099dc3d01c10e122c56f11bd990a2b1e81d1
8Configuration menu - View commit details
-
Copy full SHA for 6f9447e - Browse repository at this point
Copy the full SHA 6f9447eView commit details -
expand example with
PureComponent
usage, explicitextraData
prop,…… `initialNumToRender` Summary: Should help with some common pitfalls, e.g. facebook#12512 (comment). Reviewed By: yungsters Differential Revision: D4781833 fbshipit-source-id: 3dec2f0c444645ad710e9ed81390636da4581f0f
Configuration menu - View commit details
-
Copy full SHA for acc1edd - Browse repository at this point
Copy the full SHA acc1eddView commit details -
Native Animated - Restore default values when removing props on iOS
Summary: This fixes a bug that causes properties to keep stale values because they were not restored to their default after being removed when their value was controlled by native animated. To fix this we restore default values in `disconnectFromView` by updating views with null values for all props that we modified previously. However this causes another issue where we lose any props that were set by the normal process because NativeAnimated operations are always executed after UIManager operatations. To fix this I added a way to hook into UIManager view updating process to be able to execute NativeAnimated operations either before or after updating native views. In the case of disconnecting we want to do it before updating views so that it does: Value changed by native animated -> value restored to default -> (optional) value updated by normal prop. This PR also depends on facebook#10658. **Test plan** Tested that this fixed a particular bug in an app that uses ex-navigation + native animations where a navbar w Closes facebook#11819 Differential Revision: D4752566 Pulled By: javache fbshipit-source-id: 68ee28200ffeba859ae1b98ac753bd7dcb8910f0
Configuration menu - View commit details
-
Copy full SHA for c9fae2f - Browse repository at this point
Copy the full SHA c9fae2fView commit details -
Fix cxx bridge headers when archiving
Summary: There were some headers that were in the `public` or `private` section instead of `project` this causes headers to be included in archives and prevent it from being able to be uploaded to the app store. This fixes it by using only `project` headers and copy files like we use in other places. Also fixes a file that was moved and not updated in ReactCxx.xcodeproj. **Test plan** Tested that I am now able to upload an archive on the app store. Closes facebook#13008 Differential Revision: D4779894 Pulled By: javache fbshipit-source-id: 6e36e925cc3fc03c095c9f1872eb5a45b7f0d78c
Configuration menu - View commit details
-
Copy full SHA for ec5baf0 - Browse repository at this point
Copy the full SHA ec5baf0View commit details -
Support calls through MessageQueue when interecting with JSValue dire…
…ctly Reviewed By: yungsters Differential Revision: D4756241 fbshipit-source-id: 5c7309a18ac476a620451bf471471596c9f82cf8
Configuration menu - View commit details
-
Copy full SHA for 7de59b1 - Browse repository at this point
Copy the full SHA 7de59b1View commit details -
Manually inline parseErrorStack
Reviewed By: davidaurelio Differential Revision: D4779541 fbshipit-source-id: bb395a0abd3cf1f9c940429f375cd57ecb992789
Configuration menu - View commit details
-
Copy full SHA for bb48c0c - Browse repository at this point
Copy the full SHA bb48c0cView commit details -
Native Animated - Fix timing animation delay on iOS
Summary: Delay was broken with native animations on iOS. After checking what android does to handle delay, I noticed it does nothing at all since the delay is already handled when generating the animation frames. This removes all code that tried to handle delay on iOS since it is not needed and breaks it. Also updated an example to have delay in UI explorer. Fixes facebook#12388 **Test plan** Tested that delay works in UIExplorer on iOS and Android. Closes facebook#12443 Differential Revision: D4582514 Pulled By: javache fbshipit-source-id: dc53295e716c8476c71ccd578380962f056de2be
Configuration menu - View commit details
-
Copy full SHA for fb54a1e - Browse repository at this point
Copy the full SHA fb54a1eView commit details -
Native Animated - Add tests on iOS
Summary: Adds unit tests to the Native Animated implementation on iOS. This pretty much mirrors the tests we currently have on Android. It also fixes 2 bugs I've found when adding the tests and pass the current time in `stepAnimation` instead of using `CACurrentMediaTime` to make testing easier. - `stopListeningToAnimatedNodeValue` did not actually work at all, it should set the listener to nil. - The finished value in the animation end callback was always true, this simplifies the `RCTAnimationDriver` interface to get rid of `removeAnimation` and fixes the end callback value. **Test plan** - Run the tests - Make sure the UIExplorer example still works Closes facebook#13068 Differential Revision: D4786701 Pulled By: javache fbshipit-source-id: a4f07e6eec1f363ca47b6f27984041793c915bfc
3Configuration menu - View commit details
-
Copy full SHA for 1d37dd0 - Browse repository at this point
Copy the full SHA 1d37dd0View commit details -
packager: GlobalTransformCache: retry keys fetches
Reviewed By: davidaurelio Differential Revision: D4779641 fbshipit-source-id: 1b156bf075fa2456d9e6b1a3f38855357abc1abb
Configuration menu - View commit details
-
Copy full SHA for 33000c7 - Browse repository at this point
Copy the full SHA 33000c7View commit details -
NativeAnimated - Fix missing update at the end of the batch
Summary: This call got lost in the refactor of facebook#11819 and caused some view updating issues. Closes facebook#13183 Differential Revision: D4787565 Pulled By: javache fbshipit-source-id: 8f7d456824c67abee6ac1d5f906e4c831ede889b
Configuration menu - View commit details
-
Copy full SHA for f46fd36 - Browse repository at this point
Copy the full SHA f46fd36View commit details -
Re-added null inst check to avoid EventPropagators bug
Reviewed By: fkgozali Differential Revision: D4787522 fbshipit-source-id: 80eb4da5a6df46a8a7235358c70b2a04e43dc574
Configuration menu - View commit details
-
Copy full SHA for 01215c0 - Browse repository at this point
Copy the full SHA 01215c0View commit details -
Remove CustomComponents folder and license
Reviewed By: yungsters Differential Revision: D4787296 fbshipit-source-id: fddf3c520cb1092ed61b81db247a9572528eb767
Configuration menu - View commit details
-
Copy full SHA for 777e80a - Browse repository at this point
Copy the full SHA 777e80aView commit details -
Replaced View.propTypes with a static getter that warned about deprec…
…ation Reviewed By: spicyj Differential Revision: D4766860 fbshipit-source-id: c0ef46df58b6167178e801d9dbe481101c0dc773
Configuration menu - View commit details
-
Copy full SHA for 1129c60 - Browse repository at this point
Copy the full SHA 1129c60View commit details -
Set hasNewLayout on children when changing their layout due to displa…
…y none parent Reviewed By: astreet Differential Revision: D4786615 fbshipit-source-id: 2f3a16661d37bc37939e8e7a551445886a06524e
Configuration menu - View commit details
-
Copy full SHA for 4bf2d8c - Browse repository at this point
Copy the full SHA 4bf2d8cView commit details -
replace string comparison with enum
Summary: This change change the interface of reactmarker to use enum type and ReactMarker would still support logMarker(string, string) with addtional support for logMarker(ReactMarkerConstants, string). Also moved some markers into the enum. Reviewed By: fkgozali Differential Revision: D4773600 fbshipit-source-id: 336ba79bb9514d3146bdda177861743ae51424ab
Configuration menu - View commit details
-
Copy full SHA for 63035a4 - Browse repository at this point
Copy the full SHA 63035a4View commit details
Commits on Mar 29, 2017
-
Update GettingStarted.md (Windows Packager)
Summary: After pull request facebook#12755 it is no longer necessary to manually start the packager on Windows using `react-native start`. I've updated the documentation to reflect this change, and match the Mac OS - Android instructions (same commands used to launch a project now). Closes facebook#13186 Differential Revision: D4790827 Pulled By: hramos fbshipit-source-id: 5fe5f7ed20ac4b3ee537c95a9b6d7b91fd578c41
Configuration menu - View commit details
-
Copy full SHA for fd6f222 - Browse repository at this point
Copy the full SHA fd6f222View commit details -
Optimize ReactShadowNode by more manually converting between string a…
…nd enums Reviewed By: astreet Differential Revision: D4778954 fbshipit-source-id: ee96415e6787ccfd8eb7a560d76d206db3eaee1d
Configuration menu - View commit details
-
Copy full SHA for 436a9a5 - Browse repository at this point
Copy the full SHA 436a9a5View commit details -
RN: Refactor Chrome Debugger JS
Summary: Refactors JavaScript in the `debugger.html` used to operate the Chrome Debugger. - Pull out all view-related logic into a global `Page` object. - Persist the dark theme across debug sessions using `localStorage`. Reviewed By: kassens Differential Revision: D4786235 fbshipit-source-id: ab959d1c95465a10b4538b14d9c87a51ae3b7078
Configuration menu - View commit details
-
Copy full SHA for 696b49e - Browse repository at this point
Copy the full SHA 696b49eView commit details -
RN: Add "Maintain Priority" Checkbox
Summary: Adds a new checkbox to the Chrome Debugger page that prevents the tab from being deprioritized by Google Chrome. This is accomplished by embedding an inaudible sound byte (in 10Hz range) that loops on a low volume. Reviewed By: kassens Differential Revision: D4786288 fbshipit-source-id: 949d96ed3c0eac92ad56cdd119418df9ec6d0846
3Configuration menu - View commit details
-
Copy full SHA for 5643bbc - Browse repository at this point
Copy the full SHA 5643bbcView commit details -
onEndReached should clear when data changes
Summary: it's possible to update data and not have the content length change, which could prevent onEndReached from ever firing again, so fix that. Reviewed By: bvaughn, yungsters Differential Revision: D4783818 fbshipit-source-id: ec4640f4b8cf820165b045eaafee6fb41c0b0499
Configuration menu - View commit details
-
Copy full SHA for 22a4205 - Browse repository at this point
Copy the full SHA 22a4205View commit details -
Summary: Not sure if this is the proper fix but changing PRODUCT_NAME to RCTAnimation did the trick. Also using `#import "RCTValueAnimatedNode.h"` instead of `#import <RCTAnimation/RCTValueAnimatedNode.h>` in `RCTNativeAnimatedNodesManager.h` can work too. Closes facebook#13190 Differential Revision: D4794401 Pulled By: javache fbshipit-source-id: c33232a676131644afa80e34ca7a1516a2c89f7e
Configuration menu - View commit details
-
Copy full SHA for a85a86b - Browse repository at this point
Copy the full SHA a85a86bView commit details -
Reviewed By: javache Differential Revision: D4762575 fbshipit-source-id: fc3be786640b8c42664d7b357ab0fe197006b28b
Configuration menu - View commit details
-
Copy full SHA for f804af2 - Browse repository at this point
Copy the full SHA f804af2View commit details -
Reviewed By: astreet Differential Revision: D4779743 fbshipit-source-id: 65a4184af6fb959fefff5c2014522c551ca440d5
Configuration menu - View commit details
-
Copy full SHA for 50a6c49 - Browse repository at this point
Copy the full SHA 50a6c49View commit details -
Set web defaults when resetting
Reviewed By: astreet Differential Revision: D4779742 fbshipit-source-id: 5b8c5d7bd432a12984e4ebfd3187da3d680272cd
Configuration menu - View commit details
-
Copy full SHA for 673093e - Browse repository at this point
Copy the full SHA 673093eView commit details -
Animated - Add missing super calls to fix native animated crash
Summary: There was some missing super.__detach calls in some Animated nodes, we rely on the base class being called to drop the node in the native implementation, not doing so will cause some nodes to leak. It also resulted in a crash when removing certain nodes because they would get updated after being detached. **Test plan** Reproduced the crash by unmounting a view that uses a DiffClamp node and made sure this fixes it. Also tested that other native animations still worked properly. Fixes facebook#11317 Closes facebook#12910 Differential Revision: D4718188 Pulled By: javache fbshipit-source-id: 179ec1334532152c124a9c0f447f488311925d0a
Configuration menu - View commit details
-
Copy full SHA for c233191 - Browse repository at this point
Copy the full SHA c233191View commit details -
Improve feel of scroll snapping behavior on iOS
Reviewed By: sahrens, shergin Differential Revision: D4768384 fbshipit-source-id: 6319d058292be6ba38c059d8d1a1bf70bac603e2
Configuration menu - View commit details
-
Copy full SHA for 1d36700 - Browse repository at this point
Copy the full SHA 1d36700View commit details -
The width and height should be in the revsersed order.
Summary: Inspired by facebook#13191 Creating a test app with spannable `TextView`, and observe the text width/height Closes facebook#13203 Differential Revision: D4795809 Pulled By: hramos fbshipit-source-id: a7c6845abe7472dc7ad2f1f978a20d02fe49eda8
Configuration menu - View commit details
-
Copy full SHA for c311096 - Browse repository at this point
Copy the full SHA c311096View commit details -
Update documentation for Modal's prop animationType
Summary: I was using Modal component and I didn't knew what was the default for animationType prop. After reading the code, I saw that it was `none`. I did not tell that the "default" is `slide` if animated is set to `true`, because it is not a default but an implementation of `animated` prop effect and because of the deprecation of `animated`. Thanks. Closes facebook#13196 Differential Revision: D4795765 Pulled By: hramos fbshipit-source-id: 25d62ac7eeb20fc5557918c3d75709f44f5d4972
Configuration menu - View commit details
-
Copy full SHA for 56a4538 - Browse repository at this point
Copy the full SHA 56a4538View commit details -
Make run-ios --device example copy-pastable
Summary: This changes the single quotes to double quotes so this command can be copy-pasted. If a user copy pastes the run-on-device example in bash they will be presented with a confusing prompt because bash expects another terminating single quote. ``` ~ben (master *) ~/code/transit: react-native run-ios --device 'Max's iPhone' > > ``` It seems minor but this could be just confusing enough to frustrate a beginner or someone not familiar with bash. This can be tested by running: ``` react-native run-ios --help ``` and verifying that the "run on device" example is changed: ```diff - react-native run-ios --device 'Max's iPhone' + react-native run-ios --device "Max's iPhone" ``` Closes facebook#13145 Differential Revision: D4776305 Pulled By: hramos fbshipit-source-id: 9500551bfc106cd1687468f7ecc4c91089e1f703
Configuration menu - View commit details
-
Copy full SHA for 140c5f6 - Browse repository at this point
Copy the full SHA 140c5f6View commit details -
Update ReactNative site docgen to handle ViewPropTypes
Reviewed By: hramos Differential Revision: D4795300 fbshipit-source-id: 5ed1dccd94dbefd661532a5a412b9dbecbc8fc93
Configuration menu - View commit details
-
Copy full SHA for 704b662 - Browse repository at this point
Copy the full SHA 704b662View commit details -
Add UIExplorer to manual testing script.
Summary: Encourage a little more testing coverage and make it a little easier to do. Closes facebook#13040 Reviewed By: shergin Differential Revision: D4742701 Pulled By: sahrens fbshipit-source-id: 4398c3b737b09c4113e965725585efc038936515
Configuration menu - View commit details
-
Copy full SHA for a7633af - Browse repository at this point
Copy the full SHA a7633afView commit details -
Don't transfer layout outputs to java for nodes which don't have a ne…
…w layout Summary: As suggested in facebook/yoga#484. This is the PR which only adds the part of using a local bool field for storing the hasLayoutFlag, to be able to pass the layout only if it has really changed. Closes facebook/yoga#492 Reviewed By: astreet Differential Revision: D4786961 Pulled By: emilsjolander fbshipit-source-id: cf3d354b93f6dcc3ef817ef73a47bd29e37d1848
Configuration menu - View commit details
-
Copy full SHA for 759b8cc - Browse repository at this point
Copy the full SHA 759b8ccView commit details
Commits on Mar 30, 2017
-
@allow-large-files @ignore-conflict-markers[i18n] translation auto-up…
…date for i18n/adsmanager.config.json on master fbshipit-source-id: 156680756e04fc7ef69017c49324ff0b7acd030f
Configuration menu - View commit details
-
Copy full SHA for 7f34697 - Browse repository at this point
Copy the full SHA 7f34697View commit details -
@allow-large-files @ignore-conflict-markers[i18n] translation auto-up…
…date for i18n/fb4a.config.json on master fbshipit-source-id: 2d84aa83e9efaaa89838da7c8d9595692b6bccdd
Configuration menu - View commit details
-
Copy full SHA for 5012f89 - Browse repository at this point
Copy the full SHA 5012f89View commit details -
@allow-large-files @ignore-conflict-markers[i18n] translation auto-up…
…date for i18n/instagram.config.json on master fbshipit-source-id: 951f549645f4010bd01ab6486a2b3b617a901b04
Configuration menu - View commit details
-
Copy full SHA for 9a59601 - Browse repository at this point
Copy the full SHA 9a59601View commit details -
@allow-large-files [i18n] remove unused generated strings.xml files o…
…n master fbshipit-source-id: 8efabef352fa71b3c18c1a8e318d66850fdd5e56
Configuration menu - View commit details
-
Copy full SHA for 944adb7 - Browse repository at this point
Copy the full SHA 944adb7View commit details -
Summary: ericvicenti - Here are necessary updates for the the testing container workflow. normanjoyner Temporarily disabled E2E tests on the Containership Jenkins pipeline because they seemed to be sporadically failing and slow down the run rate of CI tests. * Run all stages and parallel branches in testing suite even if one fails (just mark the overall job as failed) * Added update to docker tag name to convert spaces to hyphens to cover edge case where the project name may have spaces * Updated buck to more recent version in the base image * Remove duplicate module provider from `.flowconfig` * Correctly exit with status code from failed instrumentation tests * Add JSCHeaders to prepare for testing on stage branches * Fix bug in filtering of failed instrumentation tests * Turn down retry count to 1 for E2E tests and temporarily disable * Add retry3 count to the apk install from buck * Updated base image to install android SDKs through grepping since the IDs update frequ Closes facebook#13032 Differential Revision: D4799015 Pulled By: ericvicenti fbshipit-source-id: bbac9303e8ca4fe8be0e8b230a2f863c71c3366c
Configuration menu - View commit details
-
Copy full SHA for 8c7b32d - Browse repository at this point
Copy the full SHA 8c7b32dView commit details -
@allow-large-files @ignore-conflict-markers[i18n] translation auto-up…
…date for i18n/adsmanager.config.json on master fbshipit-source-id: f52efb222ea7385f8d291395b2edef5f28dea713
Configuration menu - View commit details
-
Copy full SHA for b6f1a3b - Browse repository at this point
Copy the full SHA b6f1a3bView commit details -
@allow-large-files @ignore-conflict-markers[i18n] translation auto-up…
…date for i18n/fb4a.config.json on master fbshipit-source-id: e973b0d453b88fc9f6cf54e1fd97ef7780cafe87
Configuration menu - View commit details
-
Copy full SHA for c21760a - Browse repository at this point
Copy the full SHA c21760aView commit details -
@allow-large-files @ignore-conflict-markers[i18n] translation auto-up…
…date for i18n/instagram.config.json on master fbshipit-source-id: 680e36c342abcc80279979ca461eb08449d535bb
Configuration menu - View commit details
-
Copy full SHA for 7f35abb - Browse repository at this point
Copy the full SHA 7f35abbView commit details -
@allow-large-files [i18n] remove unused generated strings.xml files o…
…n master fbshipit-source-id: c3151e7f8c346b1ece67ea37b88110b16e1a9107
Configuration menu - View commit details
-
Copy full SHA for 12de972 - Browse repository at this point
Copy the full SHA 12de972View commit details -
Reviewed By: mhorowitz Differential Revision: D4756318 fbshipit-source-id: 7811f680a7ad044b5ae028ee9b2fed5f46ce2a63
Configuration menu - View commit details
-
Copy full SHA for 5af3038 - Browse repository at this point
Copy the full SHA 5af3038View commit details -
Merge RCTPlatform.isTesting and RCTRunningInTestEnvironment
Reviewed By: fkgozali Differential Revision: D4802834 fbshipit-source-id: 76bb98877f2fc427c01806b192d8dc71489a1c4a
Configuration menu - View commit details
-
Copy full SHA for f675434 - Browse repository at this point
Copy the full SHA f675434View commit details -
Add comma to prevent build error when react.gradle is uncommented
Summary: Thanks for submitting a PR! Please read these instructions carefully: - [ ] Explain the **motivation** for making this change. - [ ] Provide a **test plan** demonstrating that the code is solid. - [ ] Match the **code formatting** of the rest of the codebase. - [ ] Target the `master` branch, NOT a "stable" branch. At the moment, if you uncomment the react specific code in `build.gradle` you'll get a compilation error. Adding a comma prevents this error. No tests are necessary. This is a simple fix. Sign the [CLA][2], if you haven't already. Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. Make sure all **tests pass** on both [Travis][3] and [Circle CI][4]. PRs that break tests are unlikely to be merged. For more info, see the ["Pull Requests"][5] section of our "Contributing" guidelines. [1]: https://medium.com/martink Closes facebook#13212 Differential Revision: D4802065 Pulled By: javache fbshipit-source-id: 0ddfe16241381d7e4ac0e48be1bada21d9df2068
Configuration menu - View commit details
-
Copy full SHA for c31a656 - Browse repository at this point
Copy the full SHA c31a656View commit details -
Add OSS website test, clean up test names, remove website dependency …
…on sass Reviewed By: ericvicenti Differential Revision: D4726864 fbshipit-source-id: 38c13a08d42d11533a02c14a9acd5a05bbce307f
2Configuration menu - View commit details
-
Copy full SHA for e82c2fb - Browse repository at this point
Copy the full SHA e82c2fbView commit details -
Summary: > Explain the **motivation** for making this change. What existing problem does the pull request solve? Of the three dependencies I have that rely on `glob`, react-native is the only one not on 7.x. If react-native can upgrade, then npm can deduplicate the glob dependency. ```console $ npm ls glob ├─┬ [email protected] │ └── [email protected] ├─┬ [email protected] │ └─┬ [email protected] │ └─┬ [email protected] │ ├─┬ [email protected] │ │ └── [email protected] │ ├─┬ [email protected] │ │ └─┬ [email protected] │ │ └── [email protected] │ └─┬ [email protected] │ └─┬ [email protected] │ └── [email protected] └─┬ [email protected] ├── [email protected] └─┬ [email protected] └── [email protected] ``` **Test plan (required)** > Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull req Closes facebook#11893 Differential Revision: D4796721 Pulled By: javache fbshipit-source-id: 6e7424dd731329f982c2f6c05b40dec8febf2e57
Configuration menu - View commit details
-
Copy full SHA for f36664f - Browse repository at this point
Copy the full SHA f36664fView commit details -
Update xcode dependency from 0.8.9 -> 0.9.1
Summary: This should resolve the following npm deprecation warning: ``` WARN deprecated [email protected]: Use uuid module instead ``` Existing tests should cover this already. Closes facebook#13194 Differential Revision: D4796723 Pulled By: javache fbshipit-source-id: 2783f5d04c696b887de2ab2d32805e4661484a83
Configuration menu - View commit details
-
Copy full SHA for 5be8d5f - Browse repository at this point
Copy the full SHA 5be8d5fView commit details -
Reviewed By: achen1 Differential Revision: D4795134 fbshipit-source-id: 70979e3fae6dcd63d535290659c87de82f9617c3
Configuration menu - View commit details
-
Copy full SHA for 7773f25 - Browse repository at this point
Copy the full SHA 7773f25View commit details -
Remove RelayFBPreloadedModules, error on overlapping modules
Reviewed By: davidaurelio Differential Revision: D4779671 fbshipit-source-id: f2dfeb696baab457769c22ca7ab28972270e5fc0
Configuration menu - View commit details
-
Copy full SHA for 7db16a4 - Browse repository at this point
Copy the full SHA 7db16a4View commit details
Commits on Mar 31, 2017
-
Show more meaningful error stack in ReactNative redbox
Reviewed By: yungsters Differential Revision: D4797372 fbshipit-source-id: 069c013bcc3d58dd38a25979f4a04aed5fc1dde6
Configuration menu - View commit details
-
Copy full SHA for d4aa42a - Browse repository at this point
Copy the full SHA d4aa42aView commit details -
Add support for custom log reporter cli option for local server
Summary: In Expo tools such as XDE, exp we listen listen to stdout from the packager process and print it in our own buffer. In the case of XDE, an electron app, our log pane is DOM-based, and before printing each log chunk we need to remove special tty characters and sometimes parse it to get information that we need (eg: progress bar). By using a custom reporter, we can take the raw events and pass them along in a format that is easy to consume by XDE and exp. This same motivation applies to create-react-native-app, where we currently don't show a progress bar in the terminal, but we can with this change. Create `LogReporter.js` in the root of a project with the CLI changes included in this PR. ``` class LogReporter { update(event) { console.log(JSON.stringify(event)); } } module.exports = LogReporter; ``` Now, run `react-native start --customLogReporterPath=LogReporter.js` -- all of the raw events will be output as JSON (while the logs Closes facebook#13172 Differential Revision: D4795760 Pulled By: hramos fbshipit-source-id: 80164b2f30e33a3f9965f4865a8404f8640a52c1
Configuration menu - View commit details
-
Copy full SHA for 5f5da4e - Browse repository at this point
Copy the full SHA 5f5da4eView commit details -
Support narrower module dependencies
Reviewed By: javache Differential Revision: D4772632 fbshipit-source-id: 615bf8998a3817364d0f8bd435c95c2c1f1bebed
Configuration menu - View commit details
-
Copy full SHA for 0b2ac0a - Browse repository at this point
Copy the full SHA 0b2ac0aView commit details -
Support passing a collection of native modules to JSContext
Reviewed By: javache Differential Revision: D4772649 fbshipit-source-id: dd9353edb0c2c013a3b7fe772231db12cdd8cdae
Configuration menu - View commit details
-
Copy full SHA for 1916b38 - Browse repository at this point
Copy the full SHA 1916b38View commit details -
Allow DeviceInfoModule to be instantiated with only an android Context
Reviewed By: javache Differential Revision: D4772673 fbshipit-source-id: 80894faa076ccfddf0fe28bd4d7b6aaeba6c38a5
Configuration menu - View commit details
-
Copy full SHA for ec4b854 - Browse repository at this point
Copy the full SHA ec4b854View commit details -
Move packager initialization events to reporter
Summary: This PR depends on facebook#13172 Packager events are mostly logged through the TerminalReporter by default (facebook#13172 makes this configurable). But there are a few things that aren't passed through TerminalReporter. - We [log a banner with some information about the port and what's going on](https://github.com/facebook/react-native/blob/8c7b32d5f1da34613628b4b8e0474bc1e185a618/local-cli/server/server.js#L22-L32) - Also [a message about looking for JS files](https://github.com/facebook/react-native/blob/8c7b32d5f1da34613628b4b8e0474bc1e185a618/local-cli/server/server.js#L34-L38) (not sure what that is for / if it is useful beyond telling the user what directory root they started the packager in, but that's another thing). - If the packager fails to start, then [we log an error message](https://github.com/facebook/react-native/blob/8c7b32d5f1da34613628b4b8e0474bc1e185a618/local-cli/server/server.js#L41-L61). This pull request changes those log messages to be handled by TerminalReporter. I tri Closes facebook#13209 Differential Revision: D4809759 Pulled By: davidaurelio fbshipit-source-id: 2c427ec0c1accaf54bf6b2d1da882cd6bfaa7829
Configuration menu - View commit details
-
Copy full SHA for b80e2c8 - Browse repository at this point
Copy the full SHA b80e2c8View commit details -
Make SystraceRequestListener extend BaseRequestListener
Summary: Instead of `SystraceRequestListener` implementing `RequestListener`, this diff instead extends the base implementation. Reviewed By: massimocarli Differential Revision: D4796679 fbshipit-source-id: 0c9a0b755f4beff69007688962682989e5af72e0
Configuration menu - View commit details
-
Copy full SHA for 01a0e10 - Browse repository at this point
Copy the full SHA 01a0e10View commit details -
match plist indentation with xcode format
Summary: xcode has its own way of indentation of the plist. fixes facebook#11668 Closes facebook#11670 Differential Revision: D4410865 fbshipit-source-id: 8c65e7719d228b07f58b1ccb86b369e319067f02
Configuration menu - View commit details
-
Copy full SHA for 8daf985 - Browse repository at this point
Copy the full SHA 8daf985View commit details -
Move bindKeys to RCTBridge setUp
Reviewed By: shergin Differential Revision: D4794788 fbshipit-source-id: 0839829f4ed010bf2fb2574092a8f68f4c95341a
Configuration menu - View commit details
-
Copy full SHA for e12e57e - Browse repository at this point
Copy the full SHA e12e57eView commit details -
Disable flaky PropertiesUpdateTest
Reviewed By: AaaChiuuu Differential Revision: D4810246 fbshipit-source-id: 76b38522eea9332217b515b7ff225c0073381da9
Configuration menu - View commit details
-
Copy full SHA for b133d06 - Browse repository at this point
Copy the full SHA b133d06View commit details -
Summary: Remove redundant `\`` mark Thanks for submitting a PR! Please read these instructions carefully: - [x] Explain the **motivation** for making this change. - [x] Provide a **test plan** demonstrating that the code is solid. - [x] Match the **code formatting** of the rest of the codebase. - [x] Target the `master` branch, NOT a "stable" branch. This PR fixes Documentation typo. No need for test. Closes facebook#13228 Differential Revision: D4810457 Pulled By: hramos fbshipit-source-id: 5c475a5d8b51d4a926e0fc737e2a12805e3bf70b
Configuration menu - View commit details
-
Copy full SHA for 8e925d5 - Browse repository at this point
Copy the full SHA 8e925d5View commit details -
Temporarily disable Android instrumentation tests
Summary: Android instrumentation tests keep failing due to `java.lang.RuntimeException: java.lang.RuntimeException: Timed out waiting for JS thread`. An [earlier job](https://circleci.com/gh/facebook/react-native/17064) based off commit [c31a65](facebook@c31a656) finished successfully, yet [this job](https://circleci.com/gh/facebook/react-native/17070), triggered by the very [next commit](facebook@e82c2fb), failed Android instrumentation tests even though that commit touches no Android code. You can see from the [Circle history](https://circleci.com/gh/facebook/react-native/tree/master) that this test has been consistently failing for the same time out reason. I am disabling Android instrumentation tests as they are not providing any useful signal a this point in time. Debug and fix instrumentation tests, and re-enable them. Closes facebook#13239 Differential Revision: D4810775 Pulled By: hramos fbshipit-source-id: 8866f9208ec3b5ac5f0ed2f6c2cf58c5b5825830
Configuration menu - View commit details
-
Copy full SHA for 7664c27 - Browse repository at this point
Copy the full SHA 7664c27View commit details -
Reviewed By: davidaurelio Differential Revision: D4802783 fbshipit-source-id: c6309bcae6ad48bea2350de04353f694be6eea2f
Configuration menu - View commit details
-
Copy full SHA for 3ef2055 - Browse repository at this point
Copy the full SHA 3ef2055View commit details -
Add iOS Linking location example to docs
Summary: Hi, the docs make it seem like `geo:${latitude},${longitude}` is the cross-platform way to link locations on Google/Apple Maps. This is Android-only though. I did no changes to code. I noticed that the Appetize.io embed tries to run the [Linking example](https://facebook.github.io/react-native/docs/linking.html) code on iOS, although the example uses Android location scheme. This results in errors. I'd like to fix this as well, but I have no idea how to tell the demo to run on Android. Closes facebook#13220 Differential Revision: D4804123 Pulled By: hramos fbshipit-source-id: 2de85d56476933ec54ea423d76a0fe98ed5132d3
Configuration menu - View commit details
-
Copy full SHA for ec68c97 - Browse repository at this point
Copy the full SHA ec68c97View commit details -
break dependency between JSPackagerClient.RequestHandler and WebSocke…
…tListener Reviewed By: amnn Differential Revision: D4810406 fbshipit-source-id: a447bc15c6619921edd7adf0b3d1d93ae04e2e43
Configuration menu - View commit details
-
Copy full SHA for 175e77d - Browse repository at this point
Copy the full SHA 175e77dView commit details -
Clean up and remove duplicate code in Travis iOS/tvOS test scripts
Summary: **Motivation** Remove duplicated lines in objc-test-ios.sh and objc-test-tvos.sh **Test plan** Travis CI should continue to work as before. Closes facebook#13173 Differential Revision: D4812177 Pulled By: hramos fbshipit-source-id: 40afe0beab896d741f607f4841df7e9b42f4c17d
Configuration menu - View commit details
-
Copy full SHA for 9219072 - Browse repository at this point
Copy the full SHA 9219072View commit details -
Fix crash in
RCTJSStackFrame::stackFrameWithDictionary:
Summary: Motivation: When logging to RCTRedBox, if any of the stack frames lacks a line number or a column, the application will crash with `[NSNull integerValue]: unrecognized selector sent to instance`. Closes facebook#13242 Differential Revision: D4812185 Pulled By: hramos fbshipit-source-id: 4b1c3c38f67cf59034a383c95d4280d1b6380300
Configuration menu - View commit details
-
Copy full SHA for 9075fe0 - Browse repository at this point
Copy the full SHA 9075fe0View commit details
Commits on Apr 1, 2017
-
Fix Warning/Yellow Box so it does not mess up app layout when opened.
Reviewed By: fkgozali Differential Revision: D4808601 fbshipit-source-id: c15a7aa4514ea21798ceabca075189478596e0a2
Configuration menu - View commit details
-
Copy full SHA for 7ff18f2 - Browse repository at this point
Copy the full SHA 7ff18f2View commit details -
Replacing all instances of [UIApplication sharedApplication] wi…
Summary: …th RCTSharedApplication() Thanks for submitting a PR! Please read these instructions carefully: - [ ] Explain the **motivation** for making this change. Using React Native latest version with Cocoapods 1.2.0 causes the following error inside iOS app extensions > /react-native/React/Modules/RCTAccessibilityManager.m:67:70: ‘sharedApplication’ is unavailable: not available on iOS (App Extension) — Use view controller based solutions where appropriate instead. Moving the use of [UIApplication sharedApplication] to RCTSharedApplication() which is safe on app extension - [ ] Provide a **test plan** demonstrating that the code is solid. I am not sure how to test such that all the features which touch the modified code are tested. - [ ] Match the **code formatting** of the rest of the codebase. - [ ] Target the `master` branch, NOT a "stable" branch. What existing problem does the pull request solve? Using React Native latest v Closes facebook#13227 Differential Revision: D4816338 Pulled By: javache fbshipit-source-id: e3e3c77882990ad1817b0b633521cff52571ecd0
Configuration menu - View commit details
-
Copy full SHA for edbb48c - Browse repository at this point
Copy the full SHA edbb48cView commit details -
Don't transfer layout outputs to java for unset edges
Summary: See facebook/yoga#483. We should not transfer the layout if the layout didn't change. (using ```hasNewLayout```). This also changes that the lock on the java node is only aquired if needed, and it holds the lock only for the time the values are set and not for the time all it's children are set. Closes facebook/yoga#484 Reviewed By: astreet Differential Revision: D4802966 Pulled By: emilsjolander fbshipit-source-id: e8a8f2280ad6b25b98fc68b07eac68e0ec80fe3e
Configuration menu - View commit details
-
Copy full SHA for f1371ec - Browse repository at this point
Copy the full SHA f1371ecView commit details
Commits on Apr 2, 2017
-
RN: Options to Preload Bundles on Startup
Reviewed By: achen1 Differential Revision: D4809513 fbshipit-source-id: a9a4196b72b241faf7c788e26b9e6880cecebb3e
5Configuration menu - View commit details
-
Copy full SHA for e1466da - Browse repository at this point
Copy the full SHA e1466daView commit details
Commits on Apr 3, 2017
-
packager: TransformCache: do not rehash transformOptions every single…
… time Reviewed By: davidaurelio Differential Revision: D4809963 fbshipit-source-id: 9d3ac907e822596567ee7af4427bcd24f1bac73f
Configuration menu - View commit details
-
Copy full SHA for 4bd7dc0 - Browse repository at this point
Copy the full SHA 4bd7dc0View commit details -
packager: TransformCache: use sha1 instead of murmurhash
Reviewed By: davidaurelio Differential Revision: D4809941 fbshipit-source-id: 33b6c56b4c48eca88d8c1922f52ed29a728d1173
Configuration menu - View commit details
-
Copy full SHA for cc2ec6f - Browse repository at this point
Copy the full SHA cc2ec6fView commit details -
Make CLI executable configurable
Summary: Follow up to facebook#13248 for iOS. This pull request allows changing the default path to `cli` when running from Xcode environment. That is especially useful when debugging from a different location or... running `Haul`. Set `export CLI_PATH=./node_modules/react-native/local-cli/cli.js` and run. Should use new path provided. Closes facebook#13264 Differential Revision: D4819059 Pulled By: ericvicenti fbshipit-source-id: 4a6241823c0bc8f1fa16869bc872bdbe04df510f
Configuration menu - View commit details
-
Copy full SHA for dcecfa3 - Browse repository at this point
Copy the full SHA dcecfa3View commit details -
Reviewed By: jeanlauliac Differential Revision: D4819078 fbshipit-source-id: 76bdc2381e479396ef11144236817ffd590f1039
Configuration menu - View commit details
-
Copy full SHA for b4da59e - Browse repository at this point
Copy the full SHA b4da59eView commit details -
Summary: Support [the pre-release of Atom](https://github.com/atom/atom/releases/tag/v1.16.0-beta0) for launchEditor in RN packager. Open the pre-release of Atom and use the following code: (use the built-in [openFileInEditor](https://github.com/facebook/react-native/blob/292cc82d0ebc437a6f1cdd2e972b3917b7ee05a4/Libraries/Core/Devtools/openFileInEditor.js) module) ```js import openFileInEditor from 'openFileInEditor' openFileInEditor(file, lineNumber) ``` Closes facebook#13255 Differential Revision: D4819130 Pulled By: ericvicenti fbshipit-source-id: eb542295ee9489dad0fe9084e51c4141d33f1fbf
Configuration menu - View commit details
-
Copy full SHA for d38644e - Browse repository at this point
Copy the full SHA d38644eView commit details -
Fixes "guesture" typo in PanResponser docs
Summary: Simple typo fix in docs. Closes facebook#13247 Differential Revision: D4819135 Pulled By: ericvicenti fbshipit-source-id: 64bc597133a31276fdff8f1ef2ee061f2a9bb17d
Configuration menu - View commit details
-
Copy full SHA for dfaa03e - Browse repository at this point
Copy the full SHA dfaa03eView commit details -
Optimize log print by using html format
Summary: See facebook/yoga#453. Optimizes the node log print by generating some enum text via ```enum.py``` and moving printing to new functions to reduce boilerplate code. Changes the log output to format the nodes in html to be able to copy paste it into browsers for quick debugging. Hides all default values. Closes facebook/yoga#479 Reviewed By: gkassabli Differential Revision: D4802184 Pulled By: emilsjolander fbshipit-source-id: 143bd63cbc31fb0755d711062cb4e6a448049ba3
Configuration menu - View commit details
-
Copy full SHA for 0ec984e - Browse repository at this point
Copy the full SHA 0ec984eView commit details -
Adapt interface of node-haste duplicates
Summary: Adapts mocked / duplicated functionality from `node-haste` to match the new synchronous return types in the original. Reviewed By: jeanlauliac Differential Revision: D4819137 fbshipit-source-id: 183316adc3fae161ad9999bf72bccb8218ef8941
Configuration menu - View commit details
-
Copy full SHA for a51e9a0 - Browse repository at this point
Copy the full SHA a51e9a0View commit details -
Disable all of RCTRootViewIntegrationTests
Reviewed By: fkgozali Differential Revision: D4819589 fbshipit-source-id: d23f1892d750ae4e4efaf85a9ec25094009a7a22
Configuration menu - View commit details
-
Copy full SHA for 10cb0f9 - Browse repository at this point
Copy the full SHA 10cb0f9View commit details -
Code analysis bot does not need to comment on merge commits
Summary: This PR fixes a CI issue that came up on facebook#11304 after merging master into the pr branch. That created a merge commit with over 1000 changed files. That might have created irrelevant comments, but the github commit api is limited to 300 files, with only the first 294 having the expected diffs included. I can't think of any reasonable scenario where a merge would have changes that aren't either on master or another commit in the PR, so I've updated it to treat merge commits as having no changes. Closes facebook#13260 Differential Revision: D4819805 Pulled By: ericvicenti fbshipit-source-id: 7b6b51b18bb36503a719a3ba5c9163cd6ef00e17
Configuration menu - View commit details
-
Copy full SHA for 8a760e0 - Browse repository at this point
Copy the full SHA 8a760e0View commit details -
Reviewed By: ericvicenti Differential Revision: D4821749 fbshipit-source-id: 19730209557c58457e6cc67916e9a8cb944fb963
Configuration menu - View commit details
-
Copy full SHA for beb559d - Browse repository at this point
Copy the full SHA beb559dView commit details -
Better TextInput: Simplified focus/first-responder management on iOS
Summary: Pair `reactWillMakeFirstResponder` and `reactDidMakeFirstResponder` was replaced with just `reactFocus` method which is supposed to incapsulate all "focus" and "focus-later-if-needed" functionality. Reviewed By: mmmulani Differential Revision: D4664626 fbshipit-source-id: 8d3b7935ca26d32ba1d1826a585cce0396fcc885
Configuration menu - View commit details
-
Copy full SHA for bc1ea54 - Browse repository at this point
Copy the full SHA bc1ea54View commit details
Commits on Apr 4, 2017
-
Allow override of
scrollEventThrottle
(in caseuseNativeDriver
is…… not an option) Reviewed By: achen1 Differential Revision: D4819635 fbshipit-source-id: 9cc7b32e05bf2c573553b9806a17141f1783a1c6
Configuration menu - View commit details
-
Copy full SHA for f186cfb - Browse repository at this point
Copy the full SHA f186cfbView commit details -
Fix separator keys for LayoutAnimation
Summary: Should key separators with their cells. **Test Plan** before/after in this video: https://youtu.be/vid1w5x8-58 Reviewed By: achen1 Differential Revision: D4821708 fbshipit-source-id: 261f1bac34dfa9001297a24a44f11128f338e62b
Configuration menu - View commit details
-
Copy full SHA for e8f9c44 - Browse repository at this point
Copy the full SHA e8f9c44View commit details -
Fixup comments to indicate sticky headers are now supported
Reviewed By: achen1 Differential Revision: D4822080 fbshipit-source-id: a0f09eedca40ccc72581b7f6e55a09d9e8f3f61f
Configuration menu - View commit details
-
Copy full SHA for 128596b - Browse repository at this point
Copy the full SHA 128596bView commit details -
propagate getScrollResponder, getScrollableNode
Summary: so users can call `setNativeProps` and do more compositing. **Test Plan:** Added this to `onPress` of `SectionListExample` and `FlatListExample`: this._listRef.getNode().getScrollResponder().setNativeProps({scrollEnabled: false}); and saw scroll get disabled. Note the call to `getNode` because we are using the `Animated.createComponent` wrapper. Reviewed By: achen1, bvaughn Differential Revision: D4821711 fbshipit-source-id: 8d1f3dd7ccc646524f154721c5c7036620d57132
Configuration menu - View commit details
-
Copy full SHA for 87bdcbd - Browse repository at this point
Copy the full SHA 87bdcbdView commit details -
Add
scrollToLocation
forSectionList
Summary: Basic functionality that takes `itemIndex` and `sectionIndex` **TestPlan** Added this to onChangeText: this._listRef.getNode().scrollToLocation({itemIndex: 6, sectionIndex: 3, viewOffset: 25}); and saw it scroll to the correct position right under the sticky header. Reviewed By: bvaughn Differential Revision: D4821714 fbshipit-source-id: 261e373f9c4af384db5a363df5b0fd9274b1bdfe
Configuration menu - View commit details
-
Copy full SHA for ecf4c48 - Browse repository at this point
Copy the full SHA ecf4c48View commit details -
Fix order of timers called in the same frame
Reviewed By: mmmulani Differential Revision: D4802858 fbshipit-source-id: 8d8400c20b7e487aea5a0943f91ac7adc2d23108
Configuration menu - View commit details
-
Copy full SHA for e0bd35f - Browse repository at this point
Copy the full SHA e0bd35fView commit details -
fix crash with onEndReached={null}
Reviewed By: bvaughn Differential Revision: D4815310 fbshipit-source-id: 69d4a5a6fd247bdf877465a7cd07924a0dd6584b
Configuration menu - View commit details
-
Copy full SHA for b12f6db - Browse repository at this point
Copy the full SHA b12f6dbView commit details -
packager: GlobalTransformCache: retry 502 and 503 HTTP statuses
Reviewed By: davidaurelio Differential Revision: D4818997 fbshipit-source-id: b31b004939f9e83c8a3a8c34b07c8b1ae2d4d17e
Configuration menu - View commit details
-
Copy full SHA for 03892d1 - Browse repository at this point
Copy the full SHA 03892d1View commit details -
packager: get rid of type
any
in ResolutionRequestSummary: One of my changeset broke the "ModuleGraph" code without warning earlier because we are using `any`, that equivalent to having no typing at all. This changeset fixes the types so that `ResolutionRequest` is exactly what it actually is: a class usable for any `Module`-looking class, including the normal one, and the "ModuleGraph" one used for Buck builds. That way, the ModuleGraph's `Module` is typechecked against `Moduleish`. Concretely this change mostly migrates the `Module` to its generic parameter counterpart `TModule` inside `ResolutionRequest`. Reviewed By: kentaromiura Differential Revision: D4826256 fbshipit-source-id: fcd7ca08ac6c35e4e9ca983e2aab260e352bcb4e
Configuration menu - View commit details
-
Copy full SHA for 8755338 - Browse repository at this point
Copy the full SHA 8755338View commit details -
Make clear that onSlidingComplete is called regardless whether value …
…changes Summary: Documentation didn't clearly state when onSlidingComplete callback is called. No tests necessary… simply changing docs. Closes facebook#13282 Differential Revision: D4823866 Pulled By: ericvicenti fbshipit-source-id: 1c3be6ee4d52b097b7558067edf0388739d3f52e
Configuration menu - View commit details
-
Copy full SHA for e91cd2e - Browse repository at this point
Copy the full SHA e91cd2eView commit details -
Summary: **Motivation** Fix the Apple TV build, which is broken after a recent commit. **Test plan** Travis tvOS test script should succeed. Closes facebook#13284 Differential Revision: D4827053 Pulled By: ericvicenti fbshipit-source-id: 380e8f1b32adfeea844bedc11326e5a6a755066a
Configuration menu - View commit details
-
Copy full SHA for 6a81de3 - Browse repository at this point
Copy the full SHA 6a81de3View commit details -
Add UberEATS article to showcase
Summary: Adds UberEATS technical blog post, https://eng.uber.com/ubereats-react-native/, to the showcase. This is not an ideal entry, as the app in question, the UberEATS Restaurant Dashboard, is not widely available in the app stores for people to download and try out. I still think it's worth adding this to the showcase as a good example of a large, known company leveraging React Native to build a new experience. Test Plan ======= Built website and verified everything rendered correctly in the Showcase. Closes facebook#13274 Differential Revision: D4823507 Pulled By: ericvicenti fbshipit-source-id: 7929124dfc17254d1bc5970a20ba393a54e34409
1Configuration menu - View commit details
-
Copy full SHA for 058a540 - Browse repository at this point
Copy the full SHA 058a540View commit details -
Make copy button work on android emulator in Linux using xsel
Summary: Resolves issue [facebook#13165](facebook#13165). The copy button in the redbox for RN android is not currently supported for Linux. This pull request provides the copy button functionality to Linux RN users. I have tested the updated code locally. Firstly, I edited `index.android.js` that caused the following error. ![pasted image at 2017_03_27 10_21 am](https://cloud.githubusercontent.com/assets/22376429/24426834/f567c5dc-13d6-11e7-8e3b-a650e2f6237c.png) After I clicked the copy button and pasted from the clipboard into the chrome address bar, the message appeared. ![pasted_image_at_2017_03_27_10_21_am](https://cloud.githubusercontent.com/assets/22376429/24426896/2c0d4d64-13d7-11e7-8650-da19c44b177d.png) Closes facebook#13188 Differential Revision: D4819796 Pulled By: ericvicenti fbshipit-source-id: 9adc6e93330f89240a505a403e4913dc10e5a31f
Configuration menu - View commit details
-
Copy full SHA for 0fe0fc0 - Browse repository at this point
Copy the full SHA 0fe0fc0View commit details -
A proxy so a singleton CxxModule can be shared by multiple ModuleRegi…
…stry instances. Reviewed By: mhorowitz Differential Revision: D4814438 fbshipit-source-id: db6cdd9e948643bb24a443bd45b7b0843a0a86c2
Configuration menu - View commit details
-
Copy full SHA for c128612 - Browse repository at this point
Copy the full SHA c128612View commit details -
Add YGEnums to fix gradle build
Summary: Attempt to fix CircleCI build by adding YGEnums to the yoga gradle file Closes facebook#13296 Differential Revision: D4827856 Pulled By: ericvicenti fbshipit-source-id: cb03af77919c811d06352fbe0b77084e97d2e6c1
Configuration menu - View commit details
-
Copy full SHA for 67e54f8 - Browse repository at this point
Copy the full SHA 67e54f8View commit details -
Summary: View tags are currently used for end-to-end test IDs. We'd like to overload the tag field with other information such as nativeID (for native refs) and transitionID (for shared element transitions) in the future. Added a key for testID's tag Reviewed By: AaaChiuuu Differential Revision: D4770368 fbshipit-source-id: b76c53a20520aac1b25d435b6d5eb809e8833675
1Configuration menu - View commit details
-
Copy full SHA for 77c19cc - Browse repository at this point
Copy the full SHA 77c19ccView commit details -
Minor adjustments to the mobile site
Summary: I noticed the mobile website did not look as great, specifically the hero and the showcase had some issues. Before: ![screen shot 2017-04-04 at 11 08 41 am](https://cloud.githubusercontent.com/assets/165856/24671655/2fb45660-1927-11e7-8ee7-bf933f459550.png) ![screen shot 2017-04-04 at 11 08 48 am](https://cloud.githubusercontent.com/assets/165856/24671656/2fb44bc0-1927-11e7-9b2e-eb944e61d778.png) After: ![screen shot 2017-04-04 at 11 08 54 am](https://cloud.githubusercontent.com/assets/165856/24671666/36de3942-1927-11e7-81ff-eeda74d8e748.png) ![screen shot 2017-04-04 at 11 08 59 am](https://cloud.githubusercontent.com/assets/165856/24671665/36d0be70-1927-11e7-9035-382a0a09b701.png) Closes facebook#13298 Differential Revision: D4828679 Pulled By: hramos fbshipit-source-id: 478ab1c5eefa5292cb2f99a9a91e18d86b3e6192
Configuration menu - View commit details
-
Copy full SHA for 40eb353 - Browse repository at this point
Copy the full SHA 40eb353View commit details -
clean out the last used bitmap
Reviewed By: achen1 Differential Revision: D4828134 fbshipit-source-id: bf54f7c9f61016cc0735338f99de7b0378c1234b
Configuration menu - View commit details
-
Copy full SHA for f8e583b - Browse repository at this point
Copy the full SHA f8e583bView commit details -
Summary: This fixes the website build because docgen was unable to parse this `*` Closes facebook#13300 Differential Revision: D4828837 Pulled By: ericvicenti fbshipit-source-id: 7ebc04241742f7bb5a871e7e438fb23af90a70bd
Configuration menu - View commit details
-
Copy full SHA for 9c5cc14 - Browse repository at this point
Copy the full SHA 9c5cc14View commit details -
use Log.d instead of Log.w in CatalystInstanceImpl.java
Reviewed By: achen1 Differential Revision: D4829620 fbshipit-source-id: d3648b7b9afdaec30790995e59abe23805fb6b1e
Configuration menu - View commit details
-
Copy full SHA for c0b64ce - Browse repository at this point
Copy the full SHA c0b64ceView commit details -
Revert D4770368: [rn] Use tag ids for testID
Differential Revision: D4770368 fbshipit-source-id: 4bf8131a2a2974c8db072f62e8fb26686faa100d
Configuration menu - View commit details
-
Copy full SHA for eb300b6 - Browse repository at this point
Copy the full SHA eb300b6View commit details -
Fix YGEnums references in ReactCxx.xcodeproj
Summary: cc ericvicenti Closes facebook#13301 Differential Revision: D4830381 Pulled By: ericvicenti fbshipit-source-id: 866864ac34f6c873c1646e59cd0245b3f6634d7e
Configuration menu - View commit details
-
Copy full SHA for ff95805 - Browse repository at this point
Copy the full SHA ff95805View commit details -
Allow specifying an appIdSuffix to run-android
Summary: Motivation Currently react-native run-android instals and starts your app, but if you have more than one variant, it doesn't know which one to start. This allows developers to pass in the suffix specified in build.gradle, so that the correct app is started. Test Plan verify that `react-native run-android` runs properly verify that `react-native run-android --appIdSuffix validSuffix` runs properly Closes facebook#13169 Differential Revision: D4823391 Pulled By: ericvicenti fbshipit-source-id: 31ed35fd79403804b4781e81eb49f1c4627d7f8e
Configuration menu - View commit details
-
Copy full SHA for d8f23f7 - Browse repository at this point
Copy the full SHA d8f23f7View commit details
Commits on Apr 5, 2017
-
ReactNativeFiber renderer type-fix for leaf node children
Reviewed By: sebmarkbage Differential Revision: D4830872 fbshipit-source-id: 6e1a476c921ffff8f720fd9b81da65cb1e724eef
Configuration menu - View commit details
-
Copy full SHA for 36c599b - Browse repository at this point
Copy the full SHA 36c599bView commit details -
Update issue template for Sketch -> Snack rename
Summary: [We changed the name from Sketch to Snack](https://blog.expo.io/expo-sketch-expo-snack-a444f8dec72b) It's just some text in the issue template :) - Make it clear on the Snack website which version of react-native you are using. Right now we make it possible to pick SDK versions but it's not at all obvious which react-native version that maps to. Closes facebook#13304 Differential Revision: D4833399 Pulled By: ericvicenti fbshipit-source-id: 25b1fe8b4b1ac7db6737e1ba8f611ad4d8dc3804
Configuration menu - View commit details
-
Copy full SHA for b31704b - Browse repository at this point
Copy the full SHA b31704bView commit details -
facebook#11587 invoke error for getCurrentLocation
Summary: It started with facebook#11587, which reported that the error returned by `getCurrentLocation` did not match the spec. This resulted in PR facebook#11723, which did not get merged because it was said by ide and mkonicek that simply emitting the error will cause it to hang since the `error` callback was never invoked. However, it seems like somewhere along the way PR facebook#13140 got merged in which did exactly that. Since it now matches the spec, turning off location services on Android then running the below example code from [Geolocation](https://developer.mozilla.org/en-US/docs/Web/API/Geolocation/getCurrentPosition) docs errors out correctly. ```javascript var options = { enableHighAccuracy: true, timeout: 5000, maximumAge: 0 }; function success(pos) { var crd = pos.coords; console.log('Your current po Closes facebook#13306 Differential Revision: D4833377 Pulled By: ericvicenti fbshipit-source-id: dbea5948790a3f521751a0cc0a25f0e323b30667
Configuration menu - View commit details
-
Copy full SHA for 2b0282a - Browse repository at this point
Copy the full SHA 2b0282aView commit details -
Add comment about adding new resource directories
Reviewed By: ericvicenti Differential Revision: D4833151 fbshipit-source-id: 64ad77e7c4d277f19d1c545dc1d75ab870ddd49e
Configuration menu - View commit details
-
Copy full SHA for 0ec9c93 - Browse repository at this point
Copy the full SHA 0ec9c93View commit details -
Refactor CxxModuleWrapper to support different use cases
Reviewed By: javache Differential Revision: D4807680 fbshipit-source-id: 48eccfb382814a0c4082f56617e0359e61345da7
Configuration menu - View commit details
-
Copy full SHA for a893d0b - Browse repository at this point
Copy the full SHA a893d0bView commit details -
Remove the dependency of I18nManagerModule on ReactApplicationContext
Reviewed By: javache Differential Revision: D4809492 fbshipit-source-id: 775c6b95aab734568ea4750804477c04d13502b6
Configuration menu - View commit details
-
Copy full SHA for af533ac - Browse repository at this point
Copy the full SHA af533acView commit details -
Improve z-index implementation on Android
Summary: Use `getChildDrawingOrder` instead of reordering views. The old implementation didn't work properly when `removeClippedSubviews` was enabled and this one should have better performance since we don't play with the view hierarchy at all. This fixes weird bugs with sticky headers in `SectionList` and allows removing the hack that disabled `removeClippedSubviews` when using sticky section headers. **Test plan** Tested using the SectionList and ListViewPaging examples that use sticky headers which uses z-index. Closes facebook#13105 Reviewed By: sahrens Differential Revision: D4765869 Pulled By: achen1 fbshipit-source-id: be3c824658a3ce965b6e7324ad95c77cbd8a86ae
3Configuration menu - View commit details
-
Copy full SHA for 9a51fa8 - Browse repository at this point
Copy the full SHA 9a51fa8View commit details -
Enable flow in react-native-implementation
Summary: I noticed I didn't get type defs anymore for react-native. Looks like it is broken since we removed the .flow file in facebook@3e153b2. To fix it we can now enable flow in react-native-implementation since it now supports properties. **Test plan** Tested that I get type hints when using imports from react-native in a project. Closes facebook#12917 Differential Revision: D4704753 Pulled By: ericvicenti fbshipit-source-id: cf882588d7f371931de8d7861a1a6d50f6c425dc
Configuration menu - View commit details
-
Copy full SHA for c7387fe - Browse repository at this point
Copy the full SHA c7387feView commit details -
Update docs to clarify
RCT_REMAP_METHOD
usage.Summary: The current docs (iOS) for promises make use of the `RCT_REMAP_METHOD` macro but it's not clear about the proper usage for the macro. Specifically, it points to a selector of `resolver:rejector:` and makes it seem like `findEvents` is assumed as both the alias and method name. This has led to some confusion (facebook#9070) on how to use `RCT_REMAP_METHOD`. No tests needed since this is just a small docs update. Closes facebook#13302 Differential Revision: D4831755 Pulled By: javache fbshipit-source-id: e842c16ade27088eafdac7509373cdf7780f9ece
Configuration menu - View commit details
-
Copy full SHA for 269458c - Browse repository at this point
Copy the full SHA 269458cView commit details -
Update IntegrationWithExistingApps.md
Summary: Closes facebook#13327 Differential Revision: D4836472 Pulled By: javache fbshipit-source-id: 377512f8a422c40fc02a3259bccb097c38357c19
Configuration menu - View commit details
-
Copy full SHA for da43c29 - Browse repository at this point
Copy the full SHA da43c29View commit details -
Summary: View tags are currently used for end-to-end test IDs. We'd like to overload the tag field with other information such as nativeID (for native refs) and transitionID (for shared element transitions) in the future. Added a key for testID's tag Reviewed By: AaaChiuuu Differential Revision: D4833045 fbshipit-source-id: c2f9371c9a3dbb2411e114f4f096f723ac3132c0
Configuration menu - View commit details
-
Copy full SHA for 3bf367c - Browse repository at this point
Copy the full SHA 3bf367cView commit details -
configurable devEnabled in React.gradle
Summary: This PR adds support for configurable devEnabled option when building an android app. This is currently hardcoded. The reason for making this configurable is this: I have an app that uses code-push and 3 buildConfigs. I want to have a debugging version which has `devEnabled = true`, then a staging version which has `devEnabled = false` (this version of the app is used internally for testing and should behave just like a release version of the app, and when the tests succeed the changes are promoted into the release version to the users out there, using code-push). The last version is a standard release version with `devEnabled = false`. Currently, `devEnabled` is hardwired like this: `!targetName.toLowerCase().contains("release")` so by default my `staging` buildConfig will have `devEnabled = true` but I'd like it to be false. With this PR it'd be possible to configure this as follows, while not breaking the current behavior. `'devDisabledIn${productFlavor}${buildType}'` `'devDisabledIn${buildType Closes facebook#11438 Differential Revision: D4630513 Pulled By: hramos fbshipit-source-id: b6817cf4c144fc948f76785e9cb5f93a13a6a6a2
1Configuration menu - View commit details
-
Copy full SHA for cd4545f - Browse repository at this point
Copy the full SHA cd4545fView commit details -
Summary: What existing problem does the pull request solve? According to this issue: facebook#3468 , only `keyboardDidShow`and `keyboardDidHide` events are available on android at this moment. I think this information should be displayed in the documentation since default `android:windowSoftInputMode` is `adjustResize`. Closes facebook#13155 Differential Revision: D4795828 Pulled By: hramos fbshipit-source-id: 2c114f3040808a5cc3cdeb29b2067877df353620
Configuration menu - View commit details
-
Copy full SHA for d69c85f - Browse repository at this point
Copy the full SHA d69c85fView commit details -
Removed some no-longer-necessary Flow ignores.
Reviewed By: spicyj Differential Revision: D4836708 fbshipit-source-id: 8e9da5a1f723651b1d6ade60fecdb7801662abfe
Configuration menu - View commit details
-
Copy full SHA for d18513b - Browse repository at this point
Copy the full SHA d18513bView commit details
Commits on Apr 6, 2017
-
Reviewed By: zertosh Differential Revision: D4835081 fbshipit-source-id: a9ab33648320fb19b8cc7ab212e68fada7810b90
Configuration menu - View commit details
-
Copy full SHA for 4f243f1 - Browse repository at this point
Copy the full SHA 4f243f1View commit details -
use performanceNow instead of Date.now() in ScrollResponder
Reviewed By: shergin Differential Revision: D4833701 fbshipit-source-id: cb127cb6c40ecb188100eeb204412401c7772c9e
Configuration menu - View commit details
-
Copy full SHA for 6dbcb47 - Browse repository at this point
Copy the full SHA 6dbcb47View commit details -
Move away from rnplay to snack, with embedded examples!
Summary: React Native Playground has been sunset, so I've replaced the examples that previously used it with examples using [Snack](http://snack.expo.io/). The examples are directly embedded and can be edited live to see updates. The code itself is also in the docs, so we can easily update the docs in one place and we don't have to actually go to a saved app on Snack and update it there. Run it locally, go to the `Animations` section and the `Direct Manipulation` section. ![screen shot 2017-04-03 at 6 29 51 pm](https://cloud.githubusercontent.com/assets/90494/24638271/ff3ad044-189b-11e7-845d-24b2fb612d95.png) Open it on your phone, notice that it falls back to just showing plain code. <img src="https://cloud.githubusercontent.com/assets/90494/24638547/203ec8fc-189e-11e7-99c8-dfabff949f8d.PNG" width="250"> - Get rid of the Expo new user experience dialog that you see when you open a Snack -- is this a dealbreaker Closes facebook#13285 Differential Revision: D4828011 Pulled By: hramos fbshipit-source-id: 684ad24a14deb72abb8587ffbb726d316f126d75
Configuration menu - View commit details
-
Copy full SHA for b854239 - Browse repository at this point
Copy the full SHA b854239View commit details -
Summary: **Motivation**: Website documentation for the core Apple TV support. Closes facebook#13278 Differential Revision: D4839904 Pulled By: hramos fbshipit-source-id: e8b78f3601915072c0d809b05b4b5ca61828f277
Configuration menu - View commit details
-
Copy full SHA for 85d5a0e - Browse repository at this point
Copy the full SHA 85d5a0eView commit details -
Report JS errors in debug console
Reviewed By: javache Differential Revision: D4835405 fbshipit-source-id: d10658d1b885048ea3495388450208bb0e29ee5b
Configuration menu - View commit details
-
Copy full SHA for 37c1678 - Browse repository at this point
Copy the full SHA 37c1678View commit details -
Reviewed By: johnislarry Differential Revision: D4840716 fbshipit-source-id: 1a82437c81ce5b767efd39ab0716998bab4f5363
Configuration menu - View commit details
-
Copy full SHA for fd99330 - Browse repository at this point
Copy the full SHA fd99330View commit details -
Check that RCTDidInitializeModuleNotification is being called with th…
…e correct bridge Reviewed By: javache Differential Revision: D4800110 fbshipit-source-id: acc8bc512ed17a84abeac74afb91db51ab4c5043
Configuration menu - View commit details
-
Copy full SHA for b3872e8 - Browse repository at this point
Copy the full SHA b3872e8View commit details -
packager: GlobalTransformCache: make key globalized
Reviewed By: davidaurelio Differential Revision: D4835217 fbshipit-source-id: b43456e1e1f83c849a887b07f4f01f8ed0e9df4b
Configuration menu - View commit details
-
Copy full SHA for 77bee75 - Browse repository at this point
Copy the full SHA 77bee75View commit details -
Revert D4840716: Refactor interfaces
Differential Revision: D4840716 fbshipit-source-id: 1b6a6050d78ccbbd3c817621df1c1c989594fdb1
Configuration menu - View commit details
-
Copy full SHA for 5f37483 - Browse repository at this point
Copy the full SHA 5f37483View commit details -
packager: index files by dir for fast matching
Summary: This removes the call to `HasteFS#matchFiles()`, that has linear complexity. Instead, we index all the files by directory from `HasteFS` once loaded, a linear operation. Then, we can filter files from a particular directory much quicker. Reviewed By: davidaurelio Differential Revision: D4826721 fbshipit-source-id: c31a0ed9a354dbc7f2dcd56179b859e491faa16c
Configuration menu - View commit details
-
Copy full SHA for b210183 - Browse repository at this point
Copy the full SHA b210183View commit details -
Use the absolute path to the sourcemap in the CS bundle
Reviewed By: davidaurelio Differential Revision: D4831377 fbshipit-source-id: b7da81264a65bea1827237cdd34567b29579acd4
Configuration menu - View commit details
-
Copy full SHA for 6fa8713 - Browse repository at this point
Copy the full SHA 6fa8713View commit details -
Fixing another iOS app extension unsafe API usage in react native
Summary: Thanks for submitting a PR! Please read these instructions carefully: - [yes] Explain the **motivation** for making this change. Using react-native library inside iOS app extension causes a compile error inside react native stating that usage of UIAlertView is not allowed inside iOS app extension and should use UIAlertController instead. I have updated the code to use UIAlertController based on the other instances of the UIAlertController usage in the react-native library - [ partial ] Provide a **test plan** demonstrating that the code is solid. This code should be launched when developers start the profiler from the React native debug menu. I am currently in process of upgrading my app from 0.34 to the latest react native ( aka app not in working state). Would appreciate if there is an alternative way for me to test this functionality out. Just tried to create a new react-native project using "react-native init testproject" and upon running "react-native run-ios", I hit the following error a Closes facebook#13328 Differential Revision: D4844559 Pulled By: javache fbshipit-source-id: e516ca57cb2abf2b09aa53abecb0fe60a40190b4
Configuration menu - View commit details
-
Copy full SHA for 39eb090 - Browse repository at this point
Copy the full SHA 39eb090View commit details -
Fixed crash when forwarding already existing property from ReactNativ…
…eInternal to ReactNative Reviewed By: ericvicenti Differential Revision: D4843917 fbshipit-source-id: 6cdbac28d8a220a6ac289e8b98d9d50eca35e176
Configuration menu - View commit details
-
Copy full SHA for ea30aa0 - Browse repository at this point
Copy the full SHA ea30aa0View commit details
Commits on Apr 7, 2017
-
add eslint-config-fbjs to RN package.json
Reviewed By: leebyron Differential Revision: D4848928 fbshipit-source-id: 9aed6cf13e9ed548cb171c2f8b7f95a30220b6f9
Configuration menu - View commit details
-
Copy full SHA for d80f9df - Browse repository at this point
Copy the full SHA d80f9dfView commit details -
Set the enabled state on disabled button views
Reviewed By: AaaChiuuu Differential Revision: D4722513 fbshipit-source-id: f4a4e6304594235b5da4e5be36358331e43bdbee
Configuration menu - View commit details
-
Copy full SHA for b5327dd - Browse repository at this point
Copy the full SHA b5327ddView commit details -
Add option to track when we're showing blankness during fast scrolling
Summary: If tracking is enabled and the sampling check passes on a scroll or layout event, we compare the scroll offset to the layout of the rendered items. If the items don't cover the visible area of the list, we fire an `onFillRateExceeded` call with relevant stats for logging the event through an analytics pipeline. The measurement methodology is a little jank because everything is async, but it seems directionally useful for getting ballpark numbers, catching regressions, and tracking improvements. Benchmark testing shows a ~2014 MotoX starts hitting the fill rate limit at about 2500 px / sec, which is pretty fast scrolling. This also reworks our frame rate stuff so we can use a shared `SceneTracking` thing and track blankness globally. Reviewed By: bvaughn Differential Revision: D4806867 fbshipit-source-id: 119bf177463c8c3aa51fa13d1a9d03b1a96042aa
Configuration menu - View commit details
-
Copy full SHA for f72d9dd - Browse repository at this point
Copy the full SHA f72d9ddView commit details -
Support elements for header/footer
Summary: It can be much more convenient instead of binding and setting `extraData` or what-not. Reviewed By: blairvanderhoof Differential Revision: D4829165 fbshipit-source-id: bb781fedc831059e7b5065ea4357955aed79beda
Configuration menu - View commit details
-
Copy full SHA for 1b52c2a - Browse repository at this point
Copy the full SHA 1b52c2aView commit details -
packager: GlobalTransformCache: fix bug in retry logic
Reviewed By: bestander Differential Revision: D4850644 fbshipit-source-id: ede9991eaac3c7bfd045f2a9c3e9d0b10d45af0f
Configuration menu - View commit details
-
Copy full SHA for 568fb40 - Browse repository at this point
Copy the full SHA 568fb40View commit details -
Allow ModuleRegistry initialization to complete lazily
Reviewed By: mhorowitz Differential Revision: D4794794 fbshipit-source-id: f3b7a5d02587b4cd4e214aa6b0368a0d214fb63f
Configuration menu - View commit details
-
Copy full SHA for b2647ea - Browse repository at this point
Copy the full SHA b2647eaView commit details -
Use forward declaration in RCTCxxModule
Reviewed By: mhorowitz Differential Revision: D4821449 fbshipit-source-id: 8e75a7b17e0986bc9416a0afde0d7dfa179d4fed
Configuration menu - View commit details
-
Copy full SHA for ceac54e - Browse repository at this point
Copy the full SHA ceac54eView commit details -
Filters everything starting with `127.`
Configuration menu - View commit details
-
Copy full SHA for 7255194 - Browse repository at this point
Copy the full SHA 7255194View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6115d5a - Browse repository at this point
Copy the full SHA 6115d5aView commit details -
Reviewed By: ericvicenti Differential Revision: D4851513 fbshipit-source-id: 7ae9d3a8caef1364b3e300bf58db6232e90dc1cf
Configuration menu - View commit details
-
Copy full SHA for 1fec1cc - Browse repository at this point
Copy the full SHA 1fec1ccView commit details -
fix issue, closes: facebook#13380
Summary: Thanks for submitting a PR! Please read these instructions carefully: - [x] Explain the **motivation** for making this change. - [x] Provide a **test plan** demonstrating that the code is solid. - [x] Match the **code formatting** of the rest of the codebase. - [x] Target the `master` branch, NOT a "stable" branch. I am just fixing typos in the docs. proofreading Sign the [CLA][2], if you haven't already. Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. Make sure all **tests pass** on both [Travis][3] and [Circle CI][4]. PRs that break tests are unlikely to be merged. For more info, see the ["Pull Requests"][5] section of our "Contributing" guidelines. [1]: https://medium.com/martinkonicek/what-is-a-test-plan-8bfc840ec171#.y9lcuqqi9 [2]: https://code.facebook.com/cla [3]: https://travis-ci.org/facebook/react-native [4] Closes facebook#13382 Differential Revision: D4851786 Pulled By: javache fbshipit-source-id: 3cb67161653681c061d2e2b4a6a8c14527b8bd9b
Configuration menu - View commit details
-
Copy full SHA for 01bb095 - Browse repository at this point
Copy the full SHA 01bb095View commit details -
fix typo - closes facebook#13369
Summary: We're just fixing a reported typo from the docs. proofreading Closes facebook#13375 Differential Revision: D4851601 Pulled By: javache fbshipit-source-id: b8bd4067285809dd24b6e5c9bc8fddcc8734dfd1
Configuration menu - View commit details
-
Copy full SHA for 39431de - Browse repository at this point
Copy the full SHA 39431deView commit details -
Fix crash in
RCTRedBox::formatFrameSource:
Summary: Motivation: Similar to facebook#13242 - the application will crash with `[NSNull lastPathComponent]: unrecognized selector sent to instance` if a stack frame with no filename makes it to RCTRedBox. Closes facebook#13360 Differential Revision: D4848980 Pulled By: javache fbshipit-source-id: dc506f2ba39c2d4d68982b56a6e765a19dc048b0
Configuration menu - View commit details
-
Copy full SHA for 540f4c9 - Browse repository at this point
Copy the full SHA 540f4c9View commit details -
Summary: Thanks for submitting a PR! Please read these instructions carefully: - [ ] Explain the **motivation** for making this change. - [ ] Provide a **test plan** demonstrating that the code is solid. - [ ] Match the **code formatting** of the rest of the codebase. - [ ] Target the `master` branch, NOT a "stable" branch. What existing problem does the pull request solve? A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See [What is a Test Plan?][1] to learn more. If you have added code that should be tested, add tests. Sign the [CLA][2], if you haven't already. Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. Make sure all **tests pass** on both [Travis][3] and [Circle CI][4]. PRs that break tests are unlikely to be merged. Closes facebook#13385 Differential Revision: D4852068 Pulled By: hramos fbshipit-source-id: ff193a7c90aa8b00c248575ae647f1fb14eb261f
Configuration menu - View commit details
-
Copy full SHA for 597c8c7 - Browse repository at this point
Copy the full SHA 597c8c7View commit details -
Add block-based initializer for RCTModuleData
Reviewed By: shergin Differential Revision: D4821772 fbshipit-source-id: 2cd35ec6726b6fe1494a92966ade5aa0b86e769b
Configuration menu - View commit details
-
Copy full SHA for 76b93e1 - Browse repository at this point
Copy the full SHA 76b93e1View commit details -
Add JSC utility header to RCTBridge
Reviewed By: shergin Differential Revision: D4823509 fbshipit-source-id: 79c96d3bc183d89a5dec7da06b0a0a710d8c7dea
Configuration menu - View commit details
-
Copy full SHA for 5767b98 - Browse repository at this point
Copy the full SHA 5767b98View commit details -
PushNotificationIOS.requestPermissions won't resolve if no event list…
…eners are attached Summary: Resolves facebook#13012 RCTPushNotificationManager uses startObserving to register for RCTRegisterUserNotificationSettings. According to the docs, the startObserving method won't be called until somebody subscribes to NotificationManagerIOS. This means there is a scenario when the developer can call requestPermissions without subscribing to notifications first, but since RCTPushNotificationManager relies on NSNotificationCenter subscribtion, the result will never be returned. When requesting permissions the promise will resolve: `PushNotificationIOS.requestPermissions().then(console.log);` without the need for calling `PushNotificationIOS.addEventListener()` first. Closes facebook#13263 Differential Revision: D4851767 Pulled By: javache fbshipit-source-id: 2be8621e072ae1086014594bc986ca5590b5eb61
Configuration menu - View commit details
-
Copy full SHA for d03f9b7 - Browse repository at this point
Copy the full SHA d03f9b7View commit details -
Stop yarn error message appearing for Windows users of local-cli
Summary: On windows, recent versions of local-cli will display a yarn error to stderr when starting the packager (see https://github.com/expo/xde/issues/91, expo/create-react-native-app#101, expo/create-react-native-app#113 (comment) for examples of users hitting this in the wild), even though no package management action is being taken. From what I can tell this is what happens: * [`local-cli/util/yarn.js` does not ignore stderr on Windows](https://github.com/facebook/react-native/blob/6fa87134fc68fd447e33a01a538ae0af6710e5d2/local-cli/util/yarn.js#L25) * [`local-cli/util/PackageManager.js` calls the above function when it's require'd](https://github.com/facebook/react-native/blob/6fa87134fc68fd447e33a01a538ae0af6710e5d2/local-cli/util/PackageManager.js#L20) For Windows users who don't have yarn installed, this means that the 'yarn is not recognized as an internal or external command..." error displays wh Closes facebook#13355 Differential Revision: D4848084 Pulled By: hramos fbshipit-source-id: f32176354e0bd7ff6d7009ea30dca64ff23ae3d5
Configuration menu - View commit details
-
Copy full SHA for 403f356 - Browse repository at this point
Copy the full SHA 403f356View commit details -
Add proguard rules to bridge BUCK
Summary: prevents reflected classes from being stripped/obfuscated Depends on D4830910 Reviewed By: mhorowitz Differential Revision: D4835688 fbshipit-source-id: 5b85668f92ed4ae5cebc9902ec60f6d5d6299bd4
Configuration menu - View commit details
-
Copy full SHA for e154117 - Browse repository at this point
Copy the full SHA e154117View commit details -
Add a nativeID prop to allow native code to reference react managed v…
…iews Reviewed By: sahrens Differential Revision: D4786713 fbshipit-source-id: af9cef0737c010b429d52d00181c00bd81f13f5b
Configuration menu - View commit details
-
Copy full SHA for 909af08 - Browse repository at this point
Copy the full SHA 909af08View commit details -
Correct
setState()
usage in tutorialSummary: If the new state depends on the previous state, if I remember correctly, it’s safer to use `setState()` with a function argument to ensure we’re not reading from an outdated `state`. Thanks for submitting a PR! Please read these instructions carefully: - [x] Explain the **motivation** for making this change. - [x] Provide a **test plan** demonstrating that the code is solid. - [x] Match the **code formatting** of the rest of the codebase. - [x] Target the `master` branch, NOT a "stable" branch. The tutorial suggests to use `setState()` with an object argument when the new state depends on the previous state. In such situations, it’s preferable to use a function to ensure the previous state is up-to-date. Updates documentation only, so there are no additional tests. Rendering the site. Sign the [CLA][2], if you haven't already. Small pull requests are much easier to review and more likely to get merged. Make sure th Closes facebook#13358 Differential Revision: D4852404 Pulled By: hramos fbshipit-source-id: 834759e16bcfbd5a8de71bf0c56f2b154f3321e1
Configuration menu - View commit details
-
Copy full SHA for 29404f0 - Browse repository at this point
Copy the full SHA 29404f0View commit details -
Fix crash from FillRateLogging
Reviewed By: thechefchen Differential Revision: D4853991 fbshipit-source-id: b024d4052edb04e9f9da2e2504c56f8b7840cded
Configuration menu - View commit details
-
Copy full SHA for 6f8ce41 - Browse repository at this point
Copy the full SHA 6f8ce41View commit details
Commits on Apr 8, 2017
-
Summary: Closes facebook#13389 Differential Revision: D4854128 Pulled By: hramos fbshipit-source-id: bd7d0d12eae51fed31cf4bc2260b8c4f447e08c8
Configuration menu - View commit details
-
Copy full SHA for a1e06df - Browse repository at this point
Copy the full SHA a1e06dfView commit details -
packager: HasteMap: expose getAllFiles()
Reviewed By: tomocchino Differential Revision: D4850695 fbshipit-source-id: 8aae4353de8779f7a1358b2766dad4a6c751b4af
Configuration menu - View commit details
-
Copy full SHA for 263f40a - Browse repository at this point
Copy the full SHA 263f40aView commit details -
Summary: When running an app on a real iPhone in debug mode, I occasionally get issues when trying to load the js bundle and I suspect the issue is with xip.io (and it doesn't look like I'm the only one: facebook#12786 facebook#9688 (comment)). So I've added the ability to optionally disable the use of xip.io if an env variable `DISABLE_XIP` is set. Add `export DISABLE_XIP=true` to the `Bundle React Native code and images` build phase. Run the app on a real iPhone and ensure that it can load the JS bundle from the host computers IP. Closes facebook#13326 Differential Revision: D4855719 Pulled By: ericvicenti fbshipit-source-id: cb2e91291acadaa78ea302800b55c2e5388f6380
Configuration menu - View commit details
-
Copy full SHA for 3d3cd86 - Browse repository at this point
Copy the full SHA 3d3cd86View commit details -
Reviewed By: nmote Differential Revision: D4851923 fbshipit-source-id: 018f61c3a45e32c899287848d36129e3601145a4
Configuration menu - View commit details
-
Copy full SHA for e67b8fe - Browse repository at this point
Copy the full SHA e67b8feView commit details -
Allow lazy Cxx modules to not initialize
Reviewed By: mhorowitz Differential Revision: D4851596 fbshipit-source-id: cf5f5c51b9aaa0da96f7ab6fba1277b72c988400
Configuration menu - View commit details
-
Copy full SHA for f3dfd61 - Browse repository at this point
Copy the full SHA f3dfd61View commit details -
Improve constant extraction from RCTNativeModule
Reviewed By: dcaspi Differential Revision: D4829671 fbshipit-source-id: 6b1cef1d31c7d8981c6f1e304d3742e885f8a83b
Configuration menu - View commit details
-
Copy full SHA for 2336ac2 - Browse repository at this point
Copy the full SHA 2336ac2View commit details
Commits on Apr 10, 2017
-
Webview disable save form prop
Summary: Adds functionality to be able to disable saving of form data and thereby disabling autocomplete in webview on Android. Can be used as a workaround for facebook#13241 Manual testing that autocomplete is disabled when the property is set to true, and still enabled when it is unset or set to false. Closes facebook#13271 Differential Revision: D4858899 Pulled By: ericvicenti fbshipit-source-id: 62738b0685e4c1958c8a32e184fa2fe4f711b336
Configuration menu - View commit details
-
Copy full SHA for 8591d8a - Browse repository at this point
Copy the full SHA 8591d8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 62114bb - Browse repository at this point
Copy the full SHA 62114bbView commit details -
Filters everything starting with `127.`
Configuration menu - View commit details
-
Copy full SHA for 97cb709 - Browse repository at this point
Copy the full SHA 97cb709View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c2c2b8 - Browse repository at this point
Copy the full SHA 5c2c2b8View commit details -
Merge branch 'fix-mac-ip-detection-loopback' of https://github.com/ts…
…jing/react-native into fix-mac-ip-detection-loopback # Conflicts: # packager/react-native-xcode.sh
Configuration menu - View commit details
-
Copy full SHA for 50f7f3c - Browse repository at this point
Copy the full SHA 50f7f3cView commit details