-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing another iOS app extension unsafe API usage in react native #13328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th RCTSharedApplication()
facebook-github-bot
added
GH Review: review-needed
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
labels
Apr 5, 2017
shrutic
changed the title
Fixing another iOS app unsafe API usage in react native
Fixing another iOS app extension unsafe API usage in react native
Apr 5, 2017
facebook-github-bot
added
GH Review: accepted
Import Started
This pull request has been imported. This does not imply the PR has been approved.
and removed
GH Review: review-needed
labels
Apr 6, 2017
@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
thotegowda
pushed a commit
to thotegowda/react-native
that referenced
this pull request
May 7, 2017
Summary: Thanks for submitting a PR! Please read these instructions carefully: - [yes] Explain the **motivation** for making this change. Using react-native library inside iOS app extension causes a compile error inside react native stating that usage of UIAlertView is not allowed inside iOS app extension and should use UIAlertController instead. I have updated the code to use UIAlertController based on the other instances of the UIAlertController usage in the react-native library - [ partial ] Provide a **test plan** demonstrating that the code is solid. This code should be launched when developers start the profiler from the React native debug menu. I am currently in process of upgrading my app from 0.34 to the latest react native ( aka app not in working state). Would appreciate if there is an alternative way for me to test this functionality out. Just tried to create a new react-native project using "react-native init testproject" and upon running "react-native run-ios", I hit the following error a Closes facebook#13328 Differential Revision: D4844559 Pulled By: javache fbshipit-source-id: e516ca57cb2abf2b09aa53abecb0fe60a40190b4
Closed
Nope. I need a sign off that the fb engineers are not giving
Shruti
…Sent from my iPhone
On Mar 14, 2019, at 7:26 AM, Danny ***@***.***> wrote:
@shrutic Do you have any update on the status of this and your other related merge requests? (#14263 and #13227) I would really like to use react-native in an iMessage application but these issues make it impossible :(
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I forgot to mention. I created my own repo of react native and pointed my app to that repo with required changes. We need to periodically update it either the master branch. Hope this option works for you
Shruti
…Sent from my iPhone
On Mar 14, 2019, at 7:26 AM, Danny ***@***.***> wrote:
@shrutic Do you have any update on the status of this and your other related merge requests? (#14263 and #13227) I would really like to use react-native in an iMessage application but these issues make it impossible :(
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
What changes did you need to make to your fork in order to get it to work? |
The 2 Pull requests that you pointed in your previous message.
Shruti
…Sent from my iPhone
On Mar 14, 2019, at 9:30 AM, Danny ***@***.***> wrote:
What changes did you need to make to your fork in order to get it to work?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Great, thank you for your help @shrutic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Import Started
This pull request has been imported. This does not imply the PR has been approved.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please read these instructions carefully:
[yes] Explain the motivation for making this change.
Using react-native library inside iOS app extension causes a compile error inside react native stating that usage of UIAlertView is not allowed inside iOS app extension and should use UIAlertController instead. I have updated the code to use UIAlertController based on the other instances of the UIAlertController usage in the react-native library
[ partial ] Provide a test plan demonstrating that the code is solid.
This code should be launched when developers start the profiler from the React native debug menu. I am currently in process of upgrading my app from 0.34 to the latest react native ( aka app not in working state). Would appreciate if there is an alternative way for me to test this functionality out.
Just tried to create a new react-native project using "react-native init testproject" and upon running "react-native run-ios", I hit the following error and hence I could not test the debug menu Performance profiler alert.
master
branch, NOT a "stable" branch.Motivation (required)
What existing problem does the pull request solve?
Test Plan (required)
A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See What is a Test Plan? to learn more.
If you have added code that should be tested, add tests.
Next Steps
Sign the CLA, if you haven't already.
Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
Make sure all tests pass on both Travis and Circle CI. PRs that break tests are unlikely to be merged.
For more info, see the "Pull Requests" section of our "Contributing" guidelines.