Fix crash in RCTRedBox::formatFrameSource:
#13360
Conversation
facebook-github-bot
added
CLA Signed
|
@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
facebook-github-bot
added
Import Failed
Import Started
|
@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Motivation: Similar to #13242 - the application will crash with `[NSNull lastPathComponent]: unrecognized selector sent to instance` if a stack frame with no filename makes it to RCTRedBox. Closes #13360 Differential Revision: D4848980 Pulled By: javache fbshipit-source-id: dc506f2ba39c2d4d68982b56a6e765a19dc048b0
Summary: Motivation: Similar to #13242 - the application will crash with `[NSNull lastPathComponent]: unrecognized selector sent to instance` if a stack frame with no filename makes it to RCTRedBox. Closes #13360 Differential Revision: D4848980 Pulled By: javache fbshipit-source-id: dc506f2ba39c2d4d68982b56a6e765a19dc048b0
Summary: Motivation: Similar to facebook#13242 - the application will crash with `[NSNull lastPathComponent]: unrecognized selector sent to instance` if a stack frame with no filename makes it to RCTRedBox. Closes facebook#13360 Differential Revision: D4848980 Pulled By: javache fbshipit-source-id: dc506f2ba39c2d4d68982b56a6e765a19dc048b0
Motivation: Similar to #13242 - the application will crash with
[NSNull lastPathComponent]: unrecognized selector sent to instanceif a stack frame with no filename makes it to RCTRedBox.Test plan: Send a crash to RCTRedBox with no filename in the stack frame.