Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The width and height should be in the revsersed order. #13203

Closed
wants to merge 1 commit into from

Conversation

hoangpham95
Copy link

Motivation (required)

Inspired by #13191

Test Plan (required)

Creating a test app with spannable TextView, and observe the text width/height

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Mar 29, 2017
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Mar 29, 2017
@facebook-github-bot
Copy link
Contributor

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@bennyguitar
Copy link

I don't think the test plan is sufficient.

Should be:

  • Create a component that renders a Text with inline image with differing widths/heights to make sure that width/height is respected.
<Text>
  <Image source={img} style={{width: 100, height: 20}} />
</Text>

should do the trick to visually verify the changes.

@hoangpham95 hoangpham95 deleted the fix-text-inline-img branch April 3, 2017 21:19
thotegowda pushed a commit to thotegowda/react-native that referenced this pull request May 7, 2017
Summary:
Inspired by facebook#13191

Creating a test app with spannable `TextView`, and observe the text width/height
Closes facebook#13203

Differential Revision: D4795809

Pulled By: hramos

fbshipit-source-id: a7c6845abe7472dc7ad2f1f978a20d02fe49eda8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants