Add -fsized-deallocation compile option #9218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This was referenced Sep 22, 2022
Atry
added a commit
to Atry/fbthrift
that referenced
this pull request
Sep 22, 2022
Summary: Fb-thrift uses C++17's `operator delete`, which requires `-fsized-deallocation` when building c++ source code with clang and libstdc++. https://github.com/facebook/hhvm/blob/9832791642981d582d0f29c6d89dba2c879cc43d/third-party/thrift/src/thrift/lib/cpp/ContextStack.cpp#L229-L230 X-link: facebook/hhvm#9218 Differential Revision: D39707592 Pulled By: Atry fbshipit-source-id: d2074612e9d0cc62b8b74d9e93079641521e852c
|
@Atry has updated the pull request. You must reimport the pull request before landing. |
|
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Atry
added a commit
to Atry/fbthrift
that referenced
this pull request
Sep 22, 2022
Summary: Fb-thrift uses C++17's `operator delete`, which requires `-fsized-deallocation` when building c++ source code with clang and libstdc++. https://github.com/facebook/hhvm/blob/9832791642981d582d0f29c6d89dba2c879cc43d/third-party/thrift/src/thrift/lib/cpp/ContextStack.cpp#L229-L230 X-link: facebook/hhvm#9218 Differential Revision: D39707592 Pulled By: Atry fbshipit-source-id: 8c1a4251e48b8802aab1606f50a972ca945b7da2
|
@Atry has updated the pull request. You must reimport the pull request before landing. |
|
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Atry
added a commit
to Atry/fbthrift
that referenced
this pull request
Sep 23, 2022
Summary: Fb-thrift uses C++17's `operator delete`, which requires `-fsized-deallocation` when building c++ source code with clang and libstdc++. https://github.com/facebook/hhvm/blob/9832791642981d582d0f29c6d89dba2c879cc43d/third-party/thrift/src/thrift/lib/cpp/ContextStack.cpp#L229-L230 X-link: facebook/hhvm#9218 Reviewed By: vitaut Differential Revision: D39707592 Pulled By: Atry fbshipit-source-id: 46e82a2d16ce095ac60b73396a8baa1d54bc57c9
Summary: X-link: facebook/fbthrift#528 Fb-thrift uses C++17's `operator delete`, which requires `-fsized-deallocation` when building c++ source code with clang and libstdc++. https://github.com/facebook/hhvm/blob/9832791642981d582d0f29c6d89dba2c879cc43d/third-party/thrift/src/thrift/lib/cpp/ContextStack.cpp#L229-L230 Pull Request resolved: facebook#9218 Test Plan: Rebase facebook#9129 onto this PR, then there will be no error message about `operator delete`. Reviewed By: vitaut Differential Revision: D39707592 Pulled By: Atry fbshipit-source-id: dd1c0ad0ab438a1340b63b16b683e71fd3eba5c7
|
This pull request was exported from Phabricator. Differential Revision: D39707592 |
Atry
force-pushed
the
add-fsized-deallocation-compile-option
branch
from
527e88f to
4b90325
Compare
|
@Atry has updated the pull request. You must reimport the pull request before landing. |
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Sep 24, 2022
Summary: Pull Request resolved: #528 Fb-thrift uses C++17's `operator delete`, which requires `-fsized-deallocation` when building c++ source code with clang and libstdc++. https://github.com/facebook/hhvm/blob/9832791642981d582d0f29c6d89dba2c879cc43d/third-party/thrift/src/thrift/lib/cpp/ContextStack.cpp#L229-L230 X-link: facebook/hhvm#9218 Test Plan: Rebase facebook/hhvm#9129 onto this PR, then there will be no error message about `operator delete`. Reviewed By: vitaut Differential Revision: D39707592 Pulled By: Atry fbshipit-source-id: aeddf5d6b2c8bb8b9d71578fe38f57a1b47f8dc9
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 27, 2022
Summary: This PR is an aggregation of the following PRs that fix issues in the HHVM OSS's clang build. - #9226 - #9223 - #9220 - #9218 - #9217 - #9215 - #9214 - #9213 - #9211 It merges all the above PRs and removes `continue-on-error` for clang build. Pull Request resolved: #9129 Test Plan: GitHub Action for the clang build should pass. Reviewed By: alexeyt Differential Revision: D38631930 Pulled By: Atry fbshipit-source-id: 4fbd47ee355e760800444b7112af241555a9a8a5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fb-thrift uses C++17's
operator delete, which requires-fsized-deallocationwhen building c++ source code with clang and libstdc++.hhvm/third-party/thrift/src/thrift/lib/cpp/ContextStack.cpp
Lines 229 to 230 in 9832791
Test Plan:
Rebase #9129 onto this PR, then there will be no error message about
operator delete.