Build hhvm_clang with libstdc++ instead of libc++ #9213
Conversation
Running tests in the checkPhase would let the tests be package specific, i.e. the HHVM built packages with gcc and clang could have separate tests
In the next couple of PR, I will create a new HHVM package compiled with clang, which use the shared settings from common.nix.
This reverts commit f48cecd.
…mcrouter_with_clang
…mcrouter_with_clang
…mcrouter_with_clang
…her mcrouter should be disabled
|
@Atry has updated the pull request. You must reimport the pull request before landing. |
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@Atry has updated the pull request. You must reimport the pull request before landing. |
|
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@Atry has updated the pull request. You must reimport the pull request before landing. |
|
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: This PR is an aggregation of the following PRs that fix issues in the HHVM OSS's clang build. - #9226 - #9223 - #9220 - #9218 - #9217 - #9215 - #9214 - #9213 - #9211 It merges all the above PRs and removes `continue-on-error` for clang build. Pull Request resolved: #9129 Test Plan: GitHub Action for the clang build should pass. Reviewed By: alexeyt Differential Revision: D38631930 Pulled By: Atry fbshipit-source-id: 4fbd47ee355e760800444b7112af241555a9a8a5
This PR builds
hhvm_clangnix package with libstdc++ instead of libc++.Note that this PR also switch clang to version 14 instead of version 12, because it is a closer version to the internal clang version 15, given that nixpkgs does not provide clang 15 right now. See NixOS/nixpkgs#191132
Test Plan:
This PR should not affect
hhvmnix package, which is built with gcc. The CI job forhhvm_clangis expected to fail because we have not ported HHVM OSS to Clang.