Skip to content

Commit

Permalink
Build HHVM on Linux with Clang (#9129)
Browse files Browse the repository at this point in the history
Summary:
This PR is an aggregation of the following PRs that fix issues in the HHVM OSS's clang build.

- #9226
- #9223
- #9220
- #9218
- #9217
- #9215
- #9214
- #9213
- #9211

It merges all the above PRs and removes `continue-on-error` for clang build.

Pull Request resolved: #9129

Test Plan: GitHub Action for the clang build should pass.

Reviewed By: alexeyt

Differential Revision: D38631930

Pulled By: Atry

fbshipit-source-id: 4fbd47ee355e760800444b7112af241555a9a8a5
  • Loading branch information
Atry authored and facebook-github-bot committed Sep 27, 2022
1 parent c2100c9 commit fa355d1
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/nix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ jobs:
- hhvm_clang
os:
- ubuntu-latest
# Building hhvm_clang is expected to fail because we have not fully ported HHVM OSS to Clang yet
continue-on-error: ${{ matrix.package == 'hhvm_clang' }}
runs-on: ${{matrix.os}}
steps:
- uses: actions/[email protected]
Expand Down

0 comments on commit fa355d1

Please sign in to comment.