Skip to content

Commit

Permalink
Build hhvm_clang with libstdc++ instead of libc++ (#9213)
Browse files Browse the repository at this point in the history
Summary:
This PR builds `hhvm_clang` nix package with libstdc++ instead of libc++.

Note that this PR also switch clang to version 14 instead of version 12, because it is a closer version to the internal clang version 15, given that nixpkgs does not provide clang 15 right now. See NixOS/nixpkgs#191132

Pull Request resolved: #9213

Test Plan: This PR should not affect `hhvm` nix package, which is built with gcc. The CI job for `hhvm_clang` is expected to fail because we have not ported HHVM OSS to Clang.

Reviewed By: alexeyt

Differential Revision: D39673905

Pulled By: Atry

fbshipit-source-id: 28906d5dbd243ecbdea90ccab9a8d611fa2a8f99
  • Loading branch information
Atry authored and facebook-github-bot committed Sep 26, 2022
1 parent 5a2d595 commit e6919bc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion flake.nix
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
lastModifiedDate = self.lastModifiedDate;
};
packages.hhvm_clang = packages.hhvm.override {
stdenv = pkgs.llvmPackages_12.libcxxStdenv;
stdenv = pkgs.llvmPackages_14.stdenv;
};
packages.default = packages.hhvm;

Expand Down

0 comments on commit e6919bc

Please sign in to comment.