Add -fsized-deallocation compile option (#9218) #528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D39707592 |
Atry
force-pushed
the
export-D39707592
branch
from
8cc39b7 to
50c7447
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39707592 |
Summary: Fb-thrift uses C++17's `operator delete`, which requires `-fsized-deallocation` when building c++ source code with clang and libstdc++. https://github.com/facebook/hhvm/blob/9832791642981d582d0f29c6d89dba2c879cc43d/third-party/thrift/src/thrift/lib/cpp/ContextStack.cpp#L229-L230 X-link: facebook/hhvm#9218 Reviewed By: vitaut Differential Revision: D39707592 Pulled By: Atry fbshipit-source-id: 46e82a2d16ce095ac60b73396a8baa1d54bc57c9
Atry
force-pushed
the
export-D39707592
branch
from
50c7447 to
10b0fb2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39707592 |
Atry
added a commit
to Atry/hhvm
that referenced
this pull request
Sep 24, 2022
Summary: X-link: facebook/fbthrift#528 Fb-thrift uses C++17's `operator delete`, which requires `-fsized-deallocation` when building c++ source code with clang and libstdc++. https://github.com/facebook/hhvm/blob/9832791642981d582d0f29c6d89dba2c879cc43d/third-party/thrift/src/thrift/lib/cpp/ContextStack.cpp#L229-L230 Pull Request resolved: facebook#9218 Test Plan: Rebase facebook#9129 onto this PR, then there will be no error message about `operator delete`. Reviewed By: vitaut Differential Revision: D39707592 Pulled By: Atry fbshipit-source-id: dd1c0ad0ab438a1340b63b16b683e71fd3eba5c7
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Sep 24, 2022
Summary: X-link: facebook/fbthrift#528 Fb-thrift uses C++17's `operator delete`, which requires `-fsized-deallocation` when building c++ source code with clang and libstdc++. https://github.com/facebook/hhvm/blob/9832791642981d582d0f29c6d89dba2c879cc43d/third-party/thrift/src/thrift/lib/cpp/ContextStack.cpp#L229-L230 Pull Request resolved: #9218 Test Plan: Rebase #9129 onto this PR, then there will be no error message about `operator delete`. Reviewed By: vitaut Differential Revision: D39707592 Pulled By: Atry fbshipit-source-id: aeddf5d6b2c8bb8b9d71578fe38f57a1b47f8dc9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fb-thrift uses C++17's
operator delete, which requires-fsized-deallocationwhen building c++ source code with clang and libstdc++.https://github.com/facebook/hhvm/blob/9832791642981d582d0f29c6d89dba2c879cc43d/third-party/thrift/src/thrift/lib/cpp/ContextStack.cpp#L229-L230
X-link: facebook/hhvm#9218
Differential Revision: D39707592
Pulled By: Atry