add new UpdateType & fields to L1 system config required for the Ecotone upgrade

[roberto-bayardo]

Description

Ecotone upgrade requires new scalar fields to be added and support to update them.

Corresponding spec update: #8708

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6ec80fd) 34.90% compared to head (da63bf0) 34.94%.
Report is 5 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #8723      +/-   ##
===========================================
+ Coverage    34.90%   34.94%   +0.04%     
===========================================
  Files          165      165              
  Lines         7083     7089       +6     
  Branches      1193     1193              
===========================================
+ Hits          2472     2477       +5     
- Misses        4459     4460       +1     
  Partials       152      152              

Flag	Coverage Δ
cannon-go-tests	63.48% <ø> (ø)
chain-mon-tests	27.14% <ø> (ø)
common-ts-tests	26.74% <ø> (ø)
contracts-bedrock-tests	20.99% <83.33%> (+0.18%)	⬆️
contracts-ts-tests	12.25% <ø> (ø)
core-utils-tests	44.03% <ø> (ø)
sdk-next-tests	42.08% <ø> (ø)
sdk-tests	42.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
packages/contracts-bedrock/src/L1/SystemConfig.sol	69.04% <83.33%> (+2.38%)	⬆️

[tynes]

We are going to need unit tests:

• setter onlyOwner revert
• setter + getter roundtrip
• setter + expectEmit

For 2 + 3, they could be fuzz tests

[coderabbitai]

Walkthrough

Walkthrough

The SystemConfig.sol contract has been updated to include enhancements related to fee scaling. A new enum value has been added to handle fee scale adjustments, and two new variables have been introduced to manage base fee scalars. The version has been bumped to reflect these updates. Additionally, two functions have been added to facilitate the setting of fee scalars, with one being an external function restricted to the contract owner and an internal function that emits a configuration update event.

Changes

File Path	Change Summary
.../L1/SystemConfig.sol	- Added GAS_CONFIG_ECOTONE to UpdateType enum. - Introduced basefeeScalar and blobBasefeeScalar public variables. - Updated version constant to "1.12.0". - Added setGasConfigEcotone and _setGasConfigEcotone functions for gas configuration updates.
.../test/L1/SystemConfig.t.sol .../test/Specs.t.sol	- Added assertions for new scalar values. - Modified revert behavior of certain functions. - Added new test functions for updating gas configurations.
.../contracts-bedrock/.gas-snapshot	- Adjustments to gas costs in benchmark tests for cross-domain messaging, bridge deposits, finalization, output oracles, and portal transactions.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit's AI:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
  • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[tynes]

Can you also add tests for the initialize case? It is very important that the blob scalar is 0 and the basefee scalar is the scalar. For both event emission and initial values