Revert "add new UpdateType & fields to L1 system config required for the Ecotone upgrade"

[maurelian]

We unfortunately need to revert this PR, at least until we are sure that the full set of extended pause PRs are in, and only those PRs. This is necessary so that we can have a develop branch commit to point to in the governance proposal.

Until then this PR should go onto a feature branch. Sorry for causing inconvenience here.

[coderabbitai]

Walkthrough

Walkthrough

The recent updates to the Bedrock contract packages involve refinement of gas cost benchmarks, simplification of the SystemConfig contract by removing specific configuration elements and related functions, and the corresponding adjustments in test cases. This indicates a streamlining of the gas configuration and system parameters, potentially to align with updated network conditions or optimizations.

Changes

File Path	Change Summary
.../.gas-snapshot	Adjusted gas costs for benchmark tests in various functions.
.../src/L1/SystemConfig.sol	Removed UNSAFE_BLOCK_SIGNER and GAS_CONFIG_ECOTONE from UpdateType enum, downgraded version to "1.11.0", and removed basefeeScalar, blobBasefeeScalar, and associated gas config functions.
.../test/L1/SystemConfig.t.sol, .../test/Specs.t.sol	Removed tests and assertions for basefeeScalar, blobBasefeeScalar, and setGasConfigEcotone function; updated specifications accordingly.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit's AI:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
  • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a7a1775) 34.81% compared to head (3298084) 25.92%.
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #8865      +/-   ##
===========================================
- Coverage    34.81%   25.92%   -8.90%     
===========================================
  Files          165      117      -48     
  Lines         7106     4818    -2288     
  Branches      1198     1047     -151     
===========================================
- Hits          2474     1249    -1225     
+ Misses        4482     3463    -1019     
+ Partials       150      106      -44     

Flag	Coverage Δ
cannon-go-tests	?
chain-mon-tests	27.14% <ø> (ø)
common-ts-tests	?
contracts-bedrock-tests	20.63% <ø> (-0.04%)	⬇️
contracts-ts-tests	12.25% <ø> (ø)
core-utils-tests	?
sdk-next-tests	42.08% <ø> (ø)
sdk-tests	42.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
packages/contracts-bedrock/src/L1/SystemConfig.sol	66.66% <ø> (-2.39%)	⬇️

... and 51 files with indirect coverage changes