Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new fields required by Ecotone upgrade #46

Closed

Conversation

roberto-bayardo
Copy link

Description

Adds two new parameters required by the Ecotone (formerly Eclipse) upgrade to the GenesisSystemConfig.

@tynes
Copy link
Contributor

tynes commented Jan 3, 2024

I am not sure if we want to merge this because we may want to hardcode the values so that L1 and the L2 view never get out of sync. The current implementation of the smart contracts in ethereum-optimism/optimism#8723 migrates the legacy scalar to the base fee scalar and sets the blob base fee scalar to 0 so we could just hardcode those values. We need to consider the cases of new chains and upgrading chains which adds some complexity to the smart contract implementations if we wanted to allow for dynamic setting of these values in genesis for new chains. If the values can be different, then it makes the consensus rules different in different op stack chains for the upgrade txs which adds complexity that i prefer to avoid.

@tynes
Copy link
Contributor

tynes commented Jan 5, 2024

I am feeling confident that we do not need this PR based on the params being deterministic as per ethereum-optimism/optimism#8829

@tynes tynes closed this Jan 5, 2024
@roberto-bayardo roberto-bayardo deleted the ecotone branch January 5, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants