EIP4844 L1 Smart Contract Updates #8715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8715 +/- ##
===========================================
+ Coverage 34.57% 44.47% +9.89%
===========================================
Files 167 41 -126
Lines 7170 2071 -5099
Branches 1213 117 -1096
===========================================
- Hits 2479 921 -1558
+ Misses 4539 1104 -3435
+ Partials 152 46 -106
Flags with carried forward coverage won't be shown. Click here to find out more. |
anikaraghu
force-pushed
the
anika/4844-l1
branch
from
762db8f to
f56d83b
Compare
anikaraghu
commented
Dec 21, 2023
| /// block distrubution. | ||
| enum UpdateType { | ||
| BATCHER, | ||
| GAS_CONFIG, | ||
| GAS_LIMIT, | ||
| UNSAFE_BLOCK_SIGNER | ||
| UNSAFE_BLOCK_SIGNER, | ||
| FEE_SCALARS_ECOTONE |
There was a problem hiding this comment.
went back and forth around keeping the old GAS_CONFIG naming vs this FEE_SCALARS one - if using the Fee Scalar naming instead, we could techincally omit the "ecotone" suffix throughout - open to thoughts
| basefeeScalar = _basefeeScalar; | ||
| blobBasefeeScalar = _blobBasefeeScalar; | ||
|
|
||
| bytes memory data = abi.encode(_basefeeScalar, _blobBasefeeScalar); |
There was a problem hiding this comment.
let's do encodePacked
|
Taking over this PR from Anika since she's out for the holidays, will resubmit a new PR with these changes. Feel free to close this one (I don't have permission). |
|
Superceded by: #8723 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Splitting out L1 contract changes in a separate PR since they're fully separate from the L2 contract changes in #8712 .
Adds new scalars to the SystemConfig contract
Tests
Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.
Additional context
Add any other context about the problem you're solving.
Metadata