Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1.0 branch #1

Merged
merged 10 commits into from
Nov 25, 2022
Merged

V1.0 branch #1

merged 10 commits into from
Nov 25, 2022

Conversation

erwinpan1
Copy link
Owner

!!!!!!!!!! Please delete the instructions below and replace with PR desription

If you have an issue number, please use a syntax of
Fixes #12345 and a brief change description

If you do not have an issue number, please have a good description of
the problem and the fix. Help the reviewer understand what to expect.

Make sure you delete these instructions (to prove you have read them).

!!!!!!!!!! Instructions end

s07641069 and others added 10 commits November 3, 2022 11:06
@s07641069
[Telink] Adopt to latest telink zephyr & Update Telink image to 0.6.0…
a17c005 
…2 (Cherry-pick project-chip#22971) (project-chip#23380)

* [Telink] Adopt to latest telink zephyr & Update Telink image to 0.6.02 (project-chip#22971)

* [Telink] use zephyr in include path
* [Telink] use telink zephyr crypto
* [Telink] rename IEEE802154 functions and isr table offset fix
* [Telink] restyle
* [Telink]: Update Telink image to 0.6.02

* [Telink] Add CHIP license attribution
@s07641069
[Telink] add BLE PostEvent and fast/slow adv (project-chip#23116) (pr…
ff13388 
…oject-chip#23465)
@s07641069 @andy31415
[Telink] use src/app/chip_data_model.cmake for data model inclusions (p…
fe40470 
…roject-chip#23255) (project-chip#23466)

Co-authored-by: Andrei Litvin <[email protected]>

Co-authored-by: Andrei Litvin <[email protected]>
@pankore
use docker image 0.6.03 and change BLE notification to indication (pr…
9898345 
…oject-chip#23494)
@s07641069
[Telink] Add all clusters app & clusters minimal app (Cherry-pick pro…
0b17bce 
…ject-chip#23383) (project-chip#23499)

* [Telink] Add all clusters app & clusters minimal app (project-chip#23383)

* [Telink] Add all-cluster-minimal-app & all-cluster-app

* [Telink] update md files &  set Teilink Light as FTD

* [Telink] Restyled

* [Telink] Add targets

* [Telink] Fix pair cmd example

* [Telink] restyled

* [Telink] Add new apps for target linux

* [Telink] Add note reg set up a valid Network Commissioning cluster;
Remove ThreadStartButton from minimal app.

* [Telink] Add targets
@s07641069
[Telink] Add Telink factory data & Update Telink image to 0.6.06 (pro…
cbfb908 
…ject-chip#23502) (project-chip#23548)
@pankore
[Ameba] Fix Trailing Null (project-chip#23485)
4744889 
* TC-BINFO-2.1 when reading location, it shows 3 chars. Remove trailing null after getPref_str_new
@Jerry-ESP @restyled-commits
Update the RegulatoryLocation and LocationCapability get and set logic (
256cd78 
project-chip#23579) (project-chip#23713)

* ESP32: add RegulatoryLocation and LocationCapability value init

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>

Co-authored-by: Restyled.io <[email protected]>
@s07641069
[Telink] Allow to erase entire NVS on factory reset by default; Fix I…
1d62999 
…DM-7.1 test. (Cherry-pick project-chip#23434 & project-chip#23676) (project-chip#23677)

* [Zephyr] Allow to erase entire NVS on factory reset (project-chip#23434)

* [Zephyr] Allow to erase entire NVS on factory reset

Currently, the default factory reset implementation simply
removes Matter (and OpenThread) settings instead of
formatting the non-volatile storage partition. The latter
approach may be advisable in the cases where no settings
need to survive a factory reset, as it is expected to work
properly regardless of the state of the storage partition.
Additionally, it will regain the original storage
performance if it has been loaded with a lot of stale data.

Signed-off-by: Damian Krolik <[email protected]>

* [Telink] Allow to erase entire NVS on factory reset by default; Fix IDM-7.1 test.

Signed-off-by: Damian Krolik <[email protected]>
@erwinpan1
Merge branch 'v1.0-branch-mvd-dev' into v1.0-branch
f14bcda
@erwinpan1 erwinpan1 merged commit 7c28eae into v1.0-branch-mvd-dev Nov 25, 2022
@github-actions
Copy link

All PRs require an issue to be accepted, please link an issue or mention it in the body using #<issue_id>

erwinpan1 pushed a commit that referenced this pull request May 29, 2023
@bzbarsky-apple
Fix ThreadSanitizer failure in controller factory. (project-chip#26824)
9f1a470 
* Fix ThreadSanitizer failure in controller factory.

The failure looks like this:

  WARNING: ThreadSanitizer: race on NSMutableArray (pid=11619)
    Read-only access of NSMutableArray at 0x7b0c0005f5b0 by thread T3:
      #0 -[__NSArrayM countByEnumeratingWithState:objects:count:] <null>:2 (CoreFoundation:x86_64+0x4a338)
      #1 -[MTRDeviceControllerFactory(InternalMethods) operationalInstanceAdded:] MTRDeviceControllerFactory.mm:855 (Matter:x86_64+0x1fd2a)
      #2 MTROperationalBrowser::OnBrowse(_DNSServiceRef_t*, unsigned int, unsigned int, int, char const*, char const*, char const*, void*) MTROperationalBrowser.mm:100 (Matter:x86_64+0x20ee63c)
      #3 handle_browse_response <null>:2 (libsystem_dnssd.dylib:x86_64+0x3733)
      #4 _dispatch_client_callout <null>:2 (libdispatch.dylib:x86_64+0x3316)

    Previous modifying access of NSMutableArray at 0x7b0c0005f5b0 by main thread:
      #0 -[__NSArrayM addObject:] <null>:2 (CoreFoundation:x86_64+0x2457a)
      #1 -[MTRDeviceControllerFactory createController] MTRDeviceControllerFactory.mm:719 (Matter:x86_64+0x1cee3)
      #2 -[MTRDeviceControllerFactory createControllerOnExistingFabric:error:] MTRDeviceControllerFactory.mm:534 (Matter:x86_64+0x19792)

The basic problem is that we are in the middle of adding an object to
_controllers on the API consumer thread when on the Matter thread we get our
browse notification.

The changes here don't aim to lock around all access to _controllers, but just
to make sure that our mutations of it can't race with the access on the Matter
thread.  More coarse locking would need to be done very carefully, given the
amount of dispath_sync to the Matter thread we have going on.

* Address review comments.
erwinpan1 pushed a commit that referenced this pull request May 29, 2023
@bzbarsky-apple
Fix thread race in MTRXPCListenerSampleTests. (project-chip#26862)
07a7ea5 
WARNING: ThreadSanitizer: race on NSMutableDictionary (pid=72050)
      Modifying access of NSMutableDictionary at 0x7b0800149020 by thread T7:
        #0 -[__NSDictionaryM setObject:forKey:] <null>:2 (CoreFoundation:x86_64+0x40d4e)
        #1 -[MTRXPCListenerSample listener:shouldAcceptNewConnection:] MTRXPCListenerSampleTests.m:116 (MatterTests:x86_64+0x48437b)
        #2 service_connection_handler_make_connection <null>:2 (Foundation:x86_64+0xdea93)

      Previous modifying access of NSMutableDictionary at 0x7b0800149020 by thread T4:
        #0 -[__NSDictionaryM removeObjectForKey:] <null>:2 (CoreFoundation:x86_64+0x6cd6d)
        #1 __59-[MTRXPCListenerSample listener:shouldAcceptNewConnection:]_block_invoke MTRXPCListenerSampleTests.m:119 (MatterTests:x86_64+0x484630)
erwinpan1 pushed a commit that referenced this pull request Oct 10, 2023
@bzbarsky-apple
Fix intermittent LSan failures running "darwin-framework-tool tests l…
b846dbe 
…ist". (project-chip#29666)

The typical failure there looks like this:

==29620==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 88 byte(s) in 1 object(s) allocated from:
    #0 0x106396e12 in calloc+0xa2 (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x51e12)
    #1 0x7ff800dc9789 in map_images_nolock+0x24b (libobjc.A.dylib:x86_64h+0x1789)
    #2 0x7ff800dc94db in map_images+0x42 (libobjc.A.dylib:x86_64h+0x14db)
    #3 0x113d721fa in invocation function for block in dyld4::RuntimeState::setObjCNotifiers(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x112 (dyld:x86_64+0xf1fa)
    #4 0x113d6d6c8 in dyld4::RuntimeState::withLoadersReadLock(void () block_pointer)+0x28 (dyld:x86_64+0xa6c8)
    #5 0x113d720e1 in dyld4::RuntimeState::setObjCNotifiers(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x51 (dyld:x86_64+0xf0e1)
    #6 0x113d85d44 in dyld4::APIs::_dyld_objc_notify_register(void (*)(unsigned int, char const* const*, mach_header const* const*), void (*)(char const*, mach_header const*), void (*)(char const*, mach_header const*))+0x4e (dyld:x86_64+0x22d44)
    #7 0x7ff800dc9343 in _objc_init+0x4fe (libobjc.A.dylib:x86_64h+0x1343)
    #8 0x7ff800d83992 in _os_object_init+0xc (libdispatch.dylib:x86_64+0x2992)
    #9 0x7ff800d911b7 in libdispatch_init+0x136 (libdispatch.dylib:x86_64+0x101b7)
    #10 0x7ff80bd34894 in libSystem_initializer+0xed (libSystem.B.dylib:x86_64+0x1894)
    #11 0x113d77e4e in invocation function for block in dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const+0xb5 (dyld:x86_64+0x14e4e)
    #12 0x113d9eaac in invocation function for block in dyld3::MachOAnalyzer::forEachInitializer(Diagnostics&, dyld3::MachOAnalyzer::VMAddrConverter const&, void (unsigned int) block_pointer, void const*) const+0xf1 (dyld:x86_64+0x3baac)
    #13 0x113d95e25 in invocation function for block in dyld3::MachOFile::forEachSection(void (dyld3::MachOFile::SectionInfo const&, bool, bool&) block_pointer) const+0x22c (dyld:x86_64+0x32e25)
    #14 0x113d64db2 in dyld3::MachOFile::forEachLoadCommand(Diagnostics&, void (load_command const*, bool&) block_pointer) const+0x80 (dyld:x86_64+0x1db2)
    #15 0x113d95bb6 in dyld3::MachOFile::forEachSection(void (dyld3::MachOFile::SectionInfo const&, bool, bool&) block_pointer) const+0xb2 (dyld:x86_64+0x32bb6)
    #16 0x113d9e603 in dyld3::MachOAnalyzer::forEachInitializer(Diagnostics&, dyld3::MachOAnalyzer::VMAddrConverter const&, void (unsigned int) block_pointer, void const*) const+0x1d1 (dyld:x86_64+0x3b603)
    #17 0x113d77d81 in dyld4::Loader::findAndRunAllInitializers(dyld4::RuntimeState&) const+0x8f (dyld:x86_64+0x14d81)
    #18 0x113d7e659 in dyld4::PrebuiltLoader::runInitializers(dyld4::RuntimeState&) const+0x1d (dyld:x86_64+0x1b659)
    #19 0x113d8b76d in dyld4::APIs::runAllInitializersForMain()+0x25 (dyld:x86_64+0x2876d)
    #20 0x113d6938c in dyld4::prepare(dyld4::APIs&, dyld3::MachOAnalyzer const*)+0xd72 (dyld:x86_64+0x638c)
    #21 0x113d684e3 in start+0x183 (dyld:x86_64+0x54e3)
erwinpan1 pushed a commit that referenced this pull request Apr 25, 2024
@Alami-Amine
pw_unit_test migration: lib support batch #1 (project-chip#33091)
3380876 
* pw_unit_test migration: lib support batch #1

* apply restyled patch

* integrate comments
erwinpan1 pushed a commit that referenced this pull request Aug 5, 2024
@vatsalghelani-csa @restyled-commits
Fix metadata_parser python module to make it wheel buildable. (projec…
95bf668 
…t-chip#34322)

* Fix the metadata module to make the wheel buildable

* Added the fix for metadata import

* Added fixes as per module build for metadata_testing_infrastructure

* Restyled by shfmt

* Make CI checks run

* Update build_python.sh

* Delete admin_storage.json

* Make metadata_parser python module wheel buildable within src/python_testing/matter_testing_infrastructure/ (#1)

* Adding metadata buildable wheel to src/python_testing/matter_testing_infrastructure
* Update build_python.sh
* Delete src/python_testing/matter_testing_infrastructure/build/lib/metadata_parser directory

---------

Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
config esp32 examples github integrations platform scripts telink vscode workflows zephyr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erwinpan1 @s07641069 @pankore @Jerry-ESP