Merge airpurifier from PR #31226 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* After finish Chef fan control manager * Add Step command to chef airpurifier * Add chef resource monitoring delegates * Support Chef AirPurfier for nRFConnect * Restyled by clang-format * Enable LocalizationConfigurate / TimeFormatLocalization * Remove TimeFormatLocalization and LocalizationConfiguration * Use std::unique_ptr and ValueOr in AirPurifier sample Use std::unique_ptr to manage the pointer in chef-resource-monitoring-delegates.cpp Add ValueOr to chip::Nullable and simplify the code based on it * Restyled by clang-format * Use ValueOr instead of check IsNull() * Fix typo * Replacing with chip::BitMask<ResourceMonitoring::Feature> * Fix typo * Restyled by clang-format * Remove comments * Remove unused comment * Use unique_ptr.reset() instead of unique_ptr = nullptr * Remove unused comment * Not using nullptr when using unique_ptr * Add comments to std::make_unique<ResourceMonitoring::Instance> * Restyled by clang-format * Use chip:BitMask(args...) instead of static_cast * Remove comments cause confusion * Fix speedSetting 1. Simplify the code by a new kLowest vriable 2. Return error when Attribute Read error * Restyled by clang-format * Make mFanControlManager a std::unique_ptr * Rename kLowest to kLowestSpeed * Restyled by clang-format * When decrease, we don't need to check speedMax * Using std::invoke & lambda to return the step * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.