-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the RegulatoryLocation and LocationCapability get and set logic #23579
Merged
yufengwangca
merged 2 commits into
project-chip:master
from
Jerry-ESP:ESP32/add-RegulatoryLocation-init
Nov 20, 2022
Merged
Update the RegulatoryLocation and LocationCapability get and set logic #23579
yufengwangca
merged 2 commits into
project-chip:master
from
Jerry-ESP:ESP32/add-RegulatoryLocation-init
Nov 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jerry-ESP
force-pushed
the
ESP32/add-RegulatoryLocation-init
branch
from
November 11, 2022 07:09
0dab361
to
7041fad
Compare
PR #23579: Size comparison from 008df4d to 7522e43 Increases (4 builds for esp32, telink)
Decreases (3 builds for psoc6, qpg, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Jerry-ESP
force-pushed
the
ESP32/add-RegulatoryLocation-init
branch
from
November 11, 2022 11:16
7522e43
to
68b87d9
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple and
kghost
November 11, 2022 11:16
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple and
xylophone21
November 11, 2022 11:16
Jerry-ESP
changed the title
[ESP32] Add RegulatoryLocation and LocationCapability value init and get function
Update the RegulatoryLocation and LocationCapability get and set logic
Nov 11, 2022
PR #23579: Size comparison from 008df4d to 68b87d9 Increases (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/include/platform/internal/GenericConfigurationManagerImpl.ipp
Outdated
Show resolved
Hide resolved
yufengwangca
approved these changes
Nov 11, 2022
src/include/platform/internal/GenericConfigurationManagerImpl.ipp
Outdated
Show resolved
Hide resolved
Jerry-ESP
force-pushed
the
ESP32/add-RegulatoryLocation-init
branch
from
November 14, 2022 07:48
68b87d9
to
d65aae2
Compare
PR #23579: Size comparison from 030bd45 to d65aae2 Increases (22 builds for bl702, cc13x2_26x2, k32w, mbed, nrfconnect, qpg, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (24 builds for bl702, cc13x2_26x2, k32w, linux, mbed, nrfconnect, qpg, telink)
|
Jerry-ESP
force-pushed
the
ESP32/add-RegulatoryLocation-init
branch
from
November 14, 2022 11:14
d65aae2
to
0cd9c7e
Compare
PR #23579: Size comparison from 030bd45 to 0cd9c7e Increases (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (39 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
|
Jerry-ESP
force-pushed
the
ESP32/add-RegulatoryLocation-init
branch
from
November 15, 2022 06:49
0cd9c7e
to
3949a10
Compare
PR #23579: Size comparison from 9a41c9c to 3949a10 Increases (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Nov 16, 2022
src/include/platform/internal/GenericConfigurationManagerImpl.ipp
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Nov 16, 2022
Jerry-ESP
force-pushed
the
ESP32/add-RegulatoryLocation-init
branch
from
November 18, 2022 02:40
3949a10
to
f9e04b5
Compare
PR #23579: Size comparison from 6978de7 to f9e04b5 Increases (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Jerry-ESP
added a commit
to Jerry-ESP/connectedhomeip
that referenced
this pull request
Nov 22, 2022
project-chip#23579) * ESP32: add RegulatoryLocation and LocationCapability value init * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]>
andy31415
pushed a commit
that referenced
this pull request
Nov 22, 2022
#23579) (#23713) * ESP32: add RegulatoryLocation and LocationCapability value init * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently interfaces for get and set RegulatoryLocation, LocationCapability are uncorrectly, the value we read out is not what we write but a fixed value, so I changed the logic according to spec.
In this PR
fix #23580: