-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[linux]: Use LocationCapability if GetRegulatoryLocation fail #23602
Merged
andy31415
merged 2 commits into
project-chip:master
from
yufengwangca:pr/platform/linux
Nov 17, 2022
Merged
[linux]: Use LocationCapability if GetRegulatoryLocation fail #23602
andy31415
merged 2 commits into
project-chip:master
from
yufengwangca:pr/platform/linux
Nov 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel and
lazarkov
November 15, 2022 05:56
pullapprove
bot
requested review from
vijs,
tecimovic,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
November 15, 2022 05:56
pullapprove
bot
added
review - pending
linux
platform
and removed
platform
linux
labels
Nov 15, 2022
PR #23602: Size comparison from 9a41c9c to 8a59564 Increases (2 builds for esp32, psoc6)
Decreases (12 builds for bl602, bl702, cyw30739, nrfconnect, psoc6, telink)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Nov 15, 2022
andy31415
reviewed
Nov 15, 2022
PR #23602: Size comparison from d2ae082 to 001d163 Increases (25 builds for bl602, bl702, cc13x2_26x2, esp32, linux, psoc6, telink)
Decreases (3 builds for cc13x2_26x2, cyw30739, esp32)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…t-chip#23602) * [linux]: Use LocationCapability if GetRegulatoryLocation fail * Address the review comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #23579, this is similar change for Linux platform, per spec, we should use the value of LocationCapability as RegulatoryLocation if GetRegulatoryLocation fail.