-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telink] use src/app/chip_data_model.cmake for data model inclusions (Cherry-pick #23255) #23466
Merged
andy31415
merged 2 commits into
project-chip:v1.0-branch
from
s07641069:telink_use_chip_data_model_cherry-pick
Nov 4, 2022
Merged
[Telink] use src/app/chip_data_model.cmake for data model inclusions (Cherry-pick #23255) #23466
andy31415
merged 2 commits into
project-chip:v1.0-branch
from
s07641069:telink_use_chip_data_model_cherry-pick
Nov 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roject-chip#23255) Co-authored-by: Andrei Litvin <[email protected]>
andy31415
approved these changes
Nov 3, 2022
PR #23466: Size comparison from a17c005 to d5bf255 Increases (2 builds for cc13x2_26x2, nrfconnect)
Decreases (8 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Full report (36 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23466: Size comparison from ff13388 to d3e1897 Increases (3 builds for bl602, psoc6, telink)
Decreases (6 builds for bl702, k32w, psoc6, telink)
Full report (29 builds for bl602, bl702, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Telink CMakeFiles directly include /src/app/util/* and zzz_generated paths for includes.
This makes any common refactors tedious. Mbed and NRF already use a common src/app/chip_data_model.cmake
#23255
Issue Being Resolved
#23225
Change overview
use src/app/chip_data_model.cmake for data model inclusions
Testing
Tested manually with chip-tool.
Steps:
Run: $ chip-tool pairing ble-thread <...>
Wait till success
Run: $ chip-tool onoff on ${NODE_ID }1
Wait till success
Run: $ chip-tool onoff off ${NODE_ID }1
Wait till success