Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #266: Include intercept when no model provided #370

Merged
merged 13 commits into from
Oct 10, 2024
Merged

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented Oct 3, 2024

Description

This PR closes #266.

It:

  • Adds a utility function .make_intercepts_explicit which takes a formula and puts a model dpar ~ 1 on any distributional parameters which 1. are not fixed, 2. are not mu, 3. do not have a formula
  • This utility function is used in epidist_formula.epidist_latent_individual
  • Simplifies epidist_family_prior.lognormal because no longer have to set priors on the untransformed sigma
  • Requires follow up work to:
  • Also fixed a bug in test that brms samples from the prior right which was highlighted by these changes 9d19d49 (not sure how it was passing before, perhaps because there wasn't an explicit model it worked OK)

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@athowes athowes force-pushed the force-include-model branch from f59fbf9 to 128c8f3 Compare October 9, 2024 12:50
@athowes athowes changed the title Issue #307: Include intercept when no model provided Issue #266: Include intercept when no model provided Oct 10, 2024
@athowes athowes marked this pull request as ready for review October 10, 2024 10:54
@athowes athowes requested a review from seabbs October 10, 2024 10:54
@seabbs seabbs enabled auto-merge (squash) October 10, 2024 12:25
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice this is great. All follow up tasks look good to me.

@seabbs seabbs merged commit 4150efa into main Oct 10, 2024
7 checks passed
@seabbs seabbs deleted the force-include-model branch October 10, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider setting intercept on any distributional parameters without a model
2 participants