-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #266: Include intercept when no model provided #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athowes
commented
Oct 3, 2024
athowes
force-pushed
the
force-include-model
branch
from
October 9, 2024 12:50
f59fbf9
to
128c8f3
Compare
athowes
changed the title
Issue #307: Include intercept when no model provided
Issue #266: Include intercept when no model provided
Oct 10, 2024
seabbs
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice this is great. All follow up tasks look good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #266.
It:
.make_intercepts_explicit
which takes aformula
and puts a modeldpar ~ 1
on any distributional parameters which 1. are not fixed, 2. are notmu
, 3. do not have a formulaepidist_formula.epidist_latent_individual
epidist_formula
to use S3 #372 we should move this out of being model-specificepidist_family_prior.lognormal
because no longer have to set priors on the untransformedsigma
epidist_family_prior.lognormal
with restructure. Probably this fits into Generalise handling priors for parameters set to constant #306brms
style formula input rather than requirebrms::bf()
as discussed in No model meta #307brms
samples from the prior right which was highlighted by these changes 9d19d49 (not sure how it was passing before, perhaps because there wasn't an explicit model it worked OK)Checklist